| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005412 | Spring engine | Lua | public | 2016-12-05 07:40 | 2016-12-05 12:30 | ||||
| Reporter | Google_Frog | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 103.0 +git | ||||||||
| Target Version | Fixed in Version | 103.0 +git | |||||||
| Summary | 0005412: GameRulesParams persist through Spring.Restart | ||||||||
| Description | GameRulesParams set by previous games appear in subsequent games. I do not know whether TeamRulesParams (or even UnitRulesParams) fail to be cleared. I have only detected this bug in luaUI because I mostly use GameRulesParams as a way to communicate with luaUI. I do not know whether luarules can see the persistent GameRulesParams but it would be very easy to cause a desync if they did. Chicken mode in ZK is a simple test as per this ticket: https://github.com/ZeroK-RTS/Zero-K/issues/1672 Start a local skirmish with a chicken present then start a local skirmish without a chicken present. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Google_Frog (reporter) 2016-12-05 08:21 |
I confirmed that teamRulesParams do not persist. |
|
Google_Frog (reporter) 2016-12-05 08:23 |
I added a workaround as a stopgap. https://github.com/ZeroK-RTS/Zero-K/blob/master/LuaRules/Gadgets/hax_gamerulesparam_clear.lua |
|
Kloot (developer) 2016-12-05 12:28 Last edited: 2016-12-05 12:30 |
If you call Restart with an empty first argument, Spring Reloads instead and becomes more vulnerable to bugs like these. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-12-05 07:40 | Google_Frog | New Issue | |
| 2016-12-05 08:21 | Google_Frog | Note Added: 0016931 | |
| 2016-12-05 08:23 | Google_Frog | Note Added: 0016932 | |
| 2016-12-05 12:28 | Kloot | Assigned To | => Kloot |
| 2016-12-05 12:28 | Kloot | Status | new => resolved |
| 2016-12-05 12:28 | Kloot | Resolution | open => fixed |
| 2016-12-05 12:28 | Kloot | Fixed in Version | => 103.0 +git |
| 2016-12-05 12:28 | Kloot | Note Added: 0016933 | |
| 2016-12-05 12:30 | Kloot | Note Edited: 0016933 | View Revisions |
| Issue History |