| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005390 | Spring engine | General | public | 2016-11-13 15:08 | 2016-11-15 14:41 | ||||
| Reporter | Google_Frog | ||||||||
| Assigned To | hokomoko | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 103.0 +git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0005390: Placement UI of floating structures is incorrect on water | ||||||||
| Description | The UI for the placement of structures is incorrect when the structure floats. The blueprint and issued command are placed on the surface of the ocean floor which the mouse is hovered over. In effect, the ray trace is ignoring the water. The ray trace should be improved to ignore water only when the structure to be placed does not float. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Google_Frog (reporter) 2016-11-15 08:17 |
https://github.com/spring/spring/blob/develop/rts/Game/UI/GuiHandler.cpp#L2432 The false at the end of that line needs to be changed to whether the unitDefID stored in startInfo can float. https://github.com/spring/spring/blob/develop/rts/Game/UI/GuiHandler.cpp#L2162 This is where the build command is given. The LineGroundCol does not take water into account so probably needs to be changed to a GuiTraceRay. |
|
hokomoko (developer) 2016-11-15 14:41 |
Fix 36e115b168f563f4b6498f5ae0059fc4d3c9f593 committed to develop branch: Fix 0005390, repo: spring changeset id: 7588 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-11-13 15:08 | Google_Frog | New Issue | |
| 2016-11-15 08:17 | Google_Frog | Note Added: 0016869 | |
| 2016-11-15 14:41 | hokomoko | Changeset attached | => spring develop 36e115b1 |
| 2016-11-15 14:41 | hokomoko | Note Added: 0016870 | |
| 2016-11-15 14:41 | hokomoko | Assigned To | => hokomoko |
| 2016-11-15 14:41 | hokomoko | Status | new => resolved |
| 2016-11-15 14:41 | hokomoko | Resolution | open => fixed |
| Issue History |