| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0004893 | Spring engine | General | public | 2015-07-08 08:21 | 2015-07-08 10:06 | ||||||||
| Reporter | Google_Frog | ||||||||||||
| Assigned To | jK | ||||||||||||
| Priority | normal | Severity | minor | Reproducibility | sometimes | ||||||||
| Status | feedback | Resolution | reopened | ||||||||||
| Product Version | 99.0+git | ||||||||||||
| Target Version | Fixed in Version | ||||||||||||
| Summary | 0004893: 99.0.1-74 Music plays slowly | ||||||||||||
| Description | Occasionally the music in ZK has one track play slowly and at lower pitch. It plays for a while until it is interrupted by the next track (because tracks are expected to have a fixed length). This has occurred since at least 91.0. I don't know what is broken. Perhaps some weird sound features (such as Doppler shift or sound matching game speed) are being applied when they should not be. Perhaps sound streams are broken. Music widget with sound playing line: https://github.com/ZeroK-RTS/Zero-K/blob/master/LuaUI/Widgets/snd_music.lua#L148 | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Checked infolog.txt for Errors | |||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
jK (developer) 2015-07-08 08:46 |
game bug: https://github.com/ZeroK-RTS/Zero-K/blob/master/gamedata/sounds.lua#L103 |
|
Google_Frog (reporter) 2015-07-08 10:03 Last edited: 2015-07-08 10:06 |
I've got to make a few assumptions to interpret your response. Here is my attempt. "I looked at your sounds.lua and it looks like you think noVariation (dopplerscale = 0 and in3d = false) is being applied to the music sounds. This is not what is happening because there is a bug in the AutoAdd function that causes it to add all sounds, not just the sounds in the sub directory. The bug is caused by the lack of subDir on this line: https://github.com/ZeroK-RTS/Zero-K/blob/master/gamedata/sounds.lua#L104 Each call of AutoAdd adds all sounds and this causes the music sounds to have the wrong options set." This is wrong, AutoAdd works correctly as seen by these Echos: https://github.com/ZeroK-RTS/Zero-K/commit/343e7ffb54e50c28d969ac54c3e8ba6ed7ce3bd3 which result in this infolog: http://pastebin.com/qBrfmShM |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-07-08 08:21 | Google_Frog | New Issue | |
| 2015-07-08 08:46 | jK | Note Added: 0014938 | |
| 2015-07-08 08:46 | jK | Status | new => closed |
| 2015-07-08 08:46 | jK | Assigned To | => jK |
| 2015-07-08 08:46 | jK | Resolution | open => fixed |
| 2015-07-08 10:03 | Google_Frog | Note Added: 0014939 | |
| 2015-07-08 10:03 | Google_Frog | Status | closed => feedback |
| 2015-07-08 10:03 | Google_Frog | Resolution | fixed => reopened |
| 2015-07-08 10:04 | Google_Frog | Note Edited: 0014939 | View Revisions |
| 2015-07-08 10:06 | Google_Frog | Note Edited: 0014939 | View Revisions |
| 2015-07-08 10:06 | Google_Frog | Note Edited: 0014939 | View Revisions |
| Issue History |