| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004851 | Spring engine | General | public | 2015-06-27 16:56 | 2015-06-29 13:38 | ||||
| Reporter | Google_Frog | ||||||||
| Assigned To | jK | ||||||||
| Priority | normal | Severity | major | Reproducibility | sometimes | ||||
| Status | closed | Resolution | no change required | ||||||
| Product Version | 99.0+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004851: 99.0.1-20 After a while some CEG types not being drawn | ||||||||
| Description | In a recent game I noticed that almost no effects were being drawn. The only things drawn seemed to be: * The black snoke that comes out of crashing aircraft. * Bubbles left in the wake of a torpedo. * The yellow flash when a unit explodes which seems to be due to usedefaultexplosions=true in the ceg. * groundflash ceg types. As far as I could tell no other effects were drawn. It was as if I was at the particle limit because some dead particles were counting against the limit. I say this because one of the numbers after Particles in debug view was very large. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Google_Frog (reporter) 2015-06-27 16:58 |
http://zero-k.info/Battles/Detail/361128 |
|
cleanrock (reporter) 2015-06-28 08:06 |
I ran the attached demo in a debug build and get an assert: spring: /home/johanr/my_projects/spring/rts/System/Object.cpp:146: virtual void CObject::DeleteDeathDependence(CObject*, DependenceType): Assertion `!detached && !obj->detached' failed. [f=0001374] [CrashHandler] Error: Aborted (SIGABRT) in spring 99.0.1-20-gc999972 develop (Debug) [f=0001374] [CrashHandler] Error: Halted Stacktrace for Spring 99.0.1-20-gc999972 develop (Debug) using libunwind: [f=0001374] [CrashHandler] Error: (Signal handler calls suppressed [3]. Inlined calls denoted by < > brackets.) [f=0001374] [CrashHandler] Error: [03] /usr/lib/libc.so.6(gsignal+0x38) [0x7feb8ca25528] __GI_raise [f=0001374] [CrashHandler] Error: [04] /usr/lib/libc.so.6(abort+0x16a) [0x7feb8ca2693a] __GI_abort [f=0001374] [CrashHandler] Error: [05] /usr/lib/libc.so.6(+0x2c3a7) [0x7feb8ca1e3a7] __assert_fail_base [f=0001374] [CrashHandler] Error: [06] /usr/lib/libc.so.6(+0x2c452) [0x7feb8ca1e452] __GI___assert_fail [f=0001374] [CrashHandler] Error: [07] .../my_projects/spring/rts/System/Object.cpp:147 CObject::DeleteDeathDependence(CObject*, DependenceType) [f=0001374] [CrashHandler] Error: [08] .../my_projects/spring/rts/Sim/Units/UnitTypes/Builder.cpp:620 CBuilder::StopBuild(bool) [f=0001374] [CrashHandler] Error: [09] .../my_projects/spring/rts/Sim/Units/UnitTypes/Builder.cpp:505 CBuilder::SetRepairTarget(CUnit*) [f=0001374] [CrashHandler] Error: [10] .../my_projects/spring/rts/Sim/Units/CommandAI/BuilderCAI.cpp:737 CBuilderCAI::ExecuteRepair(Command&) [f=0001374] [CrashHandler] Error: [11] .../my_projects/spring/rts/Sim/Units/CommandAI/BuilderCAI.cpp:497 CBuilderCAI::SlowUpdate() [f=0001374] [CrashHandler] Error: [12] .../my_projects/spring/rts/Sim/Units/CommandAI/MobileCAI.cpp:429 CMobileCAI::ExecuteSetWantedMaxSpeed(Command&) [f=0001374] [CrashHandler] Error: [13] .../my_projects/spring/rts/Sim/Units/CommandAI/MobileCAI.cpp:405 CMobileCAI::Execute() [f=0001374] [CrashHandler] Error: [14] .../my_projects/spring/rts/Sim/Units/CommandAI/MobileCAI.cpp:395 CMobileCAI::SlowUpdate() [f=0001374] [CrashHandler] Error: [15] .../my_projects/spring/rts/Sim/Units/CommandAI/BuilderCAI.cpp:511 CBuilderCAI::SlowUpdate() [f=0001374] [CrashHandler] Error: [16] .../my_projects/spring/rts/Sim/Units/CommandAI/CommandAI.cpp:1434 CCommandAI::FinishCommand() [f=0001374] [CrashHandler] Error: [17] .../my_projects/spring/rts/Sim/Units/CommandAI/MobileCAI.cpp:1032 CMobileCAI::FinishCommand() [f=0001374] [CrashHandler] Error: [18] .../my_projects/spring/rts/Sim/Units/CommandAI/BuilderCAI.cpp:538 CBuilderCAI::FinishCommand() [f=0001374] [CrashHandler] Error: [19] .../my_projects/spring/rts/Sim/Units/CommandAI/CommandAI.cpp:1068 CCommandAI::ExecuteRemove(Command const&) [f=0001374] [CrashHandler] Error: [20] .../my_projects/spring/rts/Sim/Units/CommandAI/CommandAI.cpp:1421 CCommandAI::DependentDied(CObject*) [f=0001374] [CrashHandler] Error: [21] .../my_projects/spring/rts/System/Object.cpp:53 (discriminator 2) CObject::~CObject() [f=0001374] [CrashHandler] Error: [22] .../my_projects/spring/rts/Sim/Objects/WorldObject.h:38 CWorldObject::~CWorldObject() [f=0001374] [CrashHandler] Error: [23] .../my_projects/spring/rts/Sim/Objects/SolidObject.cpp:129 CSolidObject::~CSolidObject() [f=0001374] [CrashHandler] Error: [24] .../my_projects/spring/rts/Sim/Features/Feature.cpp:91 CFeature::~CFeature() [f=0001374] [CrashHandler] Error: [25] .../my_projects/spring/rts/Sim/Features/Feature.cpp:91 CFeature::~CFeature() [f=0001374] [CrashHandler] Error: [26] .../my_projects/spring/rts/Sim/Features/FeatureHandler.cpp:466 CFeatureHandler::Update() [f=0001374] [CrashHandler] Error: [27] .../my_projects/spring/rts/Game/Game.cpp:1580 CGame::SimFrame() This assert is probably not related to the particle issue but we may as well fix it in this ticket since we have the demo here. |
|
Google_Frog (reporter) 2015-06-28 09:25 |
Happened again: second game http://zero-k.info/Battles/Detail/361257 |
|
Google_Frog (reporter) 2015-06-28 09:41 Last edited: 2015-06-28 09:55 |
I have MaxParticles = 20000. At about 26:00 in the second game the number of particles jumps from around 4000-7000 to 15k-25k seemingly due to events in the game. After this point the particle stays above 30k and climbs to 60k at 29:00 by which point all the particles are no longer drawn. I did '/luarules clear' (destroys all units and features, requires /cheat) at around 34:00 and by 36:00 the reported number of particles is 616k and continues to increase. |
|
Google_Frog (reporter) 2015-06-28 09:54 |
I tried '/luarules clear' at 26:00 ('/skip 1560') and the particle count was about 4000. At this point there are no visible particles (because there are no units or features) but the number of particles increases at a rate of about 2500 per minute. So something is causing the particle count to increase. |
|
Google_Frog (reporter) 2015-06-28 09:59 Last edited: 2015-06-28 12:00 |
8194 particles at 15:00. When cleared the particles drops to 0 by 15:18. Particles drop to 0 if everything is cleared at 20:00. 4862 particles at 23:00. Drops to 0 by 23:15. Clearing everything at 25:00 causes particles drop initially but one non-bracket particle remains and there is unbounded growth of bracket particles. Same thing happens at 24:00. Happens at 23:30. So far the bugged particle appears between 23:00 and 23:30. Bug occurs if cleared at 23:20. Does not occur if cleared at 23:10. |
|
cleanrock (reporter) 2015-06-28 11:53 |
About the assert: obj->detached being true triggers the assert hokomoko, I saw you added this recently: https://github.com/spring/spring/commit/82c71fd You may want to take a look at this. |
|
cleanrock (reporter) 2015-06-28 13:23 |
I tried second demo and got a new assert: [f=0031616] ... spring: /home/johanr/my_projects/spring/rts/Sim/Projectiles/ProjectileHandler.cpp:165: void MAPPOS_SANITY_CHECK(float3): Assertion `v.x >= -(float3::maxxpos * 16.0f)' failed. |
|
Google_Frog (reporter) 2015-06-28 14:03 |
Is that about projectiles being far away from the center of the map? That looks normal to me. It would be caused by this: https://github.com/ZeroK-RTS/Zero-K/blob/master/LuaRules/Gadgets/weapon_noexplode_stopper.lua#L63 There is no way to delete a projectile without causing its explosion. My solution was to send it far away. |
|
jK (developer) 2015-06-29 05:52 |
game bug: reef's starburst weapon (the visible one) has an insane high flightime of 100 (seconds!) AND collideGround = false. So when a target moves or gets killed before the starburst hits, the missile will fly further underground and meanwhile creating more and more particles. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-06-27 16:56 | Google_Frog | New Issue | |
| 2015-06-27 16:57 | Google_Frog | File Added: debugView.jpg | |
| 2015-06-27 16:58 | Google_Frog | File Added: replayMantisDislikes3mbFilesAndZipIsInMyContextMenu.zip | |
| 2015-06-27 16:58 | Google_Frog | Note Added: 0014733 | |
| 2015-06-28 08:06 | cleanrock | Note Added: 0014737 | |
| 2015-06-28 09:25 | Google_Frog | Note Added: 0014738 | |
| 2015-06-28 09:26 | Google_Frog | File Added: secondGame.zip | |
| 2015-06-28 09:41 | Google_Frog | Note Added: 0014739 | |
| 2015-06-28 09:44 | Google_Frog | Note Edited: 0014739 | View Revisions |
| 2015-06-28 09:44 | Google_Frog | Note Edited: 0014739 | View Revisions |
| 2015-06-28 09:45 | Google_Frog | Note Edited: 0014739 | View Revisions |
| 2015-06-28 09:54 | Google_Frog | Note Added: 0014740 | |
| 2015-06-28 09:55 | Google_Frog | Note Edited: 0014739 | View Revisions |
| 2015-06-28 09:59 | Google_Frog | Note Added: 0014741 | |
| 2015-06-28 10:00 | Google_Frog | Note Edited: 0014741 | View Revisions |
| 2015-06-28 10:06 | Google_Frog | Note Edited: 0014741 | View Revisions |
| 2015-06-28 11:06 | Google_Frog | Note Edited: 0014741 | View Revisions |
| 2015-06-28 11:09 | Google_Frog | Note Edited: 0014741 | View Revisions |
| 2015-06-28 11:13 | Google_Frog | Note Edited: 0014741 | View Revisions |
| 2015-06-28 11:19 | Google_Frog | Note Edited: 0014741 | View Revisions |
| 2015-06-28 11:53 | cleanrock | Note Added: 0014744 | |
| 2015-06-28 12:00 | Google_Frog | Note Edited: 0014741 | View Revisions |
| 2015-06-28 13:23 | cleanrock | Note Added: 0014746 | |
| 2015-06-28 14:03 | Google_Frog | Note Added: 0014747 | |
| 2015-06-29 05:52 | jK | Note Added: 0014760 | |
| 2015-06-29 06:55 | jK | Status | new => closed |
| 2015-06-29 06:55 | jK | Assigned To | => jK |
| 2015-06-29 06:55 | jK | Resolution | open => no change required |
| 2015-06-29 13:38 | hokomoko | Changeset attached | => spring develop 12dfee96 |
| Issue History |