| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004662 | Spring engine | General | public | 2015-02-04 18:33 | 2015-04-05 09:25 | ||||
| Reporter | hokomoko | ||||||||
| Assigned To | cleanrock | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 98.0.1+git | ||||||||
| Target Version | Fixed in Version | 98.0.1+git | |||||||
| Summary | 0004662: haveUserTarget is also set for weapons that have a different target | ||||||||
| Description | Basically AttackUnit in Unit.cpp sets all weapons' haveUserTarget to true, even if they can't target the new target and still have their previous targets (which weren't set by the user). The following PR should fix this. https://github.com/spring/spring/pull/166 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
silentwings (reporter) 2015-02-04 18:54 Last edited: 2015-02-04 19:03 |
I don't think the default behaviour should change. There could easily be gadgets/widgets/unitscripts, not to mention players expectations of how units behave, that rely on the current behaviour. Another issue could be game re-implementing some target selection in widgets/gadgets/scripts - then userTarget might mean something different to what the player thinks are user targets. |
|
FLOZi (reporter) 2015-02-04 19:22 |
If you like bad logic, use previous engine version. Surely it makes sense that userTargets should obey targetting categories. |
|
silentwings (reporter) 2015-02-04 22:59 Last edited: 2015-02-04 23:08 |
edit: Sorry, I misunderstood what effect this had. Ignore previous comment. It is still a breaking change though, just a sensible one! |
|
hokomoko (developer) 2015-04-04 23:07 |
Should be fixed in https://github.com/spring/spring/commit/b31e9ffbbcfbacabe63b86eb52dd5d1efd9a78a9 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-06-29 22:02 | abma | Changeset attached | => spring develop 2b3222f5 |
| 2015-02-04 18:33 | hokomoko | New Issue | |
| 2015-02-04 18:54 | silentwings | Note Added: 0013988 | |
| 2015-02-04 18:57 | silentwings | Note Edited: 0013988 | View Revisions |
| 2015-02-04 18:58 | silentwings | Note Edited: 0013988 | View Revisions |
| 2015-02-04 19:03 | silentwings | Note Edited: 0013988 | View Revisions |
| 2015-02-04 19:22 | FLOZi | Note Added: 0013990 | |
| 2015-02-04 22:59 | silentwings | Note Added: 0013991 | |
| 2015-02-04 23:05 | silentwings | Note Edited: 0013991 | View Revisions |
| 2015-02-04 23:07 | silentwings | Note Edited: 0013991 | View Revisions |
| 2015-02-04 23:08 | silentwings | Note Edited: 0013991 | View Revisions |
| 2015-04-04 23:07 | hokomoko | Note Added: 0014275 | |
| 2015-04-05 09:25 | cleanrock | Status | new => resolved |
| 2015-04-05 09:25 | cleanrock | Fixed in Version | => 98.0.1+git |
| 2015-04-05 09:25 | cleanrock | Resolution | open => fixed |
| 2015-04-05 09:25 | cleanrock | Assigned To | => cleanrock |
| Issue History |