| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004482 | Spring engine | General | public | 2014-08-01 17:48 | 2014-09-09 22:40 | ||||
| Reporter | Google_Frog | ||||||||
| Assigned To | jK | ||||||||
| Priority | normal | Severity | feature | Reproducibility | N/A | ||||
| Status | closed | Resolution | no change required | ||||||
| Product Version | 97.0.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004482: Configurable PFS update rate | ||||||||
| Description | I would like to configure the PFS update rate in modrules. For me this would be a workaround until 4461 is fixed. This is not the only purpose though because configurable pathfinding resource cost sounds like a good feature for other applications. My reasoning is as follows. I do not like using or supporting 91.0 and the lack of engine testing in the last month worries me. The best testing has resulted from switching the ZK host engines to the latest dev engine. I am unable to do this many players complain about performance problems so they scream for 91.0. The problems seem to occur when there are many PFS updates. Players complain a lot less about the really slow PFS update rate in 91.0. So I would used the new engine with reduced PFS rate in order to use an engine better than 91.0 and contribute to testing. If the PFS update does not cause their problems then this is useful information. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
 Notes |
|
|
Google_Frog (reporter) 2014-08-05 16:35 |
From my testing and look at the code it seems to me that this implementation does barely anything. The Clamp removes the effect of the configuration. I see that multiplying after the Clamp does not make sense. So my suggestion is to let modrules set the constant SQUARES_TO_UPDATE because the current value of 1000 does not seem to be particularly special. |
|
Google_Frog (reporter) 2014-08-09 18:28 |
I managed to get Spring to build so tested an implementation and made a PR: https://github.com/spring/spring/pull/119 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-08-01 17:48 | Google_Frog | New Issue | |
| 2014-08-02 00:49 | abma | Relationship added | related to 0004461 |
| 2014-08-03 04:35 | jK | Assigned To | => jK |
| 2014-08-03 04:35 | jK | Status | new => assigned |
| 2014-08-05 14:14 | jK | Changeset attached | => spring develop 3ff7cf12 |
| 2014-08-05 14:14 | jK | Status | assigned => resolved |
| 2014-08-05 14:14 | jK | Resolution | open => fixed |
| 2014-08-05 16:35 | Google_Frog | Note Added: 0013471 | |
| 2014-08-05 16:35 | Google_Frog | Status | resolved => feedback |
| 2014-08-05 16:35 | Google_Frog | Resolution | fixed => reopened |
| 2014-08-09 18:28 | Google_Frog | Note Added: 0013497 | |
| 2014-08-09 18:28 | Google_Frog | Status | feedback => assigned |
| 2014-09-09 22:40 | jK | Status | assigned => closed |
| 2014-09-09 22:40 | jK | Resolution | reopened => no change required |
| Issue History |