| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004471 | Spring engine | General | public | 2014-07-11 13:32 | 2015-03-24 12:19 | ||||
| Reporter | Skasi | ||||||||
| Assigned To | cleanrock | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 97.0.1+git | ||||||||
| Target Version | Fixed in Version | 98.0.1+git | |||||||
| Summary | 0004471: Area commands are spherical instead of cylindrical | ||||||||
| Description | Area commands such as arearepair and areareclaim only consider targets within a sphere. That means arearepair does not always target units flying at a high altitude even when they are above the area. | ||||||||
| Steps To Reproduce | Have a damaged gunship fly high above ground. Issue a small area repair command right below the gunship. Make sure that the radius of the area command is smaller than the flight height. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
abma (administrator) 2015-03-18 16:16 |
afaik repair range is spherical, too. imo thats just a visual "problem", the command shows just a cylindrical area when in real its spherical. |
|
cleanrock (reporter) 2015-03-22 08:23 |
https://github.com/spring/spring/commit/38e1e9bf9f14ec025effef6f042cafc5b11c575a This hopefully don't have unwanted effects. Please test and reopen if needed. |
|
Skasi (reporter) 2015-03-22 19:38 Last edited: 2015-03-22 19:40 |
Arearepair works fine now. Areareclaim for debris is still spherical. Looking through the code of the edited file https://github.com/spring/spring/blob/38e1e9bf9f14ec025effef6f042cafc5b11c575a/rts/Sim/Units/CommandAI/BuilderCAI.cpp maybe both occurrences of "GetFeaturesExact" (for area-reclaim and area-resurrection of features) and "GetUnits" (for what looks like area-capture) need a third argument "false" as well. |
|
cleanrock (reporter) 2015-03-24 12:19 |
https://github.com/spring/spring/commit/e8196534ef8a2500e0fc4e5f862542bcdbe886ae I hope it got it all this time. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-07-11 13:32 | Skasi | New Issue | |
| 2015-03-18 16:16 | abma | Note Added: 0014193 | |
| 2015-03-22 08:23 | cleanrock | Note Added: 0014202 | |
| 2015-03-22 08:23 | cleanrock | Status | new => resolved |
| 2015-03-22 08:23 | cleanrock | Fixed in Version | => 98.0.1+git |
| 2015-03-22 08:23 | cleanrock | Resolution | open => fixed |
| 2015-03-22 08:23 | cleanrock | Assigned To | => cleanrock |
| 2015-03-22 19:38 | Skasi | Note Added: 0014211 | |
| 2015-03-22 19:38 | Skasi | Status | resolved => feedback |
| 2015-03-22 19:38 | Skasi | Resolution | fixed => reopened |
| 2015-03-22 19:40 | Skasi | Note Edited: 0014211 | View Revisions |
| 2015-03-24 12:19 | cleanrock | Note Added: 0014222 | |
| 2015-03-24 12:19 | cleanrock | Status | feedback => resolved |
| 2015-03-24 12:19 | cleanrock | Resolution | reopened => fixed |
| Issue History |