View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0004380 | Spring engine | Lua | public | 2014-05-06 00:22 | 2014-05-09 00:06 | ||||
Reporter | MA3o | ||||||||
Assigned To | Kloot | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | 96.0 | ||||||||
Target Version | Fixed in Version | 97.0 | |||||||
Summary | 0004380: "FeatureDamaged" callin sends no attackerID and attackerDefID | ||||||||
Description | The callin "FeatureDamaged" as is described in the Wiki ( addon.FeatureDamaged(featureID, featureDefID, featureTeam, damage, weaponDefID, projectileID, attackerID, attackerDefID, attackerTeam) ) doesn't work. "attackerID" and "attackerDefID" are nil every time I tried. I made sure there is an attacker (a tank unit) and weaponDefID is passed correctly, but the other two (and maybe attackerTeam, I didn't try) don't. | ||||||||
Steps To Reproduce | - Create a synced gadget that uses the callin as described in wiki (not sure if there is the same issue in unsynced gadgets and widgets) - try to Echo the parameters mentioned - see what happens ingame | ||||||||
Tags | No tags attached. | ||||||||
Checked infolog.txt for Errors | |||||||||
Attached Files |
|
![]() |
|
FLOZi (reporter) 2014-05-07 18:54 |
Using 96.0 as specified in ticket -> Base content gadgethandler does supply it: https://github.com/spring/spring/blob/96.0/cont/base/springcontent/LuaGadgets/gadgets.lua#L1480 and LuaHandle does pass it: https://github.com/spring/spring/blob/96.0/rts/Lua/LuaHandle.cpp#L1415 So unsure as to why it wouldn't work. (that particular wiki page is in some ways written for 97+ but this should be correct for 96) |
abma (administrator) 2014-05-09 00:06 |
https://github.com/spring/spring/commit/f47d15609c2bc66aa4d0571aa5cc6abc6e1b140c thanks kloot! :) |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2014-05-06 00:22 | MA3o | New Issue | |
2014-05-07 18:54 | FLOZi | Note Added: 0013043 | |
2014-05-09 00:06 | abma | Note Added: 0013044 | |
2014-05-09 00:06 | abma | Status | new => resolved |
2014-05-09 00:06 | abma | Fixed in Version | => 97.0 |
2014-05-09 00:06 | abma | Resolution | open => fixed |
2014-05-09 00:06 | abma | Assigned To | => Kloot |