2025-07-20 16:41 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0004038Spring engineLuapublic2013-10-07 23:13
ReporterTheFatController 
Assigned ToKloot 
PrioritynormalSeverityblockReproducibilityalways
StatusresolvedResolutionfixed 
Product Version94.1.1+git 
Target VersionFixed in Version 
Summary0004038: 94.1.1-1275 - gadgets.lua does not chain UnitPreDamaged calls correctly
DescriptionIf you have two gadgets using UnitPreDamaged, if the first one returns a modified damage amount then the second one currently does not receive the new damage amount but the original damage again in its UnitPreDamaged callin

This means only the last gadget to execute UnitPreDamaged will affect the damage amount.

Looking at the code I believe FeaturePreDamaged is also affected by this behaviour

Thanks!
Steps To ReproduceAttached predamagetest.zip with 2 gadgets, watch the echos, the damage amount doesnt change
Additional InformationLooks like it was changed in https://github.com/spring/spring/commit/85779b57d7b45010b3f6e975ce65ca601e36747d
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
+Relationships

-Notes
There are no notes attached to this issue.
+Notes

-Issue History
Date Modified Username Field Change
2013-10-07 23:02 TheFatController New Issue
2013-10-07 23:02 TheFatController File Added: predamagedtest.zip
2013-10-07 23:13 Kloot Changeset attached => spring develop 15982303
2013-10-07 23:13 Kloot Assigned To => Kloot
2013-10-07 23:13 Kloot Status new => resolved
2013-10-07 23:13 Kloot Resolution open => fixed
+Issue History