0003914: desync with syncdebug build (seems to be CEG related)

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003914

Spring engine

General

public

2013-08-03 16:37

2013-08-04 21:55

Reporter

abma

Assigned To

Priority

normal

Severity

crash

Reproducibility

have not tried

Status

resolved

Resolution

fixed

Product Version

94.1.1+git

Target Version

95.0

Fixed in Version

Summary

0003914: desync with syncdebug build (seems to be CEG related)

Description

http://buildbot.springrts.com/builders/validationtests/builds/3246/steps/validation%20test/logs/stdio

[f=0000390] Sync error for ValidationClient in frame 321 (got e49bff7d, correct is b66bbf2e)

Additional Information

Server: === Backtrace 1 ===
Server: #0 Assert<int> [/home/buildbot/slave/zydox-fedora/build/build/syncdebug/../../rts/System/Sync/SyncedPrimitiveBase.h:48]
Server: #1 CProjectileHandler::AddProjectile(CProjectile*) [/home/buildbot/slave/zydox-fedora/build/build/syncdebug/../../rts/Sim/Projectiles/ProjectileHandler.cpp:334]
Server: #2 CProjectile::Init(float3 const&, CUnit*) [/home/buildbot/slave/zydox-fedora/build/build/syncdebug/../../rts/Sim/Projectiles/Projectile.cpp:139]
Server: 0000003 CCustomExplosionGenerator::Explosion(unsigned int, float3 const&, float, float, CUnit*, float, CUnit*, float3 const&) [/home/buildbot/slave/zydox-fedora/build/build/syncdebug/../../rts/Sim/Projectiles/ExplosionGenerator.cpp:981 (discriminator 2)]
Server: 0000004 LuaSyncedCtrl::SpawnCEG(lua_State*) [/home/buildbot/slave/zydox-fedora/build/build/syncdebug/../../rts/Lua/LuaSyncedCtrl.cpp:3691 (discriminator 1)]

Tags

No tags attached.

Checked infolog.txt for Errors

Attached Files

[syncdebug]{develop}94.1.1-815-g296bcb32013-08-03_16-05-57-dbg.7z (156,461 bytes) 2013-08-03 16:37

Relationships

related to

0002731

resolved

Kloot

desync in "Spring 83.0.1-136-gaeee060 release"

Relationships

Notes
~0011151 abma (administrator) 2013-08-03 16:37	not sure if this desync is new...

~0011152 abma (administrator) 2013-08-03 17:26	the ceg "gate" is spawned when the desync happens

~0011153 abma (administrator) 2013-08-03 17:31	from effects/gate.lua: ["gate"] = { boom = { air = true, class = [[CExpGenSpawner]], count = 1, ground = true, water = true, underwater = true, properties = { delay = 0, explosiongenerator = [[custom:GATE_TELEPORT]], pos = [[0, 0, 0]], }, }, },

~0011154 abma (administrator) 2013-08-03 17:50	why is there no difference between synced & unsynced here? https://github.com/spring/spring/blob/develop/rts/Sim/Projectiles/ProjectileHandler.cpp#L523 & https://github.com/spring/spring/blob/develop/rts/Sim/Projectiles/ProjectileHandler.cpp#L526

~0011156 abma (administrator) 2013-08-03 19:28	maybe the check is invalid? ASSERT_SYNCED(freeIDs->size()); https://github.com/spring/spring/blob/develop/rts/Sim/Projectiles/ProjectileHandler.cpp#L332

~0011157 abma (administrator) 2013-08-03 20:07	default build desyncs as well: http://buildbot.springrts.com/builders/validationtests/builds/3251/steps/validation%20test/logs/stdio

~0011165 cleanrock (reporter) 2013-08-04 16:55	I find it odd that ASSERT_SYNCED(freeIDs->size()); was triggered. Doesn't that mean that all 16384 ids have been exhausted ? Perhaps zk/cai is broken and dont "return" projectiles or syncdebug is broken.

~0011166 abma (administrator) 2013-08-04 16:58	no, that does mean (afaik) that freeIDs->size() on the server != size on the "client".

~0011167 abma (administrator) 2013-08-04 20:13	desync possible happens here: https://github.com/spring/spring/blob/develop/rts/Sim/Projectiles/ExplosionGenerator.cpp#L982 but i don't understand the code :-\|

~0011168 jK (developer) 2013-08-04 20:39	wonder where SPW_SYNCED is set

~0011169 abma (administrator) 2013-08-04 20:43	https://github.com/spring/spring/blob/develop/rts/Sim/Projectiles/ExplosionGenerator.h#L204

~0011170 jK (developer) 2013-08-04 20:50	I mean where is it written to `psi->flags`

Notes

Date Modified	Username	Field	Change
Issue History
2013-08-03 16:37	abma	New Issue
2013-08-03 16:37	abma	File Added: [syncdebug]{develop}94.1.1-815-g296bcb32013-08-03_16-05-57-dbg.7z
2013-08-03 16:37	abma	Note Added: 0011151
2013-08-03 16:43	abma	Relationship added	related to 0002731
2013-08-03 16:47	abma	Summary	desync with syncdebug build => desync with syncdebug build (seems to be CEG related)
2013-08-03 17:26	abma	Note Added: 0011152
2013-08-03 17:31	abma	Note Added: 0011153
2013-08-03 17:50	abma	Note Added: 0011154
2013-08-03 19:28	abma	Note Added: 0011156
2013-08-03 20:07	abma	Note Added: 0011157
2013-08-03 20:07	abma	Severity	major => crash
2013-08-04 16:55	cleanrock	Note Added: 0011165
2013-08-04 16:58	abma	Note Added: 0011166
2013-08-04 20:13	abma	Note Added: 0011167
2013-08-04 20:39	jK	Note Added: 0011168
2013-08-04 20:43	abma	Note Added: 0011169
2013-08-04 20:50	jK	Note Added: 0011170
2013-08-04 21:55	jK	Changeset attached	=> spring develop 8c21f92b
2013-08-04 21:55	jK	Assigned To	=> jK
2013-08-04 21:55	jK	Status	new => resolved
2013-08-04 21:55	jK	Resolution	open => fixed

Issue History