| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0003670 | Spring engine | General | public | 2013-04-02 04:15 | 2013-04-02 20:00 | ||||
| Reporter | abma | ||||||||
| Assigned To | jK | ||||||||
| Priority | urgent | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 94.1.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0003670: spring detects portable mode while it should detect normal mode | ||||||||
| Description | validation test still fails because it uses ./springsettings.cfg as config file & detects portable mode then. (but ./springsettings.cfg doesn't exist before startup) | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
abma (administrator) 2013-04-02 04:37 |
https://github.com/spring/spring/blob/develop/rts/System/FileSystem/DataDirLocater.cpp#L502 return is wrong i guess: if (!IsInstallDirDataDir()) return true; should return false! |
|
SirMaverick (reporter) 2013-04-02 04:39 |
Return true and remove the "!". That's more readable. :) |
|
abma (administrator) 2013-04-02 04:39 |
from http://springrts.com/phpbb/viewtopic.php?f=12&t=30044 : "If you want an all-in-one-folder setup (= portable mode), then you need to place a springsettings.cfg next to spring.exe & unitsync.dll." it is not checked if springsettings.cfg is next to spring.exe & unitsync.dll. existence of springsettings.cfg is ignored. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-04-02 04:15 | abma | New Issue | |
| 2013-04-02 04:15 | abma | Status | new => assigned |
| 2013-04-02 04:15 | abma | Assigned To | => jK |
| 2013-04-02 04:37 | abma | Note Added: 0010359 | |
| 2013-04-02 04:39 | SirMaverick | Note Added: 0010360 | |
| 2013-04-02 04:39 | abma | Note Added: 0010361 | |
| 2013-04-02 20:00 | jK | Status | assigned => resolved |
| 2013-04-02 20:00 | jK | Resolution | open => fixed |
| Issue History |