View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0000362 | Spring engine | AI | public | 2007-01-04 14:46 | 2010-11-23 01:42 | ||||
Reporter | Kloot | ||||||||
Assigned To | tvo | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | |||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0000362: patch for rts/ExternalAI/GlobalAI.cpp | ||||||||
Description | As described in http://taspring.clan-sy.com/phpbb/viewtopic.php?t=8746, AI destructors aren't always called because the value of IsCInterface isn't explicitly set to false in CGlobalAI::CGlobalAI() if _IsCInterface == 0. This patch corrects this, and also adds a check for the return value of an AI's exported IsCInterface function so that it's only considered to present a C interface if the function exists *and* returns 1. | ||||||||
Tags | No tags attached. | ||||||||
Checked infolog.txt for Errors | |||||||||
Attached Files |
|
![]() |
|
tvo (reporter) 2007-01-04 20:33 |
committed. Next time, could you not add spaces around the "->" operator, and put the function opening brace on a separate line, ie. like this: void CGlobalAI::Update(void) { gh->Update(); ai->Update(); } Not this: void CGlobalAI::Update(void) { gh -> Update(); ai -> Update(); } Also it would be great if you could keep (major) whitespace cleanup separated from actual code changes, mixing them both makes it very hard to properly review a patch. Thanks |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2007-01-04 14:46 | Kloot | New Issue | |
2007-01-04 14:46 | Kloot | File Added: GlobalAI.patch | |
2007-01-04 20:33 | tvo | Status | new => resolved |
2007-01-04 20:33 | tvo | Resolution | open => fixed |
2007-01-04 20:33 | tvo | Assigned To | => tvo |
2007-01-04 20:33 | tvo | Note Added: 0000524 | |
2010-11-22 22:59 | abma | Project | AI => Spring engine |
2010-11-22 23:11 | abma | Project | Spring engine => AI |
2010-11-23 01:42 | abma | Project | AI => Spring engine |