2025-11-06 03:42 CET
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003354Spring engineGeneralpublic2012-12-04 15:062012-12-05 20:41
ReporterBeherith 
Assigned Tocleanrock 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version91.0.1+git 
Target Version92.0Fixed in Version 
Summary0003354: [91.0.1-566] Hovers cant move over water
DescriptionHovers cannot move over water. Passability map (F2) shows water as non passable.
Steps To ReproduceBA 7.72, DeltaSiege: spawn a hovercraft (corch) in water with /give, it cannot move.
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files
  • jpg file icon screen00215.jpg (322,696 bytes) 2012-12-04 15:06
  • diff file icon mantis3354-fix.diff (560 bytes) 2012-12-05 19:35 - 
    diff --git a/rts/Sim/MoveTypes/MoveMath/HoverMoveMath.cpp b/rts/Sim/MoveTypes/MoveMath/HoverMoveMath.cpp
index 09233d8..2cc79a3 100644
--- a/rts/Sim/MoveTypes/MoveMath/HoverMoveMath.cpp
+++ b/rts/Sim/MoveTypes/MoveMath/HoverMoveMath.cpp
@@ -10,7 +10,7 @@ float CMoveMath::HoverSpeedMod(const MoveDef& moveDef, float height, float slope
 {
 	// no speed-penalty if on water (unless noWaterMove)
 	if (height < 0.0f)
-		return (1.0f * noHoverWaterMove);
+		return (1.0f * !noHoverWaterMove);
 	// slope too steep?
 	if (slope > moveDef.maxSlope)
 		return 0.0f;
    diff file icon mantis3354-fix.diff (560 bytes) 2012-12-05 19:35 +

-Relationships
+Relationships

-Notes

~0009467

cleanrock (reporter)

2012-12-05 20:41

 thanks Kloot
fixed in https://github.com/spring/spring/commit/8f8384a144c7a459473dacc9388977da6d240f57
+Notes

-Issue History
Date Modified Username Field Change
2012-12-04 15:06 Beherith New Issue
2012-12-04 15:06 Beherith File Added: screen00215.jpg
2012-12-05 17:34 abma Product Version 91.0 => 91.0.1+git
2012-12-05 17:34 abma Target Version => 92.0
2012-12-05 19:35 Kloot File Added: mantis3354-fix.diff
2012-12-05 20:34 cleanrock Assigned To => cleanrock
2012-12-05 20:34 cleanrock Status new => assigned
2012-12-05 20:41 cleanrock Note Added: 0009467
2012-12-05 20:41 cleanrock Status assigned => resolved
2012-12-05 20:41 cleanrock Resolution open => fixed
+Issue History