| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0003315 | Spring engine | Lua | public | 2012-11-03 15:15 | 2012-11-05 17:18 | ||||
| Reporter | zerver | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | no change required | ||||||
| Product Version | 91.0.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0003315: In EVO 4.7, the gui_shootnow.lua widget does not work | ||||||||
| Description | It appears something related to key bindings is broken. You are supposed to press "D" and then the selected commander unit should fire, but it does not. Works in 91.0 but not with latest develop. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
zerver (reporter) 2012-11-05 16:18 |
Offending commit: https://github.com/spring/spring/commit/efa13de0e7b3ddfc647db00bda7a09b416daa51a Side note: Clean code is worth nothing if it doesn't work. Nobody cares how it works as long as it works :) |
|
Kloot (developer) 2012-11-05 17:18 |
That must be why you commit so much crap to Spring, right? As for the widget, it works just fine when transplanted to BA / XTA / ZK, so maybe you should think twice before assigning anything to me. The real reason it's "broken" in EVO is that engine code now properly checks a weapon's commandfire tag for INTERNAL orders (which this widget issues), and guess what the ecommander and eorb units are equipped with. Reign in your bullshit or go find another project. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-11-03 15:15 | zerver | New Issue | |
| 2012-11-05 16:16 | zerver | Assigned To | => Kloot |
| 2012-11-05 16:16 | zerver | Status | new => assigned |
| 2012-11-05 16:18 | zerver | Note Added: 0009318 | |
| 2012-11-05 17:18 | Kloot | Note Added: 0009319 | |
| 2012-11-05 17:18 | Kloot | Status | assigned => closed |
| 2012-11-05 17:18 | Kloot | Resolution | open => no change required |
| Issue History |