| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002702 | Spring engine | General | public | 2011-11-05 11:06 | 2011-11-05 19:59 | ||||
| Reporter | abma | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | crash | Reproducibility | sometimes | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.82.7+git | ||||||||
| Target Version | 83.0 | Fixed in Version | 0.82.7+git | ||||||
| Summary | 0002702: assert in GroundMoveType.cpp:633 | ||||||||
| Description | triggered with some: /cheat /give all /give all 1 | ||||||||
| Additional Information | http://pastebin.de/19913 bt full: http://pastebin.de/19914 an other crash: spring: /home/abma/dev/spring/master/rts/Sim/MoveTypes/GroundMoveType.cpp:633: virtual void CGroundMoveType::ImpulseAdded(const float3&): Assertion `speed.SqLength() < (MAX_UNIT_SPEED * MAX_UNIT_SPEED * 1e2)' failed. [f=0002366] Error: Aborted (SIGABRT) in spring 82.8.1-63-g422ba69 develop (Debug) [f=0002366] Error: Stacktrace: [f=0002366] Error: <0> /lib/x86_64-linux-gnu/libc.so.6(+0x33d80) [0x7fc420ee8d80] [f=0002366] Error: <1> /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x35) [0x7fc420ee8d05] [f=0002366] Error: <2> /lib/x86_64-linux-gnu/libc.so.6(abort+0x186) [0x7fc420eecab6] [f=0002366] Error: <3> /lib/x86_64-linux-gnu/libc.so.6(__assert_fail+0xf5) [0x7fc420ee17c5] [f=0002366] Error: <4> /home/abma/dev/spring/master/rts/Sim/MoveTypes/GroundMoveType.cpp:587 [f=0002366] Error: <5> /home/abma/dev/spring/master/rts/Sim/Units/Unit.cpp:1252 [f=0002366] Error: <6> /home/abma/dev/spring/master/rts/Sim/Units/Unit.cpp:1140 [f=0002366] Error: <7> /home/abma/dev/spring/master/rts/Sim/MoveTypes/GroundMoveType.cpp:839 [f=0002366] Error: <8> /home/abma/dev/spring/master/rts/Sim/MoveTypes/GroundMoveType.cpp:738 [f=0002366] Error: <9> /home/abma/dev/spring/master/rts/Sim/MoveTypes/GroundMoveType.cpp:202 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2011-11-05 12:46 |
note to self: some of the values in that trace are insane newDamage = 42577836 collideeImpactDmgMult = 2.1288919e+09 the expression for collideeImpactDmgMult is simply impactSpeed * ownerRelMass * owner->mass, and we know the values of two of those: impactSpeed = 10.6444626 ownerRelMass = 0.999999762 therefore owner->mass must have been beyond all reasonable proportions (near 2e8, ie. 200 MILLION) ==> mod problem |
|
Kloot (developer) 2011-11-05 13:34 |
all units with 7-digit and higher masses in BA 7.60: ./armbanth.lua: mass = 999999995904, ./armclaw.lua: mass = 10000000000, ./armnanotc.lua: mass = 999999995904, ./gorg.lua: mass = 2000000, ./cormaw.lua: mass = 10000000000, ./cornanotc.lua: mass = 999999995904, ./corsktl.lua: mass = 300000000, ./intruder.lua: mass = 200000000, ./krogtaar.lua: mass = 999999995904, |
|
abma (administrator) 2011-11-05 14:20 Last edited: 2011-11-05 14:22 |
so... trim to a max limit + print a warning about that? or can it fixed a different way? i guess the assertion is triggered because of a collision? maybe just make the collision non-elastic? (+ do some damage...) |
|
Kloot (developer) 2011-11-05 15:15 |
I already added clamping (luaconf.h), it should have prevented this assertion actually. Did you disable nan-signaling in your build? |
|
abma (administrator) 2011-11-05 16:50 |
nan-signaling was disabled, i retry with your updates + signal-nans enabled |
|
abma (administrator) 2011-11-05 16:55 |
i didn't get a crash or SIGNAN with 82.8.1-64-g0115fa9.... so... fixed? |
|
Kloot (developer) 2011-11-05 18:03 Last edited: 2011-11-05 18:04 |
I would say so, assuming the demo from your first test-game doesn't crash either. :) |
|
abma (administrator) 2011-11-05 18:11 |
sorry... forgot to check demos... attached crashing demo. :-/ |
|
Kloot (developer) 2011-11-05 19:58 |
Hmm, thanks, I forgot the clamps I added don't work anymore because lib/lua/CMakeLists removes the signaling flag. Unit and feature mass values are now explicitly restricted, as are collision impulses, so at least this issue should not happen again. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-11-05 11:06 | abma | New Issue | |
| 2011-11-05 11:07 | abma | Product Version | => 0.82.7+git |
| 2011-11-05 11:07 | abma | Target Version | => 0.83.0 |
| 2011-11-05 11:07 | abma | Additional Information Updated | |
| 2011-11-05 12:46 | Kloot | Note Added: 0007484 | |
| 2011-11-05 13:34 | Kloot | Note Added: 0007486 | |
| 2011-11-05 14:20 | abma | Note Added: 0007487 | |
| 2011-11-05 14:22 | abma | Note Edited: 0007487 | |
| 2011-11-05 15:15 | Kloot | Note Added: 0007488 | |
| 2011-11-05 16:50 | abma | Note Added: 0007489 | |
| 2011-11-05 16:55 | abma | Note Added: 0007490 | |
| 2011-11-05 18:03 | Kloot | Note Added: 0007491 | |
| 2011-11-05 18:04 | Kloot | Note Edited: 0007491 | |
| 2011-11-05 18:10 | abma | File Added: 20111105_105003_CloseCombat_82.8.1-62-ged7779c develop.sdf | |
| 2011-11-05 18:11 | abma | Note Added: 0007492 | |
| 2011-11-05 19:58 | Kloot | Note Added: 0007493 | |
| 2011-11-05 19:59 | Kloot | Status | new => resolved |
| 2011-11-05 19:59 | Kloot | Fixed in Version | => 0.82.7+git |
| 2011-11-05 19:59 | Kloot | Resolution | open => fixed |
| 2011-11-05 19:59 | Kloot | Assigned To | => Kloot |
| Issue History |