| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002694 | Spring engine | General | public | 2011-10-24 02:29 | 2011-12-03 22:40 | ||||
| Reporter | spliff | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | major | Reproducibility | sometimes | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.82.7+git | ||||||||
| Target Version | 85.0 | Fixed in Version | |||||||
| Summary | 0002694: Unitsync requires UnInit to be called to detect new maps | ||||||||
| Description | this behavior changed since 0.82.7.1, here only a call to Init() was required. I've noticed on two systems that SL will behave incorrectly if the file ArchiveCacheV*.lua exists in the cache directory. It seems ArchiveCache naming is now simply "ArchiveCache.lua" however if an older cache file exists it seems to take priority (or otherwise interfere) and map/mod lists are not updated. I believe this is the root cause of some other bugs reported here regarding maps/mods not showing up on refresh. This situation would be common for users who installed earlier versions of Spring/SL and upgraded. The solution is probably as simple as automatically deleting any older ArchiveCacheV*.lua file since I've found if I manually delete the contents of the cache directory the problem goes away after a SL restart. Issue discovered on Gentoo Linux but probably affects other OS. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
 Notes |
|
|
spliff (reporter) 2011-10-24 02:32 |
I initially reported this as SL bug but I'm told this side of things is related to unitsync |
|
jK (developer) 2011-10-25 00:12 |
you set "0.82.7+git", then it gives me the impression that you are using different/conflicting engine version & unitsync version in your springlobby setup. |
|
abma (administrator) 2011-11-04 12:35 |
@spliff: in other words: did you double-check if spring + engine version selected in springlobby are the same? |
|
spliff (reporter) 2011-11-07 04:04 |
Sorry. It was too long ago and I've deleted the old ArchiveCaches now so I can't re-test. While I can't rule out conflicting versions I'd be surprised if I made the same error twice on different machines. Nonetheless I've used both machines for both playing and developing so I can't be certain either. Feel free to close this bug if you want - It's probably enough that the bug report exists and players can find it in a search if they need the workaround. |
|
spliff (reporter) 2011-11-15 12:19 |
I've just noticed ArchiveCache issues again using 83.0 release branch. After changing some modinfo and using "reload maps and games" in springlobby the game details were not updated. Restarting SL didn't help either. Only deleting ArchiveCache.lua fixed it. I have been switching between develop and release branches so versions have changed. Not sure if that matters. There are no older versions of ArchiveCache though. |
|
abma (administrator) 2011-11-15 12:20 Last edited: 2011-11-15 12:23 |
"in springlobby the game details" what do you exactly mean with that? what isn't getting updated? how to reproduce? |
|
2011-11-15 14:28 |
I have noticed the same bug: http://h3.abload.de/img/modversionxeed2.png When editing modinfo.lua, Spring.exe and Springlobby will still show the old info (such as changed version) The infobox (key: i) ingame also shows the wrong mod version. After deleting ArchiveCache.lua the correct mod version is shown. Another way to force it to update is changing the filename, eg Brickcraft.sdd -> Brickcraft_blub.sdd |
|
abma (administrator) 2011-11-15 16:14 Last edited: 2011-11-15 16:15 |
@knorke: The last selected game is stored in .springrc, if the game is changed, this isn't shown without clicking select... but thanks now i've enough info to check, if i can reprodce it. |
|
spliff (reporter) 2011-11-16 01:21 |
Sorry abma, by 'game details' I meant game title shown in 'select game' dropdown. Reproducible by changing the game version in modinfo.lua in .sdd mod. I also got the distinct impression that other side-effects like depends table in modinfo of another mod not recognising changed game name/version. |
|
abma (administrator) 2011-11-16 16:13 Last edited: 2011-11-16 16:14 |
@spliff: sorry i couldn't reproduce it. at which platform are you? what git tag/version? infolog.txt would answer most questions... if i edit a modinfo.lua the changes are shown after restart of spring in the games list... |
|
abma (administrator) 2011-11-30 15:20 |
looks more like a bug in springlobby, it doesn't call UnInit()... |
|
abma (administrator) 2011-11-30 15:24 |
so... fix that in Unitsync or in Springlobby? |
|
tvo (reporter) 2011-11-30 17:12 |
Didn't Init use to call UnInit automatically in the past? (or do the relevant cleanup to be able to re-initialize unitsync by itself) |
|
abma (administrator) 2011-12-01 04:30 |
https://github.com/spring/spring/commit/c001eecd046ba5168e32250000c58fd5576979ea i dislike the solution a bit, but as "temporary" solution imo its fine. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-10-24 02:29 | spliff | New Issue | |
| 2011-10-24 02:32 | spliff | Note Added: 0007467 | |
| 2011-10-25 00:12 | jK | Note Added: 0007468 | |
| 2011-11-04 12:35 | abma | Note Added: 0007480 | |
| 2011-11-04 12:35 | abma | Status | new => feedback |
| 2011-11-07 04:04 | spliff | Note Added: 0007524 | |
| 2011-11-15 12:19 | spliff | Note Added: 0007607 | |
| 2011-11-15 12:20 | abma | Note Added: 0007608 | |
| 2011-11-15 12:23 | abma | Note Edited: 0007608 | |
| 2011-11-15 14:28 |
|
Note Added: 0007610 | |
| 2011-11-15 16:14 | abma | Note Added: 0007612 | |
| 2011-11-15 16:15 | abma | Note Edited: 0007612 | |
| 2011-11-15 16:15 | abma | Note Edited: 0007612 | |
| 2011-11-16 01:21 | spliff | Note Added: 0007614 | |
| 2011-11-16 16:13 | abma | Note Added: 0007616 | |
| 2011-11-16 16:14 | abma | Note Edited: 0007616 | |
| 2011-11-16 16:14 | abma | Note Edited: 0007616 | |
| 2011-11-30 01:57 | abma | Relationship added | related to 0002786 |
| 2011-11-30 15:20 | abma | Note Added: 0007778 | |
| 2011-11-30 15:24 | abma | Summary | Existing ArchiveCacheVx.lua breaks map/mod refresh => Unitsync requires UnInit to be called to detect new maps |
| 2011-11-30 15:24 | abma | Description Updated | |
| 2011-11-30 15:24 | abma | Note Added: 0007779 | |
| 2011-11-30 17:12 | tvo | Note Added: 0007780 | |
| 2011-12-01 04:30 | abma | Note Added: 0007786 | |
| 2011-12-01 04:30 | abma | Status | feedback => resolved |
| 2011-12-01 04:30 | abma | Resolution | open => fixed |
| 2011-12-01 04:30 | abma | Assigned To | => abma |
| 2011-12-03 22:40 | hoijui | Target Version | => 85.0 |
| Issue History |