0002688: (develop) UnitFinished is called twice when setting build progress to 1 with Lua - MantisBT

2025-07-21 18:50 CEST

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0002688

Spring engine

Lua

public

2011-10-13 11:15

2011-11-01 13:12

Reporter

KingRaptor

Assigned To

Kloot

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Product Version

0.82.7+git

Target Version

Fixed in Version

83.0

Summary

0002688: (develop) UnitFinished is called twice when setting build progress to 1 with Lua

Description

If a unit is currently under construction (with a working con) and its progress is set to 1 with Spring.SetUnitHealth, UnitFinished is called twice.

Steps To Reproduce

Start a Zero-K game of v0.8.10.x or earlier (straight from spring.exe is fine), choose a commander, then have it build a factory.

Additional Information

Relevant function in start_unit_setup.lua:

function gadget:UnitCreated(unitID, unitDefID, teamID, builderID)
    if plop and ploppableDefs[unitDefID] and facplops[builderID] then
        facplops[builderID] = nil
        local maxHealth = select(2,Spring.GetUnitHealth(unitID))
        Spring.SetUnitHealth(unitID, {health = maxHealth*1, build = 1})
        local x,y,z = Spring.GetUnitPosition(unitID)
        Spring.SpawnCEG("gate", x, y, z)
        CheckForShutdown()
    end
end

Tags

No tags attached.

Checked infolog.txt for Errors

Attached Files

Relationships

Relationships

Notes
~0007476 KingRaptor (reporter) 2011-11-01 12:23	Problem persists in develop 82.8.1-30-g5dbb98b Tested with this gadget: http://pastebin.com/HJZ3RMtL in BA Remake v7.20

~0007477 KingRaptor (reporter) 2011-11-01 12:45	Never mind, it appears the versions on http://springrts.com/dl/buildbot/default/develop/ aren't up to date.

~0007478 tvo (reporter) 2011-11-01 13:12	Closing on request of KingRaptor, as the 82.8.1-30-g5dbb98b build is from 12 oct.

Notes

Date Modified	Username	Field	Change
Issue History
2011-10-13 11:15	KingRaptor	New Issue
2011-10-18 21:17	Kloot	Status	new => resolved
2011-10-18 21:17	Kloot	Fixed in Version	=> 0.83.0
2011-10-18 21:17	Kloot	Resolution	open => fixed
2011-10-18 21:17	Kloot	Assigned To	=> Kloot
2011-11-01 12:23	KingRaptor	Note Added: 0007476
2011-11-01 12:23	KingRaptor	Status	resolved => feedback
2011-11-01 12:23	KingRaptor	Resolution	fixed => reopened
2011-11-01 12:45	KingRaptor	Note Added: 0007477
2011-11-01 13:12	tvo	Note Added: 0007478
2011-11-01 13:12	tvo	Status	feedback => resolved
2011-11-01 13:12	tvo	Resolution	reopened => fixed

Issue History