| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002669 | Spring engine | General | public | 2011-09-25 00:48 | 2011-10-02 19:14 | ||||
| Reporter | abma | ||||||||
| Assigned To | hoijui | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | 83.0 | Fixed in Version | |||||||
| Summary | 0002669: cont\base\make_gamedata_arch.bat doesn't detect if git (.exe) exists/is installed | ||||||||
| Description | C:\spring>make gamedata Der Befehl "git" ist entweder falsch geschrieben oder konnte nicht gefunden werden. Caution: Not converting line endings of base files. In case you experience desyncs, use build files from the buildbot. git is used to detect if git's core.autocrlf=true and to convert line-endings of basefiles, if needed. | ||||||||
| Additional Information | cont\base\make_gamedata_arch.* should be replaced with a cmake script... imo the detection should be removed and the manuals to checkout git on win32 should require to use autocrlf=false | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
hoijui (reporter) 2011-09-25 11:42 Last edited: 2011-09-27 08:31 |
i would say, we fix this by checking if git is available in that bat file, and then you may open a new report (feature request i guess), which asks for converting these two scripts to a CMake one. I am not too sure if that is a good idea too, especially as long as we can not build with MSVC through CMake. |
|
hoijui (reporter) 2011-10-02 15:52 |
should be fixed by: https://github.com/spring/spring/commit/9354bf00c6011f04b49d8ca381ce9a47dc13783d |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-09-25 00:48 | abma | New Issue | |
| 2011-09-25 00:54 | abma | Summary | cmake uses git but doesn't detect if git (.exe) exists/is installed => cont\base\make_gamedata_arch.bat doesn't detect if git (.exe) exists/is installed |
| 2011-09-25 00:58 | abma | Additional Information Updated | |
| 2011-09-25 01:01 | abma | Description Updated | |
| 2011-09-25 01:01 | abma | Additional Information Updated | |
| 2011-09-25 11:42 | hoijui | Note Added: 0007407 | |
| 2011-09-27 08:30 | hoijui | Target Version | => 0.83.0 |
| 2011-09-27 08:31 | hoijui | Note Edited: 0007407 | |
| 2011-10-02 15:40 | hoijui | Status | new => assigned |
| 2011-10-02 15:40 | hoijui | Assigned To | => hoijui |
| 2011-10-02 15:52 | hoijui | Note Added: 0007450 | |
| 2011-10-02 19:14 | abma | Status | assigned => resolved |
| 2011-10-02 19:14 | abma | Resolution | open => fixed |
| Issue History |