| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002632 | Spring engine | General | public | 2011-09-01 18:04 | 2011-09-05 22:26 | ||||
| Reporter | FLOZi | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | N/A | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.82.7+git | ||||||||
| Target Version | Fixed in Version | 0.82.7+git | |||||||
| Summary | 0002632: resources_map.lua cannot read from groundfx subtable | ||||||||
| Description | https://github.com/spring/spring/blob/master/rts/Rendering/ProjectileDrawer.cpp#L177 Pretty sure this means that a map CEG cannot use the CSimpleGroundFlash class with a custom texture, as they are loaded from groundfx and not projectileTextures. | ||||||||
| Additional Information | Also querying if it is intentional that resources.lua has: resources.graphics.projectileTextures and resources_map.lua has just: resources.projectileTextures | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2011-09-01 18:50 Last edited: 2011-09-01 18:52 |
https://github.com/spring/spring/commit/2117049af2ada970a747fc6306afbdb9131e72d9 |
|
FLOZi (reporter) 2011-09-01 19:51 Last edited: 2011-09-01 22:31 |
edit: hurf-durf didn't look at commit time or coder Doesn't that break every game with a resources.lua? And isn't resources_map.lua still only looking in projectiletextures and not groundfx? |
|
Kloot (developer) 2011-09-01 21:32 |
Yeah, I don't know what trepan had in mind for resources_map (the comment "allow map specified atlas textures for gaia unit projectiles" seems to indicate that groundfx was supposed to be excluded from it, which is probably why he changed the code to skip the intermediary graphics table). |
|
FLOZi (reporter) 2011-09-01 21:47 |
Not loading from groundFX may have pre-dated the introduction of CSimpleGroundFlash as a class which allowed custom textures? |
|
Kloot (developer) 2011-09-01 22:15 |
thought that too, but nope: https://github.com/spring/spring/commit/d14463218560ed6f12e149b8bfd247ffdb811ee5 added SimpleGroundFlash, before resources_map came along with https://github.com/spring/spring/commit/4610875a08d5a8a9cce62dd0c4178e36def313e7 |
|
FLOZi (reporter) 2011-09-01 22:35 |
Oversight perhaps then? I don't see why a map can't include a CEG which uses CSimpleGroundFlash (graphics table I am not bothered about so long as it works) |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-09-01 18:04 | FLOZi | New Issue | |
| 2011-09-01 18:50 | Kloot | Note Added: 0007314 | |
| 2011-09-01 18:50 | Kloot | Note Edited: 0007314 | |
| 2011-09-01 18:52 | Kloot | Note Edited: 0007314 | |
| 2011-09-01 19:51 | FLOZi | Note Added: 0007315 | |
| 2011-09-01 19:52 | FLOZi | Note Edited: 0007315 | |
| 2011-09-01 19:54 | FLOZi | Note Edited: 0007315 | |
| 2011-09-01 21:32 | Kloot | Note Added: 0007316 | |
| 2011-09-01 21:47 | FLOZi | Note Added: 0007317 | |
| 2011-09-01 22:15 | Kloot | Note Added: 0007318 | |
| 2011-09-01 22:31 | FLOZi | Note Edited: 0007315 | |
| 2011-09-01 22:35 | FLOZi | Note Added: 0007319 | |
| 2011-09-05 22:26 | Kloot | Status | new => resolved |
| 2011-09-05 22:26 | Kloot | Fixed in Version | => 0.82.7+git |
| 2011-09-05 22:26 | Kloot | Resolution | open => fixed |
| 2011-09-05 22:26 | Kloot | Assigned To | => Kloot |
| Issue History |