2025-07-21 23:44 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002469Spring engineGeneralpublic2011-06-14 23:18
Reporterabma 
Assigned Tozerver 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
Product Version0.82.7+git 
Target Version83.0Fixed in Version0.82.7+git 
Summary0002469: (master) MT-crash in DebugColVolDrawer.cpp:133
Description    C:\Program Files\Spring-git\spring-multithreaded.exe 0x00C55A51 rts/Rendering/DebugColVolDrawer.cpp:133
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x0067C946 rts/Map/SMF/SmfReadMap.cpp:595
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x00687D3A rts/lib/gml/gmlcls.h:132
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x00431239 rts/Game/Game.cpp:952
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x0043B734 rts/lib/gml/gmlcls.h:132
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x009AF9AD rts/System/SpringApp.cpp:1070
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x009B5B55 rts/System/SpringApp.cpp:1158
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x0099DC29 rts/System/Main.cpp:55
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x0099E294 rts/System/Main.cpp:69
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x0099E3B1 rts/System/Main.cpp:97
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x00A38CC9 WordCompletion.cpp:0
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x004010B4 /root/mingw/mingw32-runtime-3.15.2/build_dir/src/mingwrt-3.15.2-mingw32/crt1.c:237
    C:\Program Files\Spring-git\spring-multithreaded.exe 0x00401128 /root/mingw/mingw32-runtime-3.15.2/build_dir/src/mingwrt-3.15.2-mingw32/crt1.c:271
    C:\Windows\system32\kernel32.dll 0x761D3C45 ??:0
    C:\Windows\SYSTEM32\ntdll.dll 0x779237F5 ??:0
    C:\Windows\SYSTEM32\ntdll.dll 0x779237C8 ??:0
Additional Informationinfolog.txt: http://pastebin.com/VRNZhBV3
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
+Relationships

-Notes

~0006745

zerver (reporter)

https://github.com/spring/spring/commit/00072eb5bebf9e3e186bb25086d2fabad108c4c9

Debug drawing was previously disabled for MT. Someone enabled it without proper mutexing.

Debug drawing is bad for MT anyways, since the Alt+B display is used also for mutex profiling, and the debug drawing has a huge performance impact thus affecting the results. IMO debug drawing should be disabled by default in Alt+B mode, and possible to enable with a flag in the config file. After this is done, I'll see if we can make it thread-safe.
+Notes

-Issue History
Date Modified Username Field Change
2011-06-12 17:46 abma New Issue
2011-06-12 17:46 abma Graphics Card => unknown
2011-06-12 17:48 abma Target Version => 0.83.0
2011-06-14 11:31 zerver Status new => assigned
2011-06-14 11:31 zerver Assigned To => zerver
2011-06-14 23:18 zerver Note Added: 0006745
2011-06-14 23:18 zerver Status assigned => resolved
2011-06-14 23:18 zerver Fixed in Version => 0.82.7+git
2011-06-14 23:18 zerver Resolution open => fixed
+Issue History