2025-07-18 08:34 CEST
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000223Spring engineGeneralpublic2006-07-01 04:342006-07-03 13:00
Reportersmoth 
Assigned Tojcnossen 
PrioritynormalSeveritytweakReproducibilityalways
StatusresolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0000223: [patch] Isairbase fix
Descriptionsimple patch which fixes the airtransport issue. Isairbase was meant to designate airrepair pads. However it is used in ota to do a hackish fire from transport. The tag is still there for what it was SUPPOSED to be and I created a tag named "ISFIREPLATFORM."

In spring units auto return to an airbase or airrepair pad when they reach a certain level of damage. VERY anoying for those of use who have transports we want troops to fire from. This is anoying because we get transports loading each other or aircraft jumping on transports expecting repairs. So I fixed the issue while purposely "breaking"(read correcting) the OTA units... that no one uses FYI.
Additional InformationFBI Tag added: IsFirePlatform
Purpose: Determines whether or not units may fire from a transport.
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files
  • patch file icon isfireplatform.patch (2,124 bytes) 2006-07-01 04:34 - 
    Index: rts/Sim/Units/UnitDef.h
===================================================================
--- rts/Sim/Units/UnitDef.h	(revision 1538)
+++ rts/Sim/Units/UnitDef.h	(working copy)
@@ -172,7 +172,9 @@
 	float loadingRadius;	//for transports
 	int transportCapacity;
 	int transportSize;
-	bool isAirBase;// should the carried units still be able to shoot?
+	//$$
+	bool isfireplatform;// should the carried units still be able to shoot?
+	bool isAirBase;
 	float transportMass;
 
 	bool canCloak;							//if the unit can cloak
Index: rts/Sim/Units/UnitDefHandler.cpp
===================================================================
--- rts/Sim/Units/UnitDefHandler.cpp	(revision 1538)
+++ rts/Sim/Units/UnitDefHandler.cpp	(working copy)
@@ -291,6 +291,7 @@
 
 	tdfparser.GetDef(ud.transportSize, "0", "UNITINFO\\transportsize");
 	tdfparser.GetDef(ud.transportCapacity, "0", "UNITINFO\\transportcapacity");
+	ud.isfireplatform=!!atoi(tdfparser.SGetValueDef("0", "UNITINFO\\isfireplatform").c_str()); //$$
 	ud.isAirBase=!!atoi(tdfparser.SGetValueDef("0", "UNITINFO\\isAirBase").c_str());
 	ud.loadingRadius=220;
 	tdfparser.GetDef(ud.transportMass, "100000", "UNITINFO\\TransportMass");
Index: rts/Sim/Units/UnitTypes/TransportUnit.cpp
===================================================================
--- rts/Sim/Units/UnitTypes/TransportUnit.cpp	(revision 1538)
+++ rts/Sim/Units/UnitTypes/TransportUnit.cpp	(working copy)
@@ -94,7 +94,7 @@
 	unit->AddDeathDependence (this);
     unit->transporter = this;
 	unit->toBeTransported=false;
-	if (!unitDef->isAirBase)
+	if (!unitDef->isfireplatform)//$$
 		unit->stunned=true;	//make sure unit doesnt fire etc in transport
 	unit->UnBlock();
 	loshandler->FreeInstance(unit->los);
@@ -126,7 +126,7 @@
 			unit->transporter=0;
 			if(CTAAirMoveType* am=dynamic_cast<CTAAirMoveType*>(moveType))
 				unit->moveType->useHeading=true;
-			unit->stunned=false; // de-stun in case it isairbase=0
+			unit->stunned=false; // de-stun in case it isfireplatform=0
 			unit->Block();
 			loshandler->MoveUnit(unit,false);
 			unit->moveType->LeaveTransport();
    patch file icon isfireplatform.patch (2,124 bytes) 2006-07-01 04:34 +

-Relationships
+Relationships

-Notes

~0000274

jcnossen (reporter)

2006-07-03 13:00

 patch applied, thanks
+Notes

-Issue History
Date Modified Username Field Change
2006-07-01 04:34 smoth New Issue
2006-07-01 04:34 smoth File Added: isfireplatform.patch
2006-07-03 13:00 jcnossen Status new => resolved
2006-07-03 13:00 jcnossen Resolution open => fixed
2006-07-03 13:00 jcnossen Assigned To => jcnossen
2006-07-03 13:00 jcnossen Note Added: 0000274
+Issue History