| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002059 | Spring engine | General | public | 2010-08-26 19:03 | 2010-10-06 22:50 | ||||
| Reporter | satirik | ||||||||
| Assigned To | jK | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0002059: Unitsync Errors : Map min height always 0 | ||||||||
| Description | When I load BA : GetModValidMapCount: luaParser.Execute() failed: could not open file: ValidMaps.lua Everytime I load a map : GetMapOptionCount: luaParser.Execute() failed: error = 2, maphelper/mapinfo.lua, [string "maphelper/mapinfo.lua"]:30: missing configFile argument Everytime i try to get a Map min and max height : GetMapMaxHeight: Couldn't open map file SmallDivide | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
jK (developer) 2010-08-30 19:15 |
| GetMapMaxHeight: Couldn't open map file SmallDivide erm what is your input to GetMapMaxHeight()? quote of the source code: * @brief return the map's maximum height * @param name name of the map, e.g. "SmallDivide.smf" note the ".smf"! (and trusting git blame, it was always like this) Also what are your inputs for the other 2 functions? |
|
satirik (reporter) 2010-08-30 20:30 |
so what if it's a sm3 map ? i only have SmallDivide now i dunno if it's smf or something else ... you (the spring devs) removed it from the map names ... |
|
jK (developer) 2010-08-30 20:35 |
I did nothing, I never touched this code EVER. I just try to help and need to know your input and where you get that from. |
|
satirik (reporter) 2010-08-30 21:11 |
the input = the map name coming from unitsync GetMapName |
|
FLOZi (reporter) 2010-08-30 22:22 |
He wasn't saying you did JK. But someone did make an (UNDOCUMENTED!) change to the behaviour of lua Game.mapName and the unitsync equivalent, for what reason I can't much imagine. |
|
hoijui (reporter) 2010-08-30 22:40 Last edited: 2010-08-30 22:42 |
use this: EXPORT(const char* ) GetMapArchiveName(int index); and hand this over to the functions that need the archive name (while the param is wrongly called map-name). while in the past, a maps primary identifier was the archive name, it is now the map name (archive format independent), though a few functions still seem to use the archive name as identifier. does it make sense what i say? :D edit: looking at unitsync code, it seems that sm3 support is missing in many places anyway (just assumes all maps to be smf). |
|
satirik (reporter) 2010-08-30 22:53 |
isn't GetMapArchiveName supposed to get the archive name ? (ie archive.sdz or archive.sd7) |
|
jK (developer) 2010-08-31 01:05 |
hoijui, it's a real bug and not an API change or something like. Auswaschbar touched code w/o thinking about its range ... It begins with 28c3b5 and there are so many following commits affected that it seems impossible to me to fix this for 0.82.4 ... |
|
jK (developer) 2010-10-06 22:50 |
All functions in the unitsync now consequently use the string returned by GetMapName(). So it differs from the <0.82 ones which included the extension. But it's consistent now. Note: There are still many argument namings wrong all over the engine source code. The arguments are named `mapname` but need the full mapfilepath ("maps/SmallDivide.smf"). |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-08-26 19:03 | satirik | New Issue | |
| 2010-08-26 19:03 | satirik | Status | new => assigned |
| 2010-08-26 19:03 | satirik | Assigned To | => satirik |
| 2010-08-26 19:07 | satirik | Project | @4@ => Spring engine |
| 2010-08-26 19:07 | satirik | Assigned To | satirik => |
| 2010-08-26 19:08 | satirik | Status | assigned => new |
| 2010-08-30 19:15 | jK | Note Added: 0005396 | |
| 2010-08-30 20:30 | satirik | Note Added: 0005397 | |
| 2010-08-30 20:35 | jK | Note Added: 0005398 | |
| 2010-08-30 21:11 | satirik | Note Added: 0005399 | |
| 2010-08-30 22:22 | FLOZi | Note Added: 0005400 | |
| 2010-08-30 22:40 | hoijui | Note Added: 0005403 | |
| 2010-08-30 22:41 | hoijui | Note Edited: 0005403 | |
| 2010-08-30 22:42 | hoijui | Note Edited: 0005403 | |
| 2010-08-30 22:53 | satirik | Note Added: 0005404 | |
| 2010-08-31 01:05 | jK | Note Added: 0005405 | |
| 2010-10-06 22:50 | jK | Note Added: 0005701 | |
| 2010-10-06 22:50 | jK | Status | new => resolved |
| 2010-10-06 22:50 | jK | Resolution | open => fixed |
| 2010-10-06 22:50 | jK | Assigned To | => jK |
| Issue History |