| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002046 | Spring engine | General | public | 2010-08-19 11:48 | 2010-08-30 22:25 | ||||
| Reporter | Rafal99 | ||||||||
| Assigned To | zerver | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.82.3 | ||||||||
| Target Version | Fixed in Version | 0.82.3+git | |||||||
| Summary | 0002046: Replays desync from original game because synced lua sees player who watches replay | ||||||||
| Description | It seems that synced Lua sees player who watches replay, so callings returning player list return different list than in original game, and any synced lua code relying on it will behave differently in the replay. Probably unintended. | ||||||||
| Additional Information | I have not tested this properly yet but this is my conclusion from trying to watch CA replays which are currently broken. CA currently has a bug which spawns additional commanders for each of the spectators. I played a game with no spectators no additional coms were spawned, then watched replay and one additional com was spawned, which means spectator watching replay (me) was visible to the lua. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
 Notes |
|
|
zerver (reporter) 2010-08-19 18:07 |
I have not noticed any extra coms spawned in BA, and as long as these extra users are spectators, there should not be a problem WRT sync I think. You are correct though that if you use the player count (including specs) in synced code, the demo will desync for sure. So right now I'm thinking this is a CA bug only and the desync you see is because of that bug (the extra coms). |
|
zerver (reporter) 2010-08-30 22:25 |
http://github.com/spring/spring/commit/6d446dfd5179040ddce3a466573dcf6474a1659d |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-08-19 11:48 | Rafal99 | New Issue | |
| 2010-08-19 18:07 | zerver | Note Added: 0005318 | |
| 2010-08-23 22:55 | zerver | Relationship added | related to 0002041 |
| 2010-08-30 22:25 | zerver | Note Added: 0005402 | |
| 2010-08-30 22:25 | zerver | Status | new => resolved |
| 2010-08-30 22:25 | zerver | Fixed in Version | => 0.82.3+git |
| 2010-08-30 22:25 | zerver | Resolution | open => fixed |
| 2010-08-30 22:25 | zerver | Assigned To | => zerver |
| Issue History |