| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002028 | Spring engine | Linux | public | 2010-08-14 13:34 | 2010-08-17 19:46 | ||||
| Reporter | Jonas Wielicki | ||||||||
| Assigned To | abma | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.82.3 | ||||||||
| Target Version | 0.82.4 | Fixed in Version | 0.82.3+git | ||||||
| Summary | 0002028: Various fullscreen issues in 0.82.3 | ||||||||
| Description | In 0.82.3 I experienced two issues related to fullscreen: a) In normal mode, I had some kind of margin at the top. I could not move the cursor to that area and it was filled with the background color of the map. Widgets were also not placeable in that region. b) In dual screen mode, everything was shown on the left screen. Thus, the left screen was split into two, while the right one was filled with the maps background color. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
 Notes |
|
|
Jonas Wielicki (reporter) 2010-08-14 13:41 |
I'd assign that to me, as I am working on it already, but I cannot. I already have some kind of fix, but I need to fiddle with git to push it to my fork >.> |
|
Jonas Wielicki (reporter) 2010-08-14 13:52 Last edited: 2010-08-14 13:52 |
fix attempt: http://github.com/horazont/spring/commit/42cfd097b80e0d5e5f0191794c907bd288a9836b |
|
hoijui (reporter) 2010-08-14 15:57 |
looks fine to me! :-) (and thanks for doing it with git, even doh you had to fidle! :-) ). i would like jk or Kloot to have a look t it too, as .. if there could be a problem, they would most likely see it. |
|
jK (developer) 2010-08-14 21:36 Last edited: 2010-08-14 22:28 |
sorry deactivating random stuff is no solution, the problem is much deeper and much harder to solve. Edit: and still thx for your attempt, don't stop trying to code for spring just because a few patches didn't got in :-) |
|
jK (developer) 2010-08-14 22:15 |
http://github.com/spring/spring/commit/65db340fb92c009ad31499f5a4e97891e5a5b5db This solved it for me. Still I don't know why it happened now and why there weren't reports before :/ |
|
abma (administrator) 2010-08-15 10:09 |
IMHO because of this where no reports: http://github.com/spring/spring/blob/master/rts/System/SpringApp.cpp#L848 this forces windowed mode for spring in a debug build (but can be overridden by the --fullscreen param) |
|
Jonas Wielicki (reporter) 2010-08-15 13:07 Last edited: 2010-08-15 13:08 |
I may be blind, but doesn't your patch do effectively the same? Except that globalRendering->winPos[XY] are not set and the NOBORDERS-thing. |
|
abma (administrator) 2010-08-17 17:25 |
with current stable i see the bars in fullscreen, with current master i have a real fullscreen :-) jonas, does it work for you too? if so then this is fixed... |
|
Jonas Wielicki (reporter) 2010-08-17 18:34 |
I reverted my commit locally and pulled spring master in, rebuilt and it works. |
|
abma (administrator) 2010-08-17 19:46 |
jonas: don't be disappointed! seems to be solved -> closing :) |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-08-14 13:34 | Jonas Wielicki | New Issue | |
| 2010-08-14 13:41 | Jonas Wielicki | Note Added: 0005253 | |
| 2010-08-14 13:47 | tvo | Product Version | 0.82.0+git => 0.82.3 |
| 2010-08-14 13:52 | Jonas Wielicki | Note Added: 0005255 | |
| 2010-08-14 13:52 | Jonas Wielicki | Note Edited: 0005255 | |
| 2010-08-14 13:54 | tvo | Target Version | => 0.83/0.84 |
| 2010-08-14 15:57 | hoijui | Note Added: 0005260 | |
| 2010-08-14 21:36 | jK | Note Added: 0005277 | |
| 2010-08-14 22:03 | jK | Note Edited: 0005277 | |
| 2010-08-14 22:15 | jK | Note Added: 0005279 | |
| 2010-08-14 22:23 | jK | Status | new => feedback |
| 2010-08-14 22:28 | jK | Note Edited: 0005277 | |
| 2010-08-15 10:09 | abma | Note Added: 0005281 | |
| 2010-08-15 13:07 | Jonas Wielicki | Note Added: 0005282 | |
| 2010-08-15 13:08 | Jonas Wielicki | Note Edited: 0005282 | |
| 2010-08-17 17:25 | abma | Note Added: 0005308 | |
| 2010-08-17 18:34 | Jonas Wielicki | Note Added: 0005310 | |
| 2010-08-17 19:46 | abma | Note Added: 0005313 | |
| 2010-08-17 19:46 | abma | Status | feedback => resolved |
| 2010-08-17 19:46 | abma | Fixed in Version | => 0.82.3+git |
| 2010-08-17 19:46 | abma | Resolution | open => fixed |
| 2010-08-17 19:46 | abma | Assigned To | => abma |
| 2010-08-23 07:38 | jK | Relationship added | has duplicate 0002050 |
| Issue History |