View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0001998 | Spring engine | General | public | 2010-07-24 16:08 | 2010-07-25 05:31 | ||||
Reporter | hoijui | ||||||||
Assigned To | jK | ||||||||
Priority | high | Severity | major | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | |||||||||
Target Version | 0.82.0 | Fixed in Version | 0.81.2+git | ||||||
Summary | 0001998: No more commanders | ||||||||
Description | in current master build, with BA 7.13 beta, the commanders do not spawn anymore, again. Happens with both my own linux build, and the buildbot windows build. i guess they still do in the testbuild, so must have been a recent change. | ||||||||
Tags | No tags attached. | ||||||||
Checked infolog.txt for Errors | |||||||||
Attached Files |
|
![]() |
|
Kloot (developer) 2010-07-24 17:27 |
It's because BA 7.13's LuaRules/main.lua still tries to call AllowUnsafeChanges which no longer exists. |
hoijui (reporter) 2010-07-24 17:39 |
and the best solution is to tell TFC to remove that? |
SirMaverick (reporter) 2010-07-24 17:44 Last edited: 2010-07-24 17:44 |
AllowUnsafeChanges was removed, but is still checked. With CA I get (calling CreateUnit from GameStart): LuaRules::RunCallIn: error = 2, GameStart, [string "LuaRules/Gadgets/start_unit_setup.lua"]:355: Unsafe attempt to change game state stack traceback: [C]: in function 'CreateUnit' [string "LuaRules/Gadgets/start_unit_setup.lua"]:355: in function 'SpawnStartUnit' [string "LuaRules/Gadgets/start_unit_setup.lua"]:542: in function 'GameStart' [string "LuaRules/gadgets.lua"]:1063: in function <[string "LuaRules/gadgets.lua"]:1061> (tail call): ? |
hoijui (reporter) 2010-07-24 17:55 |
yeah.. i removed it from BA, and still no comms |
FLOZi (reporter) 2010-07-25 02:10 |
Same issue with S44; with AUC there's a 'attempt to call global 'AllowUnsafeChanges' (a nil value)' error, and without it, the 'Unsafe attempt to change game state' error. Definitely an oversight in the removal of AUC somewhere. |
jK (developer) 2010-07-25 05:30 |
yeah, AUC wasn't working at GameStart (:= before a synced-only callin was called) |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2010-07-24 16:08 | hoijui | New Issue | |
2010-07-24 17:27 | Kloot | Note Added: 0005148 | |
2010-07-24 17:39 | hoijui | Note Added: 0005149 | |
2010-07-24 17:44 | SirMaverick | Note Added: 0005150 | |
2010-07-24 17:44 | SirMaverick | Note Edited: 0005150 | |
2010-07-24 17:55 | hoijui | Note Added: 0005151 | |
2010-07-25 02:10 | FLOZi | Note Added: 0005155 | |
2010-07-25 05:30 | jK | Note Added: 0005156 | |
2010-07-25 05:30 | jK | Status | new => resolved |
2010-07-25 05:30 | jK | Fixed in Version | => 0.81.2+git |
2010-07-25 05:30 | jK | Resolution | open => fixed |
2010-07-25 05:30 | jK | Assigned To | => jK |