| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0001938 | Spring engine | General | public | 2010-06-06 16:52 | 2010-06-15 13:57 | ||||
| Reporter | SirMaverick | ||||||||
| Assigned To | tvo | ||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.81.2+git | ||||||||
| Target Version | Fixed in Version | 0.82.0 | |||||||
| Summary | 0001938: patch: do not flush output in sim thread | ||||||||
| Description | At the moment sim thread is flushing output to file and stdout. E.g. if you start spring from console and ctrl+s it will freeze. (This might also cause lag under heavy disk i/o.) With this patch a dedicated thread is flushing output so that sim thread will not be blocked. | ||||||||
| Additional Information | http://github.com/1231e7b84a5de93a/spring/commit/f2a0fdc866af27d6dba9f736f8e917e36b7e0c96 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2010-06-06 19:03 Last edited: 2010-06-06 19:14 |
Calling front() is undefined behavior when the queue is empty, please fix this. Also, send the thread a quit message rather than interrupting it. |
|
SirMaverick (reporter) 2010-06-06 21:20 |
updated http://github.com/1231e7b84a5de93a/spring/commits/noFlushInSimThread |
|
tvo (reporter) 2010-06-10 23:56 |
I would prefer it if we simply tried without the flush first, I think this just introduces needless complexity while having no real advantage over no flush at all. See also my comments to this commit: http://github.com/1231e7b84a5de93a/spring/commit/f2a0fdc866af27d6dba9f736f8e917e36b7e0c96 |
|
tvo (reporter) 2010-06-15 13:57 |
Removed flush in http://github.com/1231e7b84a5de93a/spring/commit/3f03d2c788a12f301ac35c9b69f4874a66e35fd7 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-06-06 16:52 | SirMaverick | New Issue | |
| 2010-06-06 19:03 | Kloot | Note Added: 0004948 | |
| 2010-06-06 19:05 | Kloot | Note Edited: 0004948 | |
| 2010-06-06 19:14 | Kloot | Note Edited: 0004948 | |
| 2010-06-06 21:20 | SirMaverick | Note Added: 0004951 | |
| 2010-06-10 23:56 | tvo | Note Added: 0004968 | |
| 2010-06-15 13:57 | tvo | Note Added: 0004980 | |
| 2010-06-15 13:57 | tvo | Status | new => resolved |
| 2010-06-15 13:57 | tvo | Fixed in Version | => 0.82 |
| 2010-06-15 13:57 | tvo | Resolution | open => fixed |
| 2010-06-15 13:57 | tvo | Assigned To | => tvo |
| Issue History |