| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0001673 | Spring engine | General | public | 2009-10-07 11:42 | 2009-10-12 18:06 | ||||
| Reporter | DOT | ||||||||
| Assigned To | hoijui | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.80.4.0 | ||||||||
| Target Version | Fixed in Version | 0.80.4.0+git | |||||||
| Summary | 0001673: Units with backspace is not spawnable on /give | ||||||||
| Description | if a unit got a backspace on it like for example "arm solar" it is impossible to spawn it trying with /give arm_solar 1 doesn't work doing /give arm solar 1 gives "bad team number solar" and so on.. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
hoijui (reporter) 2009-10-07 20:46 |
are unit names really allowed to have white spaces in htem? or is it simply not checked anywhere, but though to be disallowed? i for one would prefer to not allow white spaces in them. |
|
DOT (reporter) 2009-10-08 11:13 |
yes they are allowed to have white spaces on them it is possible to set on build info (sidedata..) that the units have a white spaces on them and buildable and such IMO spring should remove the white spaces which then gives "armsolar" instead of "arm solar" |
|
hoijui (reporter) 2009-10-09 11:21 |
I would preffer spring to gracefully die when loading such a mod. otherwise it could get confusing for the mod author or others, if he look at the mod files and see the name beeing specified as "arm solar", but hwen they try to reference it whne hte game is running, in a part of the engine that accepts unit names wiht white spaces, they woudl get a "Unit arm solar does not exist!" error. When we disallow even loading such a mod, the mod author would do the error once, and then never use spaces in file names again, so noone else then him will ever have the chance to have a problem because of it. |
|
DOT (reporter) 2009-10-09 16:21 |
Yes good idea too and Spring should also spew all Units with white spaces to it an error on Infolog on it actually the error was when the unit name is "arm solar" it will spew out "Error team solar does not exist!" or something like that |
|
hoijui (reporter) 2009-10-09 22:09 Last edited: 2009-10-10 10:18 |
looks like we have a solution, may have to ask some people if it could cause problems, then do it. |
|
Auswaschbar (reporter) 2009-10-11 13:56 |
Just print out a warning like: 'Unitname "my unit" contains whitespaces, this may cause problems.' |
|
hoijui (reporter) 2009-10-12 18:06 |
fixed with commit: 094309e6e9565a5c4f768cbbfbb74593c86106b2 only issues a warning, does not abort. i think aborting would be better, but well... this way we can blame it on Mod devs beeing stupid to not read infolog, and say we are so gentle to still allow it. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-10-07 11:42 | DOT | New Issue | |
| 2009-10-07 20:46 | hoijui | Note Added: 0004189 | |
| 2009-10-08 11:13 | DOT | Note Added: 0004190 | |
| 2009-10-09 11:21 | hoijui | Note Added: 0004191 | |
| 2009-10-09 16:21 | DOT | Note Added: 0004201 | |
| 2009-10-09 22:09 | hoijui | Note Added: 0004203 | |
| 2009-10-09 22:09 | hoijui | Status | new => acknowledged |
| 2009-10-10 10:18 | hoijui | Note Edited: 0004203 | |
| 2009-10-11 13:56 | Auswaschbar | Note Added: 0004205 | |
| 2009-10-12 18:06 | hoijui | Note Added: 0004206 | |
| 2009-10-12 18:06 | hoijui | Status | acknowledged => resolved |
| 2009-10-12 18:06 | hoijui | Fixed in Version | => 0.80.4.0+git |
| 2009-10-12 18:06 | hoijui | Resolution | open => fixed |
| 2009-10-12 18:06 | hoijui | Assigned To | => hoijui |
| Issue History |