| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0000120 | Spring engine | General | public | 2006-03-09 21:34 | 2009-11-16 15:18 | ||||
| Reporter | Bug Hunter | ||||||||
| Assigned To | hoijui | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | 0.80.4.0 | |||||||
| Summary | 0000120: Selection Editor, using Select from mouse. | ||||||||
| Description | Why C FromMouse_50++_ClearSelection_SelectNum_1+ cant select units "floating" in water or units flying in the air? Ships cant be selected by this method, unless the ship is very close to the shore. Air units will be selected only if the unit is resting in ground. Amphibious units, such as commander, will be selected when walking deep in sea, no problem. Arm pelican, will be selected on land, but cant be selected when its in water. Core Gimp can be selected when its traversing the sea. A unit that is airlifted, cant be selected by this method either. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Bug Hunter (reporter) 2006-03-12 14:41 |
A related Bug using the same hotkwey (from mouse 50 select one): When the zoom is too far away, using this hotkey will fail to select a unit. It works like this: Zoom out the most you can (in ta style mode), then hover the mouse over a unit, and press the hotkey. It will fail to select anything, even when the mouse is "touching" the unit. (remember this is not the same bug, but its realted to it). |
|
hoijui (reporter) 2009-08-10 12:31 |
This report is very hard to read/understand, plus it is old. If this is still an issue, please attack some screenshot makeing clear what you mean, and possibly how you want it to be ideally. close if no response in a month. |
|
Bug Hunter (reporter) 2009-08-10 19:26 |
Hm. well i will try to describe it again, but appreciate this finally got some attention. Background: You can make a hotkey with selection editor program, which selects a selection of units from within a radius from the mouse cursor. The hotkey works fine, but it fails to selec units that are in water, or flying. Testing: Make this hotkey : C FromMouse_50++_ClearSelection_SelectNum_1+ note: the "C" key is given as an example, and you should use one key that is free to assign a hotkey to. Startup spring and, place the mouse cursor close to a land unit, press the hotkey (in this example the "C" key). Nottice how it selects a random unit from around (50 pixels?) the mouse. the issue: Its not possible to use this hotkey to select units in water or flying. testing the issue: With the mentioned hotkey created, start spring.exe, chose a land and water map, and make some flying units, make some water units aswell. While the air units are flying, try to select them by using this hotkey method (the "C" hotkey). Nottice, it wont select any flying unit. While the sea units are on water (not close to the coast), try to selec them by using the the mentioned hotkey (the "C" hotkey). Nottice, it wont select any unit either. The resolution: A suggested behaviour, is for this kind of hotkey to work with flying units and units in water, as it does with units in land. note: screenshots of this issue wont be of any use, only making the hotkey and ingame testing can show how the issue works. please comment if you need further detail, more detailed explanation, or a different approach. thanks. |
|
hoijui (reporter) 2009-08-11 11:33 Last edited: 2009-08-11 11:38 |
ahh i see, i got it now :D thanks for the new explanation. I never touched this code, or even defined a custom key myself for spring, but my guess is, that the FromMouse_50 defines a sphere around the point where the mouse cursor touches the ground. What you want is an endless zylindrical shaped selection area. Assuming I am right with this, then we would need an other command (eg. FromMouseZyl), as the sphere selection may have its friends too. Edit: i just checked the code, and the assumption is correct, it uses a sphere, and the distance (50) is in game internal size units, not pixels. This does not yet tell us whether this really is "the problem" you are having, but it seems likely to me, so ill have a look and maybe a talk wiht the other devs to see if we add a new command or extend FromMouse or whatever. |
|
hoijui (reporter) 2009-08-11 19:26 |
I have added a new command called FromMouseZ. Try with this instead of FromMouse, it should work exactly the same except using a zylinder instead of a sphere. I have not tested it myself. If you are on windows, try with this installer: http://buildbot.eat-peet.net/spring/installer/spring_0.79.0-902-ge7d87c9.exe for linux you have to compile spring yourself. Please report back here after testing. commit adding the command: e7d87c961f7871bcb0b76006b2771955a1d8688c |
|
Bug Hunter (reporter) 2009-08-17 04:33 Last edited: 2009-08-17 04:34 |
YAY it works!! replaced frommouse with frommousez and now i can select unis flying and floating with this hotkey. The little problem ( and it was evident this will happen) is, and apparent skew (i googled that word), in the selection of flying units. I explain. If i place the cursor rigth ontop of a flying peeper (plane) and press the hotkey, it wont select the unit. I need to move the cursor lower, like one inch... lower, and then press the hotkey, then the plane will get selected. This is evident as the cilinder is drawn from the floor up, and the floor that is under the cursor when i hover over the plane, its not the floor under the plane itself, but its somehow further away. Not sure how to approach a solution in this case. taking in account the angle of the screen, and the position of the cursor, you could "guess" where is the player actually trying to select the unit... but this is not that evident and needs some thought. Anyhow if i come with a better idea of the solution will post here again. (any chance of making this one happen? http://springrts.com/mantis/view.php?id=234) :D And lots of thanks for this feature. |
|
hoijui (reporter) 2009-08-17 10:13 Last edited: 2009-08-17 10:18 |
in the meantime, FromMouseZ was renamed to FromMouseC (i used the german word Zylinder instead of the english cylinder ;-)) so if you grab a newr installer, or in the next release of spring, it will be FromMouseC. How it actually works: with FromMouseC, the Y coordinates (=height) of both the cursor and the units are set to 0 for comparison. Therefore, its not like you though of it, that the cylinder is drawn from the cursor upwards. Or in other words, if you use the top down view, without an angle, it does not matter whether you have the cursor on the ground or on a unit, no matter how high this unit is. at an angle, it makes a difference of course. This is not a bug in my eyes, and the only legitmate way to "solve" this, is to create an other selection, that uses a cylinder in the cameras direction. I have too much other, more important stuff to do at the moment, so i wont do that, neither your other feature request ;-) a tip.. the other request is also pretty unclear/not so nice to read, also, in addition to clearer text, it would be good to use a more standard text formatting convention. eg single instead of double line feeds, and double line feeds only if you start a slightly different topic. a tip for the text: think of it as if you had to explain the problem to an 8 year old, then it will turn out better, i think ;-) |
|
hoijui (reporter) 2009-11-16 15:18 |
fixes some time ago |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-03-09 21:34 | Bug Hunter | New Issue | |
| 2006-03-12 14:41 | Bug Hunter | Note Added: 0000118 | |
| 2009-08-10 12:31 | hoijui | Note Added: 0003866 | |
| 2009-08-10 12:31 | hoijui | Status | new => feedback |
| 2009-08-10 19:26 | Bug Hunter | Note Added: 0003875 | |
| 2009-08-11 11:33 | hoijui | Note Added: 0003884 | |
| 2009-08-11 11:38 | hoijui | Note Edited: 0003884 | |
| 2009-08-11 19:26 | hoijui | Note Added: 0003888 | |
| 2009-08-17 04:33 | Bug Hunter | Note Added: 0003932 | |
| 2009-08-17 04:34 | Bug Hunter | Note Edited: 0003932 | |
| 2009-08-17 10:13 | hoijui | Note Added: 0003935 | |
| 2009-08-17 10:18 | hoijui | Note Edited: 0003935 | |
| 2009-11-16 15:18 | hoijui | Note Added: 0004345 | |
| 2009-11-16 15:18 | hoijui | Status | feedback => resolved |
| 2009-11-16 15:18 | hoijui | Fixed in Version | => 0.80.4.0 |
| 2009-11-16 15:18 | hoijui | Resolution | open => fixed |
| 2009-11-16 15:18 | hoijui | Assigned To | => hoijui |
| Issue History |