| spring: develop f5c8313b | [ Diff ] [ Back to Repository ] | |||
| Author | Committer | Branch | Timestamp | Parent |
|---|---|---|---|---|
| Tobi Vollebregt | Tobi Vollebregt | develop | 2009-05-12 21:24:29 | develop a7b90a2c |
| Changeset | UnitScript: revert bug introduced in 9f223596dadeeaa51836ecf0e98e5d05696cfa7d This has to do with whether threads blocking on an animation are unblocked or not before it's being replaced. If an existing animation is replaced by an animation of the same type, then, according to the comment on top of the method, threads blocking on that animation will now wait for this new turn/move instead. If however a turn is replaced by a spin or vice versa, then the original animation should be unblocked, otherwise e.g. a wait-for-turn could wait infinitely until a spin stops spinning (which it never does by itself) The original code implemented this correctly; the bugged code implemented the above for moves while always unblocking for turns. As the comment above the method mentions, this behavior is arguable; however it is still desired to use the same overriding behavior for both moves and turns. Hence this commit. |
|||
| mod - rts/Sim/Units/COB/UnitScript.cpp | [ Diff ] [ File ] | |||
