MantisBT
Main | My View | View Issues | Change Log | Roadmap | Repositories
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000738Spring engineGeneralpublic2007-12-30 14:252010-01-31 14:40
Reportertvo 
Assigned ToAuswaschbar 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0000738: when hosting a replay, spring records a new replay
DescriptionIn my opinion the correct behaviour would be to disable replay recording entirely when hosting a replay or joining a hosted replay.

Note that while the latter may still be somewhat useful, I think it's better to disable it for two reasons:
1) hosting a replay used to be a way to show someone a replay without really giving it to them (ie. no risk it is put on forum, more privacy), and
2) it's probably quite easy to hit engine limits/bugs if someone starts hosting a replay of a hosted replay, or even hosting a replay of a hosted replay of a hosted replay :-)
TagsNo tags attached.
Attached Files

- Relationships
related to 0001311resolvedAuswaschbar crash when hosting/connecting 

-  Notes
(0001580)
imbaczek (developer)
2007-12-30 16:06

 this is useful.

you can record a commentary for an already played game; min3mat did so when he was active and I actually learned a whole lot from such replays.
(0001581)
tvo (administrator)
2007-12-30 16:56

 Ok, for the sake of reducing the number of bugs plus that reason, I'm closing it :P
(0003217)
lurker (developer)
2009-01-19 09:16

 kloot just changed this to not record. good? bad?
(0003218)
imbaczek (developer)
2009-01-19 09:18

 depends. if watching locally, it's probably a good idea, but i'd still miss rerecording real hosted replays.
(0003221)
MelTraX (reporter)
2009-01-19 10:31

 Does the demofile name say that it's a replay replay? If not that might be a good solution.
(0003223)
Kloot (developer)
2009-01-19 13:17

 For hosted replays it should suffice to check gameSetup->hostDemo, but the prospect of dealing with bugs of the sort sketched in tobi's second point isn't enticing IMHO. Perhaps replays should store their own recursion level so that the engine could decide whether re-recording is a sane idea.
(0004513)
merijnvdk (reporter)
2010-01-19 22:39

 From a normal user perspective it is weird that watching demo's record new demo's. It clutters the demo dir with duplicates and its hard to see which was the original.

If someone who wanted to record commentary's could enable it manually, it would be better, since this would probably be very few people.
(0004540)
slogic (reporter)
2010-01-26 01:19

 +1 to turn it off by default.
(0004573)
Auswaschbar (reporter)
2010-01-31 14:40

 Disabled by default, enable by setting "DemoFromDemo" to != 0.

- Issue History
Date Modified Username Field Change
2007-12-30 14:25 tvo New Issue
2007-12-30 16:06 imbaczek Note Added: 0001580
2007-12-30 16:56 tvo Status new => closed
2007-12-30 16:56 tvo Note Added: 0001581
2007-12-30 16:56 tvo Resolution open => fixed
2009-01-19 09:16 lurker Note Added: 0003217
2009-01-19 09:16 lurker Status closed => new
2009-01-19 09:16 lurker Resolution fixed => reopened
2009-01-19 09:18 imbaczek Note Added: 0003218
2009-01-19 10:31 MelTraX Note Added: 0003221
2009-01-19 13:17 Kloot Note Added: 0003223
2009-02-01 00:53 imbaczek Relationship added related to 0001311
2010-01-19 22:39 merijnvdk Note Added: 0004513
2010-01-26 01:19 slogic Note Added: 0004540
2010-01-31 14:40 Auswaschbar Note Added: 0004573
2010-01-31 14:40 Auswaschbar Status new => resolved
2010-01-31 14:40 Auswaschbar Resolution reopened => fixed
2010-01-31 14:40 Auswaschbar Assigned To => Auswaschbar

Copyright © 2000 - 2013 MantisBT Team
Powered by Mantis Bugtracker