View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0005798 | Spring engine | General | public | 2017-10-04 19:53 | 2017-10-12 12:42 | ||||
Reporter | apoleon | ||||||||
Assigned To | hokomoko | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | 104.0 | ||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0005798: Please make the build reproducible | ||||||||
Description | Currently the spring engine cannot be built reproducibly. There are several advantages when a piece of software can be built in a reproducible way. More information can be found at https://wiki.debian.org/ReproducibleBuilds. Please find attached a patch for one known issue when spring is built in different timezones. | ||||||||
Steps To Reproduce | Rebuild spring in different timezones. | ||||||||
Tags | No tags attached. | ||||||||
Checked infolog.txt for Errors | |||||||||
Attached Files |
|
Notes | |
apoleon (reporter) 2017-10-04 19:56 |
Here you can find more information about the current reproducible build result. https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/spring.html |
abma (administrator) 2017-10-05 12:41 |
Fix 68227f1a0d37defef61ce955d76bc6baf0f50f29 committed to develop branch: fix 0005798: apply patch for reproducible builds, repo: spring changeset id: 8903 |
abma (administrator) 2017-10-05 12:42 |
thanks for the patch! FYI: we also accept pull requests: https://github.com/spring/spring/pulls |
abma (administrator) 2017-10-05 12:55 |
7z allows to store without timestamps: wouldn't that be the better solution here? i.e.: $ 7z a -mtm=off reproducible.patch.7z reproducible.patch ... $ 7z l reproducible.patch.7z Date Time Attr Size Compressed Name ------------------- ----- ------------ ------------ ------------------------ ....A 808 486 reproducible.patch ------------------- ----- ------------ ------------ ------------------------ 808 486 1 files |
apoleon (reporter) 2017-10-05 13:01 |
I'm not sure. I only know that timestamps will make your build unreproducible. So turning them off is the best solution. |
abma (administrator) 2017-10-10 00:35 |
oh, bad idea: the affected files are zipped (-tzip) and zip doesn't support this param. this could be changed but i would give your change a try first as switching to 7z could cause other problems. please report back when your change doesn't for for some reason / more changes are needed. :) |
abma (administrator) 2017-10-11 00:37 |
https://github.com/spring/spring/commit/72e23c95782e54a53230870ead6161b7767c34b0 |
hokomoko (developer) 2017-10-12 12:31 |
Fix 7236dd312311ab9059a76b5771530a4c1b80c390 committed to develop branch: Fix 0005798, repo: spring changeset id: 8981 |
hokomoko (developer) 2017-10-12 12:42 |
Fix faa643929c768e50921dd247e29ce68b095d97d9 committed to develop branch: Fix 0005798 take 2, repo: spring changeset id: 8982 |
Issue History | |||
Date Modified | Username | Field | Change |
---|---|---|---|
2017-10-04 19:53 | apoleon | New Issue | |
2017-10-04 19:53 | apoleon | File Added: reproducible.patch | |
2017-10-04 19:56 | apoleon | Note Added: 0018471 | |
2017-10-05 12:41 | abma | Changeset attached | => spring develop 68227f1a |
2017-10-05 12:41 | abma | Note Added: 0018472 | |
2017-10-05 12:41 | abma | Assigned To | => abma |
2017-10-05 12:41 | abma | Status | new => resolved |
2017-10-05 12:41 | abma | Resolution | open => fixed |
2017-10-05 12:42 | abma | Note Added: 0018473 | |
2017-10-05 12:55 | abma | Status | resolved => feedback |
2017-10-05 12:55 | abma | Resolution | fixed => reopened |
2017-10-05 12:55 | abma | Note Added: 0018474 | |
2017-10-05 13:01 | apoleon | Note Added: 0018475 | |
2017-10-05 13:01 | apoleon | Status | feedback => assigned |
2017-10-10 00:35 | abma | Status | assigned => resolved |
2017-10-10 00:35 | abma | Resolution | reopened => fixed |
2017-10-10 00:35 | abma | Note Added: 0018489 | |
2017-10-11 00:37 | abma | Assigned To | abma => |
2017-10-11 00:37 | abma | Status | resolved => new |
2017-10-11 00:37 | abma | Resolution | fixed => reopened |
2017-10-11 00:37 | abma | Note Added: 0018501 | |
2017-10-12 12:31 | hokomoko | Changeset attached | => spring develop 7236dd31 |
2017-10-12 12:31 | hokomoko | Note Added: 0018504 | |
2017-10-12 12:31 | hokomoko | Assigned To | => hokomoko |
2017-10-12 12:31 | hokomoko | Status | new => resolved |
2017-10-12 12:31 | hokomoko | Resolution | reopened => fixed |
2017-10-12 12:42 | hokomoko | Changeset attached | => spring develop faa64392 |
2017-10-12 12:42 | hokomoko | Note Added: 0018505 |