| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004479 | Spring engine | Lua | public | 2014-07-30 13:28 | 2019-03-18 19:06 | ||||
| Reporter | Google_Frog | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | low | Severity | feature | Reproducibility | N/A | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 97.0.1+git | ||||||||
| Target Version | Fixed in Version | 104.0 +git | |||||||
| Summary | 0004479: Let Script.SetWatchWeapon pick callins | ||||||||
| Description | The wiki says that Script.SetWatchWeapon is required for Explosion, ProjectileCreated and ProjectileDestroyed but my testing says it is also required for AllowWeaponTarget and AllowWeaponTargetCheck. It seems like a waste of performance to watch all of these callins when I just want to watch one of them. So if there is performance to be gained from not watching everything it would be nice if Script.SetWatchWeapon were extended to let me choose which callins I want to watch. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Google_Frog (reporter) 2019-03-18 00:06 |
Can this be looked into? I am seeing a lot of time spent in Sim::Weapon (16% at times) and think that some of this could be due to unnecessary lua calls related to weapons. I watch most weapons for AllowWeaponTarget but in most cases don't want to watch the other callins. AllowWeaponTargetID==-1 could also be made into a separate callin and added to this request. |
|
Google_Frog (reporter) 2019-03-18 00:07 |
If the request is fine, but it is just a lot of tedious work, I could try to fix my compiling and make a PR. |
|
Kloot (developer) 2019-03-18 19:06 |
1102-g8639730 allows replacing SetWatchWeapon by SetWatchExplosion / SetWatchProjectile / SetWatchAllowTarget. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-07-30 13:28 | Google_Frog | New Issue | |
| 2019-03-18 00:06 | Google_Frog | Note Added: 0019871 | |
| 2019-03-18 00:07 | Google_Frog | Note Added: 0019872 | |
| 2019-03-18 00:42 | Kloot | Assigned To | => Kloot |
| 2019-03-18 00:42 | Kloot | Status | new => assigned |
| 2019-03-18 19:06 | Kloot | Status | assigned => resolved |
| 2019-03-18 19:06 | Kloot | Resolution | open => fixed |
| 2019-03-18 19:06 | Kloot | Fixed in Version | => 104.0 +git |
| 2019-03-18 19:06 | Kloot | Note Added: 0019878 | |
| Issue History |