View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0004446 | Spring engine | General | public | 2014-06-18 18:50 | 2014-06-26 17:03 | ||||
Reporter | sprung | ||||||||
Assigned To | Kloot | ||||||||
Priority | low | Severity | feature | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | |||||||||
Target Version | Fixed in Version | 97.0.1+git | |||||||
Summary | 0004446: [Pull request] Un-hardcode wobble reduction | ||||||||
Description | https://github.com/spring/spring/pull/104/ Missiles' wobble is reduced by experience in a hardcoded way and always approaches half the original value as exp increases ( https://github.com/spring/spring/blob/develop/rts/Sim/Projectiles/WeaponProjectiles/MissileProjectile.cpp#L191 ). The feature request is to make it use the ownerExpAccWeight weaponDef tag which is already used to reduce other inaccuracy effects (sprayAngle and accuracy) in a similar way. | ||||||||
Tags | No tags attached. | ||||||||
Checked infolog.txt for Errors | |||||||||
Attached Files |
|
Notes | |
sprung (reporter) 2014-06-19 18:59 |
Thanks! It seems targetMoveError also does not respect ownerExpAccWeight ( https://github.com/spring/spring/blob/develop/rts/Sim/Weapons/Weapon.cpp#L1389 ) and the formula is wrong: when XP == 0 the modified error is always 0 (ie. unit is perfectly accurate vs moving targets) and as XP increases, so does error (recuding accuracy!). I've added another PR to fix both issues (make it actually improve targetting with XP, to an extent controlled by ownerExpAccWeight) : https://github.com/spring/spring/pull/105 |
Kloot (developer) 2014-06-26 17:03 |
merged |
Issue History | |||
Date Modified | Username | Field | Change |
---|---|---|---|
2014-06-18 18:50 | sprung | New Issue | |
2014-06-19 16:38 | Kloot | Status | new => resolved |
2014-06-19 16:38 | Kloot | Fixed in Version | => 97.0.1+git |
2014-06-19 16:38 | Kloot | Resolution | open => fixed |
2014-06-19 16:38 | Kloot | Assigned To | => Kloot |
2014-06-19 18:59 | sprung | Note Added: 0013303 | |
2014-06-19 18:59 | sprung | Status | resolved => feedback |
2014-06-19 18:59 | sprung | Resolution | fixed => reopened |
2014-06-26 17:03 | Kloot | Note Added: 0013365 | |
2014-06-26 17:03 | Kloot | Status | feedback => resolved |
2014-06-26 17:03 | Kloot | Resolution | reopened => fixed |