2024-03-28 15:45 CET

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0004446Spring engineGeneralpublic2014-06-26 17:03
Reportersprung 
Assigned ToKloot 
PrioritylowSeverityfeatureReproducibilityalways
StatusresolvedResolutionfixed 
Product Version 
Target VersionFixed in Version97.0.1+git 
Summary0004446: [Pull request] Un-hardcode wobble reduction
Descriptionhttps://github.com/spring/spring/pull/104/
Missiles' wobble is reduced by experience in a hardcoded way and always approaches half the original value as exp increases ( https://github.com/spring/spring/blob/develop/rts/Sim/Projectiles/WeaponProjectiles/MissileProjectile.cpp#L191 ). The feature request is to make it use the ownerExpAccWeight weaponDef tag which is already used to reduce other inaccuracy effects (sprayAngle and accuracy) in a similar way.
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
+Relationships

-Notes

~0013303

sprung (reporter)

Thanks!
It seems targetMoveError also does not respect ownerExpAccWeight ( https://github.com/spring/spring/blob/develop/rts/Sim/Weapons/Weapon.cpp#L1389 ) and the formula is wrong: when XP == 0 the modified error is always 0 (ie. unit is perfectly accurate vs moving targets) and as XP increases, so does error (recuding accuracy!). I've added another PR to fix both issues (make it actually improve targetting with XP, to an extent controlled by ownerExpAccWeight) : https://github.com/spring/spring/pull/105

~0013365

Kloot (developer)

merged
+Notes

-Issue History
Date Modified Username Field Change
2014-06-18 18:50 sprung New Issue
2014-06-19 16:38 Kloot Status new => resolved
2014-06-19 16:38 Kloot Fixed in Version => 97.0.1+git
2014-06-19 16:38 Kloot Resolution open => fixed
2014-06-19 16:38 Kloot Assigned To => Kloot
2014-06-19 18:59 sprung Note Added: 0013303
2014-06-19 18:59 sprung Status resolved => feedback
2014-06-19 18:59 sprung Resolution fixed => reopened
2014-06-26 17:03 Kloot Note Added: 0013365
2014-06-26 17:03 Kloot Status feedback => resolved
2014-06-26 17:03 Kloot Resolution reopened => fixed
+Issue History