| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0003482 | Spring engine | General | public | 2013-02-20 01:39 | 2013-03-15 07:18 | ||||
| Reporter | Forboding Angel | ||||||||
| Assigned To | jK | ||||||||
| Priority | normal | Severity | feature | Reproducibility | always | ||||
| Status | closed | Resolution | won't fix | ||||||
| Product Version | 92.0.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0003482: Spring Removes lines from springsettings.cfg if they are default values | ||||||||
| Description | http://springrts.com/mantis/view.php?id=3480#c9852 This is wrong for so many reasons. Spring should print ALL values to springsettings on every run, so that it is useful for direct file editing which some lobbies use. Spring should not remove lines from springsettings if they happen to be default values, that is silly. This behavior is a bug. Plain and simple. Spring should write defaults to springsettings.cfg, not remove them. This is 2013., I'm sure we can come up with a better solution than just nixing lines. Change a value in the file, if it happens to coincide with a default value, that line gets removed and you can't edit it anymore. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
jK (developer) 2013-02-20 01:41 |
configs should be edited with GUIs |
|
Forboding Angel (reporter) 2013-02-20 03:04 |
But they should not _have_ to be editable by a gui. Moreover, guis generally lack all of the the option sets. It would be nice to be able to simply open the file and have a list of all the params that spring has available. In this way, not only could you develop a gui for it, you would also have the ability to edit the file directly, if a gui isn't your "thing". It may seem like a useless "feature" to you, but spring removing values from springsettings is very detrimental to user control (advanced and simple). |
|
Google_Frog (reporter) 2013-02-20 09:52 |
+1 |
|
jK (developer) 2013-02-20 12:18 Last edited: 2013-02-20 12:19 |
| It would be nice to be able to simply open the file and have a list of all the params that spring has available. 1. this fails once you reached a huge amount of settings (like Spring did) 2. seeing only `eff.` values makes debugging like 1000x easier 3. an 2013 way would even be less userfriendly (cloud and/or database saving of such things) |
|
abma (administrator) 2013-02-20 15:18 Last edited: 2013-02-20 15:24 |
only clean "solution" i see is to add all default settings as comments like: //Vertical synchronization, update render frames in monitor's refresh rate. <=0: // off // 1: enabled // x: render with monitor-Hz/x FPS // default Value: // VSync = 0 but this will create some other problems like: - huge springrc - possible duplicate comments - settings files posted to pastebin are huge, too - no benefits to engine devs @Forb: "This behavior is a bug. Plain and simple." no, this is a feature. code was added to implement this feature! |
|
abma (administrator) 2013-02-20 15:26 Last edited: 2013-02-20 15:28 |
note: i don't see why this is important it sucks if you manually edit springrc, but it makes things a lot simpler for us devs to see which setting causes problems. usally you shouldn't have to touch config files directly. you can edit ALL settings with running spring.exe, also config settings are on the wiki: http://springrts.com/wiki/Springrc |
|
Forboding Angel (reporter) 2013-02-21 01:10 |
Honestly, if spring didn't remove lines, that would be ok, but also build in the ability to make spring dump all the lines to a file, so you can pick and choose what you want (usually the relevant bits). I don't think any of us were aware that this was a situation where you could have a springrc of 1k+ lines. Maybe someone else has another more elegant solution? |
|
Forboding Angel (reporter) 2013-02-21 01:38 |
I did not realize that JK was using hyperbole to make a point when he said 1k lines. In reality it;s less than 100, so I'm pretty sure that a 300kb springsettings isn't going to cause anyone to lose sleep. How about this... All the lines that are in spring > edit settings should be printed in springsettings.cfg/springrc regardless of whether their value matches default or not. The fact of the matter is, editing a text file is very fast and allows uber control. For myself and evo players, I would actually add comments to it to explain the lines, making it super easy, but I need spring to stop removing lines! |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-02-20 01:39 | Forboding Angel | New Issue | |
| 2013-02-20 01:41 | jK | Note Added: 0009862 | |
| 2013-02-20 01:41 | jK | Status | new => closed |
| 2013-02-20 01:41 | jK | Assigned To | => jK |
| 2013-02-20 01:41 | jK | Resolution | open => won't fix |
| 2013-02-20 03:04 | Forboding Angel | Note Added: 0009863 | |
| 2013-02-20 03:04 | Forboding Angel | Status | closed => feedback |
| 2013-02-20 03:04 | Forboding Angel | Resolution | won't fix => reopened |
| 2013-02-20 09:52 | Google_Frog | Note Added: 0009864 | |
| 2013-02-20 12:18 | jK | Note Added: 0009865 | |
| 2013-02-20 12:19 | jK | Note Edited: 0009865 | View Revisions |
| 2013-02-20 15:18 | abma | Note Added: 0009866 | |
| 2013-02-20 15:21 | abma | Note Edited: 0009866 | View Revisions |
| 2013-02-20 15:22 | abma | Note Edited: 0009866 | View Revisions |
| 2013-02-20 15:24 | abma | Note Edited: 0009866 | View Revisions |
| 2013-02-20 15:24 | abma | Note Edited: 0009866 | View Revisions |
| 2013-02-20 15:25 | abma | Priority | high => normal |
| 2013-02-20 15:26 | abma | Note Added: 0009867 | |
| 2013-02-20 15:27 | abma | Note Edited: 0009867 | View Revisions |
| 2013-02-20 15:28 | abma | Note Edited: 0009867 | View Revisions |
| 2013-02-21 01:10 | Forboding Angel | Note Added: 0009872 | |
| 2013-02-21 01:10 | Forboding Angel | Status | feedback => assigned |
| 2013-02-21 01:38 | Forboding Angel | Note Added: 0009873 | |
| 2013-03-15 07:18 | abma | Status | assigned => closed |
| 2013-03-15 07:18 | abma | Resolution | reopened => won't fix |
| Issue History |