2025-07-04 13:45 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0003152Spring engineGeneralpublic2012-07-09 00:13
ReporterDeadnight Warrior 
Assigned ToKloot 
PrioritylowSeveritytrivialReproducibilityalways
StatusresolvedResolutionno change required 
Product Version89.0 
Target VersionFixed in Version89.0 
Summary0003152: Beam Laser start sound is spammed every game frame
DescriptionI've encountered this only on Beam Lasers, the start sound is spammed every game frame for the entire duration of the beam.

Side note: since the hit sounds for beam lasers work in 88+ I've disabled them for BeamLaser weapons to replicate 88.0 and older engine behaviour.
Steps To ReproduceLoad any Spring game the has units with beam lasers, Annihilators are the best example as their beam duration is ~1s long or more.
Additional InformationTested with http://springrts.com/dl/buildbot/default/release/88.0.1-465-g5c3d1b7/
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files
  • ? file icon Annihilator.flac (775,138 bytes) 2012-07-07 22:51
  • ? file icon BeamHLT.flac (521,197 bytes) 2012-07-07 22:52
  • ? file icon HLTanni.flac (449,057 bytes) 2012-07-07 22:52
  • txt file icon infolog.txt (17,419 bytes) 2012-07-07 22:57 -
    Using configuration source: "D:\Igre\Strateg\Spring89r\springsettings.cfg"
    [CMyMath::Init] CPU SSE mask: 126, flags:
    	SSE 1.0:  1,  SSE 2.0:  1
    	SSE 3.0:  1, SSSE 3.0:  1
    	SSE 4.1:  1,  SSE 4.2:  0
    	SSE 4.0A: 0,  SSE 5.0A: 0
    	using streflop SSE FP-math mode, CPU supports SSE instructions
    OS: Microsoft Windows
    Microsoft Windows 7 Business Edition, 64-bit Service Pack 1 (build 7601)
    Intel(R) Core(TM)2 Duo CPU     T9300  @ 2.50GHz; 4094MB RAM, 4092MB pagefile
    OS: emulated 32bit mode
    [Watchdog] Installed (HangTimeout: 10sec)
    Available log sections: KeyBindings, CSMFGroundTextures, RoamMeshDrawer, BumpWater, DynWater, SkyBox, FarTextureHandler, Model, Piece, ModelDrawer, OBJParser, WorldObjectModelRenderer, Texture, Font, CollisionVolume, GroundMoveType, Path, UnitScript, AutohostInterface, ArchiveScanner, VFS, Sound, LuaSocket
    Enabled log sections: Sound(LOG_LEVEL_INFO)
    Enable or disable log sections using the LogSections configuration key
      or the SPRING_LOG_SECTIONS environment variable (both comma separated).
      Use "none" to disable the default log sections.
    LogOutput initialized.
    Spring 88.0.1-501-g059b391 release
    Build date/time: Jul  7 2012 17:47:55
    Build environment: boost-104800, GNU libstdc++ version 20100429
    Compiler: gcc-4.4.4
    Using read-write data directory: D:\Igre\Strateg\Spring89r\
    Using read-only data directory: D:\My Documents\Spring\
    Scanning: D:\My Documents\Spring\maps
    Scanning: D:\My Documents\Spring\base
    Scanning: D:\My Documents\Spring\mods
    Scanning: D:\Igre\Strateg\Spring89r\base
    Scanning: D:\Igre\Strateg\Spring89r\games
    Supported Video modes: 1920x1200, 1920x1080, 1680x1050, 1600x1200, 1440x900, 1366x768, 1280x1024, 1280x800, 1280x720, 1024x768, 800x600, 720x576, 720x480, 640x480
    Video mode set to 1920x1200/32bit
    [f=0000000] SDL version:  1.2.10
    [f=0000000] GL version:   3.3.0
    [f=0000000] GL vendor:    NVIDIA Corporation
    [f=0000000] GL renderer:  Quadro FX 3600M/PCIe/SSE2
    [f=0000000] GLSL version: 3.30 NVIDIA via Cg compiler
    [f=0000000] GLEW version: 1.5.8
    [f=0000000] Video RAM:    total 512MB, available 413MB
    [f=0000000] GL info:
    	haveARB: 1, haveGLSL: 1, ATI hacks: 0
    	FBO support: 1, NPOT-texture support: 1, 24bit Z-buffer support: 1
    	maximum texture size: 8192, compress MIP-map textures: 0
    	maximum SmoothPointSize: 63, maximum vec4 varying/attributes: 15/16
    	maximum drawbuffers: 8, maximum recommended indices/vertices: 1048576/1048576
    	number of UniformBufferBindings: 36
    [f=0000000] Using VSync
    [f=0000000] Joysticks found: 0
    [f=0000000] Warning: Joystick 0 not found
    [f=0000000] CPU Cores: 2
    [f=0000000] CPU affinity mask set: 2
    [f=0000000] [Sound] OpenAL info:
    [f=0000000] [Sound]   Available Devices:
    [f=0000000] [Sound]               DirectSound Software
    [f=0000000] [Sound]   Device:     DirectSound Software
    [f=0000000] [Sound]   Vendor:         OpenAL Community
    [f=0000000] [Sound]   Version:        1.1 ALSOFT 1.11.753
    [f=0000000] [Sound]   Renderer:       OpenAL Soft
    [f=0000000] [Sound]   AL Extensions:  AL_EXTX_buffer_sub_data AL_EXT_EXPONENT_DISTANCE AL_EXT_FLOAT32 AL_EXT_IMA4 AL_EXT_LINEAR_DISTANCE AL_EXT_MCFORMATS AL_EXT_OFFSET AL_EXTX_sample_buffer_object AL_EXT_source_distance_model AL_LOKI_quadriphonic
    [f=0000000] [Sound]   ALC Extensions: ALC_ENUMERATE_ALL_EXT ALC_ENUMERATION_EXT ALC_EXT_CAPTURE ALC_EXT_disconnect ALC_EXT_EFX ALC_EXTX_thread_local_context
    [f=0000000] [Sound]   EFX Enabled: yes
    [f=0000000] [Sound]   Max Sounds: 128
    [f=0000000] Connecting to local server
    [f=0000000] PreGame::StartServer: 3520 ms
    [f=0000000] Using map: Tropical
    [f=0000000] Using game: XTA 9.716 beta
    [f=0000000] Using game archive: XTAPEV972.sdd
    [f=0000000] recording demo: demos/20120707_223827_Tropical_88.0.1-501-g059b391 release.sdf
    [f=0000000] PreGame::GameDataReceived: 639 ms
    [f=0000000] User number 0 (team 0, allyteam 0)
    [f=0000000] LoadingScreen: single-threaded
    [f=0000000] Loading Radar Icons
    [f=0000000] Loading GameData Definitions
    [f=0000000] WARNING: removed core_mkrogoth unitDef, missing model file  (core_mkrogoth.3do)
    [f=0000000] Loading all definitions:  1.050000
    [f=0000000] Game::LoadDefs (GameData): 1143 ms
    [f=0000000] Loading Sound Definitions
    [f=0000000] [Sound]  parsed 5 sounds from gamedata/sounds.lua
    [f=0000000] Game::LoadDefs (Sound): 30 ms
    [f=0000000] Parsing Map Information
    [f=0000000] Loading SMF
    [f=0000000] Loading Map (145 MB)
    [f=0000000] Creating Smooth Height Mesh
    [f=0000000] SmoothHeightMesh::MakeSmoothMesh: 337 ms
    [f=0000000] Creating QuadField & CEGs
    [f=0000000] Number of damage types: 17
    [f=0000000] [RegisterAssimpModelParsers] supported Assimp model formats: *.3d;*.3ds;*.ac;*.ac3d;*.acc;*.ase;*.ask;*.b3d;*.blend;*.bvh;*.cob;*.csm;*.dae;*.dxf;*.enff;*.hmp;*.ifc;*.irr;*.irrmesh;*.lwo;*.lws;*.lxo;*.m3;*.md2;*.md3;*.md5anim;*.md5camera;*.md5mesh;*.mdc;*.mdl;*.mesh.xml;*.mot;*.ms3d;*.ndo;*.nff;*.obj;*.off;*.pk3;*.ply;*.prj;*.q3o;*.q3s;*.raw;*.scn;*.smd;*.stl;*.ter;*.uc;*.vta;*.x;*.xgl;*.xml;*.zgl;
    [f=0000000] Creating Unit Textures
    [f=0000000] Loading Weapon Definitions
    [f=0000000] Warning: weapondef cylinderTargetting is deprecated and will be removed in the next release (use cylinderTargeting).
    [f=0000000] Warning: weapondef cylinderTargetting is deprecated and will be removed in the next release (use cylinderTargeting).
    [f=0000000] Warning: weapondef cylinderTargetting is deprecated and will be removed in the next release (use cylinderTargeting).
    [f=0000000] Loading Unit Definitions
    [f=0000000] Warning: [UnitDef] inconsistent path-type 13 for "arm_plesiosaur" (move-class "tankhover4"): canFloat, but not a ship-based movetype
    [f=0000000] Warning: Could not load sound from def: hovsmof1
    [f=0000000] Warning: [UnitDef] inconsistent path-type 13 for "zulu" (move-class "tankhover4"): canFloat, but not a ship-based movetype
    [f=0000000] Loading Feature Definitions
    [f=0000000] Initializing Map Features
    [f=0000000] Reading Estimate PathCosts [8]
    [f=0000000] Reading Estimate PathCosts [32]
    [f=0000000] [CPathManager] pathing data checksum: aa155f7d
    [f=0000000] [IPathManager::GetInstance] using DEFAULT path-manager
    [f=0000000] Creating Sky
    [f=0000000] Creating ShadowHandler & DecalHandler
    [f=0000000] Creating GroundDrawer
    [f=0000000] Loading Tile Files
    [f=0000000] Reading Tile Map
    [f=0000000] Loading Square Textures
    [f=0000000] CSMFGroundTextures::ConvolveHeightMap: 9 ms
    [f=0000000] Switching to ROAM Mesh Rendering
    [f=0000000] Creating TreeDrawer
    [f=0000000] Creating ProjectileDrawer & UnitDrawer
    [f=0000000] Creating Projectile Textures
    [f=0000000] Creating Water
    [f=0000000] Game::LoadInterface (Camera&Mouse): 88 ms
    [f=0000000] Game::LoadInterface (Console): 1 ms
    [f=0000000] [Sound] Warning: Unable to open audio file: FailedCommand
    [f=0000000] [Sound] Warning: CSound::GetSoundId: could not find sound: FailedCommand
    [f=0000000] Loading LuaRules
    [f=0000000] Loaded gadget:  CobButton           <unit_cobbutton.lua>
    [f=0000000] Loaded gadget:  workaround for airtrans-com-death crash  <unit_transportcomfix.lua>
    [f=0000000] Loaded gadget:  AirPlantParents     <unit_air_plants.lua>
    [f=0000000] Loaded gadget:  Announce kills      <ui_announce_kills.lua>
    [f=0000000] Loaded gadget:  Disable Buildoptions  <unit_disable_buildoptions.lua>
    [f=0000000] Loaded gadget:  Dynamic collision volume & Hitsphere Scaledown  <unit_dynamic_collision_volume.lua>
    [f=0000000] Loaded gadget:  Energy Conversion   <game_energy_conversion.lua>
    [f=0000000] nil
    [f=0000000] Loaded gadget:  Factory Anti-Stuck  <factory_anti_stuck.lua>
    [f=0000000] Loaded gadget:  Fire Rate           <unit_fire_rate.lua>
    [f=0000000] Loaded gadget:  Game End            <game_end.lua>
    [f=0000000] Loaded gadget:  Health Upgrade      <unit_health_upgrade.lua>
    [f=0000000] Loaded gadget:  Initial Spawn       <game_initial_spawn.lua>
    [f=0000000] Loaded gadget:  Jumpjets            <unit_jumpjets.lua>
    [f=0000000] Loading gadget: Lua unit script framework  <unit_script.lua>
    [f=0000000] Loaded gadget:  Lua unit script framework  <unit_script.lua>
    [f=0000000] Loaded gadget:  No Land Damage      <unit_no_land_damage.lua>
    [f=0000000] Loaded gadget:  No Self Pwn         <unit_noselfpwn.lua>
    [f=0000000] Loaded gadget:  NoAirNuke           <exp_no_air_nuke.lua>
    [f=0000000] Loaded gadget:  Production Rate     <unit_buildspeed.lua>
    [f=0000000] Loaded gadget:  Reclaim flash       <gfx_reclaim_flash.lua>
    [f=0000000] Loaded gadget:  Repair Pad          <unit_refuel.lua>
    [f=0000000] Loaded gadget:  Spawn               <commoption.lua>
    [f=0000000] Loaded gadget:  State Broadcast     <game_statebroadcast.lua>
    [f=0000000] Loaded gadget:  UnitEStallDisable   <unit_estall_disable.lua>
    [f=0000000] Loaded gadget:  UnitMorph           <unit_morph.lua>
    [f=0000000] Loaded gadget:  UnitStealth         <unit_stealth.lua>
    [f=0000000] Loaded gadget:  Watereffects        <fx_watersplash.lua>
    [f=0000000] Loaded gadget:  gfx_dynamic_lighting.lua  <gfx_dynamic_lighting.lua>
    [f=0000000] Loaded gadget:  lups_wrapper.lua    <lups_wrapper.lua>
    [f=0000000] Loaded gadget:  unit_passive_builders_ii.lua  <unit_passive_builders_ii.lua>
    [f=0000000] Loaded gadget:  Area Attack         <areaattack.lua>
    [f=0000000] Loaded gadget:  Sneer after comnap  <ui_comnapsneer.lua>
    [f=0000000] Loaded gadget:  Team Com Ends       <teamcomends.lua>
    [f=0000000] Loaded gadget:  LupsSyncedManager   <lups_manager.lua>
    [f=0000000] Loaded gadget:  Mex Upgrader Gadget  <unit_mex_upgrader.lua>
    [f=0000000] Loaded gadget:  workaround for airtrans-com-death crash  <unit_transportcomfix.lua>
    [f=0000000] Loaded gadget:  AirPlantParents     <unit_air_plants.lua>
    [f=0000000] Loaded gadget:  Announce kills      <ui_announce_kills.lua>
    [f=0000000] Loaded gadget:  Dynamic collision volume & Hitsphere Scaledown  <unit_dynamic_collision_volume.lua>
    [f=0000000] nil
    [f=0000000] Loaded gadget:  Factory Anti-Stuck  <factory_anti_stuck.lua>
    [f=0000000] Loaded gadget:  Reclaim flash       <gfx_reclaim_flash.lua>
    [f=0000000] Loaded gadget:  State Broadcast     <game_statebroadcast.lua>
    [f=0000000] Loaded gadget:  UnitEStallDisable   <unit_estall_disable.lua>
    [f=0000000] Loaded gadget:  UnitMorph           <unit_morph.lua>
    [f=0000000] Loaded gadget:  UnitStealth         <unit_stealth.lua>
    [f=0000000] Loaded gadget:  Watereffects        <fx_watersplash.lua>
    [f=0000000] Loaded gadget:  gfx_dynamic_lighting.lua  <gfx_dynamic_lighting.lua>
    [f=0000000] Loaded gadget:  mo_nowrecks         <mo_nowrecks.lua>
    [f=0000000] Loaded gadget:  unit_passive_builders_ii.lua  <unit_passive_builders_ii.lua>
    [f=0000000] Loaded gadget:  Area Attack         <areaattack.lua>
    [f=0000000] Loaded gadget:  Sneer after comnap  <ui_comnapsneer.lua>
    [f=0000000] Loaded gadget:  LupsSyncedManager   <lups_manager.lua>
    [f=0000000] Loaded gadget:  Mex Upgrader Gadget  <unit_mex_upgrader.lua>
    [f=0000000] Loaded gadget:  Lups                <lups_wrapper.lua>
    [f=0000000] Loading LuaGaia
    [f=0000000] Loading LuaUI
    [f=0000000] LuaSocketEnabled: no
    [f=0000000] Using LUAUI_DIRNAME = LuaUI/
    [f=0000000] Reloaded ctrlpanel from file: LuaUI/ctrlpanel.txt
    [f=0000000] LuaUI: bound F11 to the widget selector
    [f=0000000] LuaUI: bound CTRL+F11 to tweak mode
    [f=0000000] Failed to load: gui_attack_aoe_xta.lua  (duplicate name)
    [f=0000000] Failed to load: helper.lua  (duplicate name)
    [f=0000000] Failed to load: unit_buildbar_xta.lua  (duplicate name)
    [f=0000000] Loading widget from mod:   Metalspot Finder    <wg_metalspot_finder.lua> ...
    [f=0000000] Loading widget from mod:   MexUpg Helper       <cmd_mex_upgrade_helper.lua> ...
    [f=0000000] Loading widget from mod:   Commander Change    <gui_commchange.lua> ...
    [f=0000000] Loading widget from mod:   Commander Name Tags1.2  <unit_comm_nametags.lua> ...
    [f=0000000] Loading widget from mod:   HealthBars          <unit_healthbars.lua> ...
    [f=0000000] Loading widget from mod:   XTA Layout          <gui_xta_layout.lua> ...
    [f=0000000] Reloaded ctrlpanel from file: LuaUI/ctrlpanelImp.txt
    [f=0000000] Loading widget from mod:   Ally Resource Bars  <gui_ally_res.lua> ...
    [f=0000000] Loading widget from mod:   AdvPlayersList      <gui_advplayerslist.lua> ...
    [f=0000000] Loading widget from mod:   BuildETA - XTA      <gui_build_eta_xta.lua> ...
    [f=0000000] Loading widget from mod:   Cloak Fire State    <unit_cloakfirestate.lua> ...
    [f=0000000] Loading widget from mod:   Don't Shoot         <unit_dontshoot.lua> ...
    [f=0000000] Loading widget from mod:   Initial Queue - XTA  <unit_initial_queue.lua> ...
    [f=0000000] Loading widget from mod:   Autoquit            <autoquit.lua> ...
    [f=0000000] Loading widget from mod:   BuildBar - XTA      <gui_buildbar_xta.lua> ...
    [f=0000000] BuildBar Warning: you deactivated the "blurApi" widget, please reactivate it.
    [f=0000000] Loading widget from mod:   CameraShake         <camera_shake.lua> ...
    [f=0000000] Loading widget from mod:   DGun Stall Assist   <unit_dgun_stall_assist.lua> ...
    [f=0000000] Loading widget from mod:   Defense Range - XTA  <gui_xta_defenserange.lua> ...
    [f=0000000] Loading widget from mod:   DontMove - XTA      <unit_dontmove_xta.lua> ...
    [f=0000000] Loading widget from mod:   Energy Conversion Info  <gui_energy_conversion.lua> ...
    [f=0000000] Loading widget from mod:   FactoryQ Manager    <cmd_factoryqmanager.lua> ...
    [f=0000000] XTA
    [f=0000000] Loading widget from mod:   Highlight Geos      <gui_highlight_geos.lua> ...
    [f=0000000] Loading widget from mod:   Holdfire Fix        <unit_holdfire_fix.lua> ...
    [f=0000000] Loading widget from mod:   ImmobileBuilder     <unit_immobile_buider.lua> ...
    [f=0000000] Loading widget from mod:   Loop Select         <unit_loop_select.lua> ...
    [f=0000000] Loading widget from mod:   Mex Snap            <cmd_mex_snap.lua> ...
    [f=0000000] Loading widget from mod:   Nuke Button         <gui_nukebutton.lua> ...
    [f=0000000] Loading widget from mod:   Pause Screen - XTA  <gui_pausescreen_xta.lua> ...
    [f=0000000] Loading widget from mod:   Point Tracker       <gui_point_tracker.lua> ...
    [f=0000000] Loading widget from mod:   ReclaimInfo - XTA   <gui_reclaiminfo_xta.lua> ...
    [f=0000000] Loading widget from mod:   SelectionButtons    <gui_selbuttons.lua> ...
    [f=0000000] Loading widget from mod:   State Reverse Toggle  <cmd_state_reverse_toggle.lua> ...
    [f=0000000] Loading widget from mod:   UnitGroups v5.1 - XTA  <gui_unitgroups5_1_xta.lua> ...
    [f=0000000] Loading widget from mod:   MetalFeatures       <gui_metal_features.lua> ...
    [f=0000000] Loading widget from mod:   Ally Selected Units  <unit_allyselectedunits.lua> ...
    [f=0000000] Loading widget from mod:   Volume OSD          <snd_volume_osd.lua> ...
    [f=0000000] Volume = 100
    [f=0000000] Loading widget from mod:   Force cloak         <gui_forcecloak.lua> ...
    [f=0000000] Loading widget from mod:   Stockpiler (dynamic, alternate version) - XTA  <unit_stockpile_dynamic_alt.lua> ...
    [f=0000000] Loading widget from mod:   Z Selector          <unit_z_selector.lua> ...
    [f=0000000] Loading widget from mod:   Start Point Remover - XTA  <init_start_point_remover_xta.lua> ...
    [f=0000000] Loading widget from mod:   Attack AoE          <gui_attack_aoe.lua> ...
    [f=0000000] Loading widget from mod:   Attack and Move Notification  <unit_attackmovenotification.lua> ...
    [f=0000000] Loading widget from mod:   Prospector - XTA    <gui_prospector_xta.lua> ...
    [f=0000000] Loading widget from mod:   AllyCursors         <gui_ally_cursors.lua> ...
    [f=0000000] Loading widget from mod:   BA Waypoint Dragger  <unit_waypoint_dragger.lua> ...
    [f=0000000] Loading widget from mod:   Select n Center! - XTA  <gui_center_n_select_xta.lua> ...
    [f=0000000] Loading widget from mod:   LupsManager         <gfx_lups_manager.lua> ...
    [f=0000000] Loading widget from mod:   Lups                <lups_wrapper.lua> ...
    [f=0000000] Loading widget from mod:   CustomFormations2   <unit_customformations2.lua> ...
    [f=0000000] Loading widget from mod:   Jumjet GUI          <gui_jumpjets.lua> ...
    [f=0000000] LuaUI v0.3
    [f=0000000] Finalizing
    [f=0000000] Connection attempt from UnnamedPlayer
    [f=0000000]  -> Version: 88.0.1-501-g059b391 release
    [f=0000000]  -> Connection established (given id 0)
    [f=0000000] Player UnnamedPlayer finished loading and is now ingame
    [f=0000000] Cheating is enabled!
    [f=0000000] GameID: 529ef84f66b62fbcb046d4d01cdf4421
    [f=0000000] State Broadcast ended
    [f=0000001] Skirmish AI "Enemy" (ID:0, Short-Name:"NullAI", Version:"0.1") took over control of team 1
    [f=0000391] [GiveUnits] spawned 1 arm_annihilator unit(s) for team 0
    [f=0000762] [GiveUnits] spawned 1 arm_advanced_radar_tower unit(s) for team 0
    [f=0001072] [GiveUnits] spawned 1 arm_fusion_reactor unit(s) for team 0
    [f=0001300] [GiveUnits] spawned 1 arm_energy_storage unit(s) for team 0
    [f=0001523] [GiveUnits] spawned 1 core_goliath unit(s) for team 0
    [f=0002358] UnnamedPlayer has taken the lead with 1 kills.
    [f=0011432] [GiveUnits] spawned 1 arm_sentinel unit(s) for team 0
    [f=0012211] User exited
    [f=0012212] Force cloak: widget removed for spectators
    [f=0012212] Path cache hits 0 0%
    [f=0012212] Path cache hits 0 0%
    [f=0012212] Statistics for RectangleOptimizer: 0%
    [f=0012212] Statistics for RectangleOptimizer: 0%
    [f=0012212] Statistics for local connection:
    Received: 27665 bytes
    Sent: 137640 bytes
    
    
    txt file icon infolog.txt (17,419 bytes) 2012-07-07 22:57 +

-Relationships
+Relationships

-Notes

~0008893

Kloot (developer)

as I told you before in the lobby: the sound that gets spammed is hitSound (because this now works for beamlasers, and they hit every frame their beam is active), not startSound.

changing soundhit=xplolrg1; to soundhit="" in weapons.tdf (of an svn checkout of XTA) for ARM_TOTAL_ANNIHILATOR fixes it, you probably changed ARMMANNI_WEAPON which is NOT used by arm_annihilator.

~0008918

Deadnight Warrior (reporter)

All sounds are recorded from XTA running on http://springrts.com/dl/buildbot/default/release/88.0.1-501-g059b391/

Annihilator.flac is the Annihilator in XTA on 88+.0
BeamHLT.flac is the HLT sound when put on a Annihilator (Beam Laseer, 1s dur)
HLTanni.flac is the Annihilator sound put on a HLT (Laser Cannon)

~0008919

Kloot (developer)

Last edited: 2012-07-08 01:03

View 4 revisions

some notes:

beamlasers are fine simulation-wise, they behave as in 88.0 (dealing the same amount of damage, etc --> no hidden extra beams being fired)

Annihilator.flac is almost like a short reverb effect was added, but the original files (wavs) have none and sound normal when played in an external tool

HLTanni.flac contains no corruption, but is the same sound as used to record Annihilator.flac (just put on a different weapon)

in both XTA 9.71 and BA 7.68, commenting out soundhit (in weapons.tdf::ARM_TOTAL_ANNIHILATOR / armanni.lua respectively) makes annihilator sound exactly like in 88.0, but not in XTA svn where soundstart retains a "reverb" effect

~0008920

zerver (reporter)

This commit appears to be causing it:

https://github.com/spring/spring/commit/2a7d9493c47cbd4a619f5b51d280b72f3d9e68f5

Kloot is best man to answer if the new behavior is intentional or if we need a backwards compatibility fix.

~0008925

Deadnight Warrior (reporter)

Last edited: 2012-07-08 02:32

View 5 revisions

While soundTrigger should have no effect on weapons that fire only one shot, it seems to affect BeamLasers

Any BeamLaser that has soundTrigger = 0 (default is 1) or has soundhit != "" or soundhitdry != "" will spam soundstart for the duration of it's beam.

~0008926

Kloot (developer)

Last edited: 2012-07-08 12:06

View 7 revisions

aaargh, what did we spend 2+ hours discussing yesterday?!

when soundhit != "" or soundhitdry != "", SOUNDHIT gets spammed, *NOT* SOUNDSTART --> THIS part is semi-intentional, because soundhit never worked for beamlasers before

additionally when soundTrigger = 0, SOUNDSTART is played every frame --> as it should, but this part is non-intentional because the default value of soundTrigger seems to have changed from 1 to 0 for BeamLasers (tested in XTA, BA, and ZK, XTA-svn has soundTrigger=0 explicitly)

note: XTA's Annihilator has salvoSize=30 (not a burst-weapon, so salvoSize == beamtime * GAME_SPEED == 1 * 30 == 30), so that's 30 overlapping soundstart samples per shot

~0008927

zerver (reporter)

How about renaming it to soundHitContinuousDry and soundHitContinuousWet for beam lasers? Then it will be quiet like before unless these new tags are specified...

~0008929

Deadnight Warrior (reporter)

One last bug about hitsounds:

If soundhitdry is not defined, but soundhitwet is, when the weapon impacts land soundhitwet will be played instead of nothing, and when it impacts water nothing will be played instead of soundhitwet.

If soundhitdry is defined and soundhitwet isn't there are no problems.

I think it's a bug in the https://github.com/spring/spring/blob/develop/rts/Sim/Weapons/WeaponDefHandler.cpp#L490 function, it does a gsound.sounds.push_back(...) and doesn't load the sound at a specific array index, as index 0 is dry sound and index 1 is wet, but this way sounds are populated as they are found, and if no dry sound is found, wet sound is put on its place.

~0008934

Kloot (developer)

fixed (the above dry/wet issue)

soundtrigger having changed default value was false alarm, beamlasers in BA, ZK, ... are still correctly tagged afaics. so because 99% of the issues are just due to hitsound now playing for beamlaser impacts and because a single line in weapondefs_post.lua is enough to block that, I'm marking this as resolved.
+Notes

-Issue History
Date Modified Username Field Change
2012-07-06 18:08 Deadnight Warrior New Issue
2012-07-06 22:21 zerver Assigned To => zerver
2012-07-06 22:21 zerver Status new => assigned
2012-07-07 13:58 Kloot Note Added: 0008893
2012-07-07 13:58 Kloot Status assigned => closed
2012-07-07 13:58 Kloot Assigned To zerver =>
2012-07-07 13:58 Kloot Resolution open => no change required
2012-07-07 22:50 Kloot Assigned To => Kloot
2012-07-07 22:50 Kloot Status closed => feedback
2012-07-07 22:50 Kloot Resolution no change required => reopened
2012-07-07 22:51 Deadnight Warrior File Added: Annihilator.flac
2012-07-07 22:52 Deadnight Warrior File Added: BeamHLT.flac
2012-07-07 22:52 Deadnight Warrior File Added: HLTanni.flac
2012-07-07 22:55 Deadnight Warrior Note Added: 0008918
2012-07-07 22:55 Deadnight Warrior Status feedback => assigned
2012-07-07 22:57 Deadnight Warrior File Added: infolog.txt
2012-07-07 23:34 Kloot Note Added: 0008919
2012-07-07 23:35 Kloot Note Edited: 0008919 View Revisions
2012-07-08 00:09 Kloot Note Edited: 0008919 View Revisions
2012-07-08 01:02 zerver Assigned To Kloot => zerver
2012-07-08 01:03 Kloot Note Edited: 0008919 View Revisions
2012-07-08 01:16 zerver Status assigned => confirmed
2012-07-08 01:37 zerver Note Added: 0008920
2012-07-08 01:37 zerver Assigned To zerver => Kloot
2012-07-08 01:37 zerver Status confirmed => assigned
2012-07-08 02:14 Deadnight Warrior Note Added: 0008925
2012-07-08 02:15 Deadnight Warrior Note Edited: 0008925 View Revisions
2012-07-08 02:16 Deadnight Warrior Note Edited: 0008925 View Revisions
2012-07-08 02:24 Deadnight Warrior Note Edited: 0008925 View Revisions
2012-07-08 02:32 Deadnight Warrior Note Edited: 0008925 View Revisions
2012-07-08 11:57 Kloot Note Added: 0008926
2012-07-08 11:57 Kloot Note Edited: 0008926 View Revisions
2012-07-08 11:58 Kloot Note Edited: 0008926 View Revisions
2012-07-08 11:58 Kloot Note Edited: 0008926 View Revisions
2012-07-08 12:01 Kloot Note Edited: 0008926 View Revisions
2012-07-08 12:04 Kloot Note Edited: 0008926 View Revisions
2012-07-08 12:06 Kloot Note Edited: 0008926 View Revisions
2012-07-08 14:12 zerver Note Added: 0008927
2012-07-08 19:06 Deadnight Warrior Note Added: 0008929
2012-07-09 00:13 Kloot Note Added: 0008934
2012-07-09 00:13 Kloot Status assigned => resolved
2012-07-09 00:13 Kloot Fixed in Version => 89.0
2012-07-09 00:13 Kloot Resolution reopened => no change required
+Issue History