0003046: cloakCostMoving no longer defaults to cloakCost - MantisBT

MantisBT

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0003046

Spring engine

Unit Scripting

public

2012-04-01 12:00

2012-07-19 14:22

Reporter

FLOZi

Assigned To

Kloot

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Product Version

89.0

Target Version

Fixed in Version

89.0.1+git

Summary

0003046: cloakCostMoving no longer defaults to cloakCost

Description

Due to:

! make the default cloakCost* values 0 instead of -1,
! added new "canCloak" bool tag (If an unit can receive user cloak commands. Before, canCloak was auto set to true if cloakCost >= 0.)

https://github.com/spring/spring/blob/master/rts/Sim/Units/UnitDef.cpp#L439 [^]

Seems to me it should just default 'normally' now without the need for the if.

Tags

No tags attached.

Relationships

Notes
(0008749) FLOZi (reporter) 2012-06-09 20:05	Still present in develop: https://github.com/spring/spring/blob/develop/rts/Sim/Units/UnitDef.cpp#L439 [^]

(0009044) FLOZi (reporter) 2012-07-17 16:22	Now both default to 0 without any funky additions, but IMO cloakCostMoving should default to cloakCost.

Issue History
Date Modified	Username	Field	Change
2012-04-01 12:00	FLOZi	New Issue
2012-06-09 20:05	FLOZi	Note Added: 0008749
2012-06-09 23:35	Kloot	Status	new => resolved
2012-06-09 23:35	Kloot	Fixed in Version	=> 89.0
2012-06-09 23:35	Kloot	Resolution	open => fixed
2012-06-09 23:35	Kloot	Assigned To	=> Kloot
2012-07-17 16:22	FLOZi	Note Added: 0009044
2012-07-17 16:22	FLOZi	Status	resolved => feedback
2012-07-17 16:22	FLOZi	Resolution	fixed => reopened
2012-07-19 14:22	Kloot	Status	feedback => resolved
2012-07-19 14:22	Kloot	Fixed in Version	89.0 => 89.0.1+git
2012-07-19 14:22	Kloot	Resolution	reopened => fixed

Copyright © 2000 - 2013 MantisBT Team