0002658: console and infolog broken

(0007391)
hoijui (administrator)
2011-09-22 10:23

for commands, it is this line:
https://github.com/spring/spring/blob/develop/rts/Game/UnsyncedGameCommands.cpp#L142 [^]
changing it from DEBUG to the default level would make the raw chat command appear again. is that required for non-engine handled chat commands?
i guess i made it this way cause it still prints out the command in in other form.

as for chat, i don't know what the problem is that you refer to. i get chat just fine.
1. [enter]
2. "bla"
3. [enter]
-> "bla" appears in the in-game chat window

(0007393)
Google_Frog (reporter)
2011-09-22 12:15

Debug is still good to show. It makes the infolog useful, games should implement their own chat box to hide these things if they want.

(0007394)
hoijui (administrator)
2011-09-22 17:39

could you please answer my questions?

(0007395)
Google_Frog (reporter)
2011-09-22 17:51

Give me about 15 hours for me to have enough time to go through starting spring and testing.

(0007396)
hoijui (administrator)
2011-09-22 22:13

This post has a quote and the text "First off. 15 minute game, this is my ENTIRE infolog:":
http://springrts.com/phpbb/viewtopic.php?p=501153&sid=80df6e64049dedd4945f1bb44de3fea1#p501153 [^]
that helped me some...

it seems like this problem only appears on windows.
As of now, it looks like the problem is, that LOG_SECTION_CURRENT is not set to "" by default, but rather to NULL (or unset).
How this is possible, i have no idea though. Maybe pre-processor stuff works different in mingw.

see:
rts/System/Log/Section.h
rts/System/Log/ILog.h

(0007405)
hoijui (administrator)
2011-09-25 11:22

MinGW does not merge constants as does GCC on linux. :/
FUCKER!

fixed with:
https://github.com/spring/spring/commit/1425c8e48050b39c3c2c30204d57a84a5f8e2ade [^]

Issue History
Date Modified	Username	Field	Change
2011-09-20 08:18	Google_Frog	New Issue
2011-09-22 10:23	hoijui	Note Added: 0007391
2011-09-22 10:27	hoijui	Status	new => assigned
2011-09-22 10:27	hoijui	Assigned To	=> hoijui
2011-09-22 12:15	Google_Frog	Note Added: 0007393
2011-09-22 17:39	hoijui	Note Added: 0007394
2011-09-22 17:51	Google_Frog	Note Added: 0007395
2011-09-22 22:13	hoijui	Note Added: 0007396
2011-09-25 11:22	hoijui	Note Added: 0007405
2011-09-25 11:22	hoijui	Status	assigned => resolved
2011-09-25 11:22	hoijui	Resolution	open => fixed

Notes
(0007391) hoijui (administrator) 2011-09-22 10:23	for commands, it is this line: https://github.com/spring/spring/blob/develop/rts/Game/UnsyncedGameCommands.cpp#L142 [^] changing it from DEBUG to the default level would make the raw chat command appear again. is that required for non-engine handled chat commands? i guess i made it this way cause it still prints out the command in in other form. as for chat, i don't know what the problem is that you refer to. i get chat just fine. 1. [enter] 2. "bla" 3. [enter] -> "bla" appears in the in-game chat window

(0007393) Google_Frog (reporter) 2011-09-22 12:15	Debug is still good to show. It makes the infolog useful, games should implement their own chat box to hide these things if they want.

(0007394) hoijui (administrator) 2011-09-22 17:39	could you please answer my questions?

(0007395) Google_Frog (reporter) 2011-09-22 17:51	Give me about 15 hours for me to have enough time to go through starting spring and testing.

(0007396) hoijui (administrator) 2011-09-22 22:13	This post has a quote and the text "First off. 15 minute game, this is my ENTIRE infolog:": http://springrts.com/phpbb/viewtopic.php?p=501153&sid=80df6e64049dedd4945f1bb44de3fea1#p501153 [^] that helped me some... it seems like this problem only appears on windows. As of now, it looks like the problem is, that LOG_SECTION_CURRENT is not set to "" by default, but rather to NULL (or unset). How this is possible, i have no idea though. Maybe pre-processor stuff works different in mingw. see: rts/System/Log/Section.h rts/System/Log/ILog.h

(0007405) hoijui (administrator) 2011-09-25 11:22	MinGW does not merge constants as does GCC on linux. :/ FUCKER! fixed with: https://github.com/spring/spring/commit/1425c8e48050b39c3c2c30204d57a84a5f8e2ade [^]

Relationships