View Issue Details

IDProjectCategoryView StatusLast Update
0001985Spring engineGeneralpublic2010-07-17 11:58
Reportersmoth Assigned ToKloot  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.81.2+git 
Fixed in Version0.81.0.0+git 
Summary0001985: Shadow mode 2 now broken.
DescriptionShadow mode 2 now works as shadow mode 1

Additional InformationSometime after build: 0.81.2.1-1270-ga29f85f
happens for sure at build: 0.81.2.1-1271-ga9d0e26
TagsNo tags attached.
Attached Files
shadows1-c8caf3a37c32c2bc579a60abfb7d6f18d990b8c8.png (Attachment missing)
shadows2-c8caf3a37c32c2bc579a60abfb7d6f18d990b8c8.png (Attachment missing)
currentreleasesh1.png (Attachment missing)
currentreleasesh2.png (Attachment missing)
0.81.2.1-1282-g3d976f5_sh1.png (Attachment missing)
0.81.2.1-1282-g3d976f5_sh2.png (Attachment missing)
UnitShadows-f1f3876ef9a24e67bd90f432d9e54c8b364e7ba6.png (Attachment missing)
Checked infolog.txt for Errors

Activities

smoth

2010-07-15 04:29

reporter   ~0005100

Correction
Sometime after build: 0.81.2.1-1271-ga9d0e26
happens for sure at build: 0.81.2.1-1282-g3d976f5

Kloot

2010-07-15 11:18

developer   ~0005101

Last edited: 2010-07-15 11:29

Seems to be nothing wrong with it (see shadows*.png)?

smoth

2010-07-15 20:20

reporter   ~0005103

you are not looking at feature shadows.

Kloot

2010-07-15 21:24

developer   ~0005104

Last edited: 2010-07-15 21:24

Ah, now this makes sense. But your report is still misleading:

In mode 1, (3D) trees and terrain should both cast shadows.
In mode 2, terrain should not cast any shadows, but trees should.

However, in the current release build, trees actually cast shadows *just for their stalks* when in mode 2 (a bug), but look fine in mode 1. In git-master builds, trees cast shadows *just for their stalks* in modes 2 AND 1 (another bug). Therefore it is mode 1 that got broken, not 2.

Kloot

2010-07-15 21:51

developer   ~0005105

fixed (both modes)

smoth

2010-07-16 17:15

reporter   ~0005107

Shadow mode 1 still broken

Try beheriths map moor. http://springrts.com/phpbb/viewtopic.php?f=13&t=23411

notice the pinetrees only have shadows for their trunks.

Kloot

2010-07-17 11:57

developer   ~0005114

Fixed.

For my own reference: unit shadows are also broken again as a result of http://github.com/spring/spring/commit/1680b6d12d94ef67c5ecaeb763993730f81a5617 (cf UnitShadows-f1f3876ef9a24e67bd90f432d9e54c8b364e7ba6.png).

Issue History

Date Modified Username Field Change
2010-07-15 04:16 smoth New Issue
2010-07-15 04:29 smoth Note Added: 0005100
2010-07-15 11:17 Kloot File Added: shadows1-c8caf3a37c32c2bc579a60abfb7d6f18d990b8c8.png
2010-07-15 11:18 Kloot File Added: shadows2-c8caf3a37c32c2bc579a60abfb7d6f18d990b8c8.png
2010-07-15 11:18 Kloot Note Added: 0005101
2010-07-15 11:29 Kloot Note Edited: 0005101
2010-07-15 20:14 smoth File Added: currentreleasesh1.png
2010-07-15 20:15 smoth File Added: currentreleasesh2.png
2010-07-15 20:19 smoth File Added: 0.81.2.1-1282-g3d976f5_sh1.png
2010-07-15 20:20 smoth File Added: 0.81.2.1-1282-g3d976f5_sh2.png
2010-07-15 20:20 smoth Note Added: 0005103
2010-07-15 21:24 Kloot Note Added: 0005104
2010-07-15 21:24 Kloot Note Edited: 0005104
2010-07-15 21:51 Kloot Note Added: 0005105
2010-07-15 21:51 Kloot Status new => resolved
2010-07-15 21:51 Kloot Fixed in Version => 0.81.0.0+git
2010-07-15 21:51 Kloot Resolution open => fixed
2010-07-15 21:51 Kloot Assigned To => Kloot
2010-07-16 17:15 smoth Note Added: 0005107
2010-07-16 17:15 smoth Status resolved => assigned
2010-07-16 17:15 smoth Resolution fixed => reopened
2010-07-17 11:57 Kloot Note Added: 0005114
2010-07-17 11:58 Kloot File Added: UnitShadows-f1f3876ef9a24e67bd90f432d9e54c8b364e7ba6.png
2010-07-17 11:58 Kloot Status assigned => resolved
2010-07-17 11:58 Kloot Resolution reopened => fixed