| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0001225 | Spring engine | General | public | 2008-12-18 02:35 | 2018-02-17 12:24 | ||||
| Reporter | el_matarife | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | tweak | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.77b5 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0001225: Weapon range rings height issue | ||||||||
| Description | 1. placement view range ring is wrong for laser weapons on hills 2. range for the defense range widget is wrong for both plasma weapons and laser weapons on hills The only way to find out the "true" range of a static emplacement on a hill is the range ring you get when attacking. | ||||||||
| Additional Information | I suspect that both Defense Range widget and the placement view are using the wrong range primitive, the cylinder instead of the sphere or something like that. I reported the defense range portion of the bug since I believe defense range widget just displays what Spring reports the range as but I could be wrong. I'll link very_bad_soldier to this bug entry so he can take a look at it from his end. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
el_matarife (reporter) 2009-01-14 22:41 |
Forgot to update this with very_bad_soldier's explanation of the ranges in his widget being off: http://spring.clan-sy.com/phpbb/viewtopic.php?p=322746#p322746 The Spring engine portion of this bug is still unexplained. |
|
imbaczek (reporter) 2009-01-14 23:12 Last edited: 2009-01-14 23:12 |
i know there are several range-circle-drawing functions; the correct (as in, precise) one is only called when the unit actually exists (so it can correctly query the unit's weapon.) fixing would require some clever hackery or equally clever refactoring. |
|
Google_Frog (reporter) 2018-01-28 14:01 |
This still seems to be an issue. |
|
Kloot (developer) 2018-01-30 00:32 |
Fix 2a88f642b9a726590b8f53b5539c296da0695116 committed to develop branch: fix 0001225, repo: spring changeset id: 9517 |
|
Kloot (developer) 2018-02-17 12:24 |
Fix 36d3fede45ed916fce0fd97374e4ee41116b0677 committed to maintenance branch: fix 0001225 Conflicts: rts/Game/UI/GuiHandler.cpp rts/Lua/LuaOpenGL.cpp rts/Rendering/GL/glExtra.cpp rts/Rendering/GL/glExtra.h, repo: spring changeset id: 9672 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-12-18 02:35 | el_matarife | New Issue | |
| 2009-01-14 22:41 | el_matarife | Note Added: 0003168 | |
| 2009-01-14 23:12 | imbaczek | Note Added: 0003170 | |
| 2009-01-14 23:12 | imbaczek | Note Edited: 0003170 | |
| 2018-01-28 14:01 | Google_Frog | Note Added: 0018757 | |
| 2018-01-29 20:20 | Kloot | Assigned To | => Kloot |
| 2018-01-29 20:20 | Kloot | Status | new => assigned |
| 2018-01-30 00:32 | Kloot | Changeset attached | => spring develop 2a88f642 |
| 2018-01-30 00:32 | Kloot | Note Added: 0018760 | |
| 2018-01-30 00:32 | Kloot | Status | assigned => resolved |
| 2018-01-30 00:32 | Kloot | Resolution | open => fixed |
| 2018-02-17 12:24 | Kloot | Changeset attached | => spring maintenance 36d3fede |
| 2018-02-17 12:24 | Kloot | Note Added: 0018815 | |
| Issue History |