[DONE] Upgrade buildGit to handle submodules

[DONE] Upgrade buildGit to handle submodules

A place for offers of Bounties and discussion of funded proposals.
Post Reply
User avatar
PepeAmpere
Posts: 578
Joined: 03 Jun 2010, 01:28

[DONE] Upgrade buildGit to handle submodules

Post by PepeAmpere » 19 Feb 2018, 13:29

If I commit new revision of Spring 1944 which contains git submodules, rapid buildGit fails (http://s44.repo.springrts.com/log.txt), because the submodules are not supported. Based on observation of the code and discussion with abma, the change does not need to be hard to achieve. Sadly I have not touched C++ for many years so I wont be able to do the upgrade on my own. Also the implementation is not referring to standard git api which is the only thing I can potentially handle.

Acceptance criteria
  • rapid is able to distribute games using submodules (which may mean upgrading the buildGit)

Technical tips and usefull links

----

1. read `.submodules` and parse all submodules and their source and paths
2. one by one for each submodule:

* go on path and read `.gitmodule`, parse commit
* get submodule data from source specificing commit
* store data in path next to .gitmodule

----

Original ticket: https://trello.com/c/2Non5Mbx/
related to similar tech done for https://trello.com/c/8yoUDzHj/

Bounty: $ 200 (can be discussed if you convince me it is more/less complex)
3 x

abma
Spring Developer
Posts: 3495
Joined: 01 Jun 2009, 00:08

Re: Upgrade buildGit to handle submodules

Post by abma » 19 Feb 2018, 17:53

maybe some more info:

https://github.com/spring/RapidTools/is ... t-85143282

atm it fails with "git_blob_lookup [-3] - Object not found - failed to find pack entry ..."

i.e. http://s44.repo.springrts.com/log.txt
1 x

User avatar
PepeAmpere
Posts: 578
Joined: 03 Jun 2010, 01:28

Re: Upgrade buildGit to handle submodules

Post by PepeAmpere » 25 Feb 2018, 14:53

turboss offered to implement the feature until the end of this week. I do not have direct contact on him, so we wait now. I look forward to have it done as soon it is possible :) Our bounty offer is still valid, even if it takes more time.

turboss, if there are some technical issues or we can somehow help you to find time for the implementation, contact me here or directly on my e-mail: machys@gmail.com

thx
1 x

hokomoko
Spring Developer
Posts: 533
Joined: 02 Jun 2014, 00:46

Re: Upgrade buildGit to handle submodules

Post by hokomoko » 01 Mar 2018, 19:57

¡Hola!
I was working here with TurBoss and we think we have it working.
Before deploying it could be nice if someone else could take a look (commits are in the repository)
1 x

abma
Spring Developer
Posts: 3495
Joined: 01 Jun 2009, 00:08

Re: Upgrade buildGit to handle submodules

Post by abma » 01 Mar 2018, 22:02

seems to work! :-) :-)
/forceupdate.sh
21171 (process ID) old priority 0, new priority 19
Updateing /home/packages/git/s44
Already up-to-date.
Already on 'master'
Your branch is up-to-date with 'origin/master'.
HEAD is now at 1e3ba6f Merge pull request #274 from sanguinariojoe/cleaning
/home/packages/bin/BuildGit /home/packages/git/s44 / modinfo.lua /home/packages/www/s44 1e3ba6f9624df9e1fc07391396980495ddec9dce s44
Performing incremental update: 16e4f8815d376ea1b11871a82a7ba736431c35b2...1e3ba6f9624df9e1fc07391396980495ddec9dce
[...]
possible i need to adjust the script which checks for updates of the git repo, but thats IMHO minor.


@PepeAmpere: can you please check if s44:test works for you, too?

also would be interesting if it works as expected when updating the git repo, see http://s44.repo.springrts.com/log.txt after a commit.
4 x

User avatar
PepeAmpere
Posts: 578
Joined: 03 Jun 2010, 01:28

Re: Upgrade buildGit to handle submodules

Post by PepeAmpere » 02 Mar 2018, 19:02

abma wrote:seems to work! :-) :-)

@PepeAmpere: can you please check if s44:test works for you, too?

also would be interesting if it works as expected when updating the git repo, see http://s44.repo.springrts.com/log.txt after a commit.
I would like to test it but I have no rights to trigger new rapid version build. (Or I dont know how to do that)

http://s44.repo.springrts.com/log.txt is still showing error in last line.

Any hints? Shall I commit something? :-)
1 x

User avatar
PepeAmpere
Posts: 578
Joined: 03 Jun 2010, 01:28

Re: Upgrade buildGit to handle submodules

Post by PepeAmpere » 02 Mar 2018, 21:15

Looks like it works.

Thank you all participating people.

I heard that hokomoko did that main part and he would like to use the bounty for the community. Please confirm it in this thread and I will send the money after that.
1 x

hokomoko
Spring Developer
Posts: 533
Joined: 02 Jun 2014, 00:46

Re: Upgrade buildGit to handle submodules

Post by hokomoko » 02 Mar 2018, 23:58

Indeed, TurBoss and I both want this to go into spring. I'm not sure how we can hold funds due spring at the moment, maybe abma can help. Otherwise, you may have to hold onto the money until we find a use XD.
2 x

User avatar
PepeAmpere
Posts: 578
Joined: 03 Jun 2010, 01:28

Re: Upgrade buildGit to handle submodules

Post by PepeAmpere » 04 Mar 2018, 11:49

I thought there is some paypal account similar to Licho's one in the old times.

Ok, I guess some people are running servers for the shared infrastructure. I guess I could send money them. Maybe its not good general solution but for this time it may be ok. What do you think?
1 x

User avatar
Silentwings
Moderator
Posts: 3450
Joined: 25 Oct 2008, 00:23

Re: Upgrade buildGit to handle submodules

Post by Silentwings » 04 Mar 2018, 15:38

There are the bitcoin wallets viewtopic.php?f=86&t=32878&p=564309#p564309

I suggest pm'ing Kloot to check if they are still active.
1 x

abma
Spring Developer
Posts: 3495
Joined: 01 Jun 2009, 00:08

Re: Upgrade buildGit to handle submodules

Post by abma » 06 Mar 2018, 00:17

Some wish:

Since 2014.11.5 server basicly is unpaid :?

https://springrts.com/wiki/Donations#Server%20costs

thoughts about this?
1 x

User avatar
PepeAmpere
Posts: 578
Joined: 03 Jun 2010, 01:28

Re: Upgrade buildGit to handle submodules

Post by PepeAmpere » 06 Mar 2018, 18:02

abma wrote:Some wish:

Since 2014.11.5 server basicly is unpaid :?

https://springrts.com/wiki/Donations#Server%20costs

thoughts about this?
Yes I meant exactly something like this. Just I do not have any crypto-currency account - so I would suggest old-world currency transfer via PayPal. Esp. with bitcoins it is not clear what value I should send you due its current volatility.
4 x

abma
Spring Developer
Posts: 3495
Joined: 01 Jun 2009, 00:08

Re: Upgrade buildGit to handle submodules

Post by abma » 11 Mar 2018, 22:56

ok, seems that this is fine.

dansan / PepeAmpere please contact each other for details. dansan has a paypal account, too. so this should be no issue.
1 x

dansan
Server Owner & Developer
Posts: 1162
Joined: 29 May 2010, 23:40

Re: Upgrade buildGit to handle submodules

Post by dansan » 12 Mar 2018, 08:19

Wow - cool! I have sent PepeAmpere my PayPal accounts name, so he can send money there. Thanks a lot for the donation!
1 x

User avatar
PepeAmpere
Posts: 578
Joined: 03 Jun 2010, 01:28

Re: Upgrade buildGit to handle submodules

Post by PepeAmpere » 13 Mar 2018, 23:10

dansan wrote:I have sent PepeAmpere my PayPal accounts name...
Payed on dansan's PayPal account.

200$ => 161 EUR
I payed the fee.
submodulesBounty.jpg
You do not have the required permissions to view the files attached to this post.
4 x

dansan
Server Owner & Developer
Posts: 1162
Joined: 29 May 2010, 23:40

Re: Upgrade buildGit to handle submodules

Post by dansan » 14 Mar 2018, 08:22

I received it - thx!
Selection_170.png
You do not have the required permissions to view the files attached to this post.
1 x

abma
Spring Developer
Posts: 3495
Joined: 01 Jun 2009, 00:08

Re: [DONE] Upgrade buildGit to handle submodules

Post by abma » 16 Mar 2018, 10:06

Several projects profit from this new feature, also thanks a lot for the Donation for the server! :-)

I've updated the donations page.
2 x

Post Reply

Return to “Bounty Offers”