how to fix demotool?

how to fix demotool?

Discussion between Spring developers.
Post Reply
abma
Spring Developer
Posts: 3540
Joined: 01 Jun 2009, 00:08

how to fix demotool?

Post by abma » 23 Nov 2012, 02:54

demotool currently is broken, because the filehandler requires the whole filesystem & logging.

any ideas how to cleanly fix it?

imo adding ifdefs to filehandler would be the dirty way...


i would suggest to add an interface like:

Code: Select all

class IFile {
  Open()
  Close()
  Read()
  Write()
  Seek()
  GetPos()
  Eof()
}
This interface is then used for all file accesses (gzip, raw)

The DemoRecorder has to be changed to:

DemoRecorder(IFile* demofile, ...)

This way the demotool then just would depend on one class (CFile).

Thoughts?
0 x

User avatar
jK
Spring Developer
Posts: 2299
Joined: 28 Jun 2007, 07:30

Re: how to fix demotool?

Post by jK » 23 Nov 2012, 07:28

that explains why it didn't used CFileHandler >_<
need to think about for a while.
0 x

Post Reply

Return to “Dedicated Developer Discussion”