deprecate .tif support?

deprecate .tif support?

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

Post Reply
abma
Spring Developer
Posts: 3560
Joined: 01 Jun 2009, 00:08

deprecate .tif support?

Post by abma » 24 Oct 2019, 15:13

because of https://springrts.com/mantis/view.php?id=6321 the question raises: is tiff support needed at all?

if not it could be deprecated: when a tiff file is loaded a warning message is shown in log and at some point tiff support could be removed.
0 x

User avatar
FLOZi
MC: Legacy & Spring 1944 Developer
Posts: 6109
Joined: 29 Apr 2005, 01:14

Re: deprecate .tif support?

Post by FLOZi » 24 Oct 2019, 18:16

Looks like the issue is caused by a feature imported from ad0...

There will be hundreds of such features used in dozens of maps.


So the answer to your question is the answer to the question "Do you want to make all of such maps unplayable?".
1 x

User avatar
ivand
Posts: 134
Joined: 27 Jun 2007, 17:05

Re: deprecate .tif support?

Post by ivand » 24 Oct 2019, 20:29

Some great maps (Ravaged v2) and assets (some tree types) depend on TIF textures.

Someone need to update the assets first.

If this is started perhaps we could convert all assets to DDS and deprecate other formats when the time comes.
0 x

hokomoko
Spring Developer
Posts: 585
Joined: 02 Jun 2014, 00:46

Re: deprecate .tif support?

Post by hokomoko » 24 Oct 2019, 21:12

It wasn't a big hassle to compile with libtiff, I was just surprised that it is used.
Probably far less effort than updating maps, so I don't think it should be deprecated.
2 x

User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14605
Joined: 17 Nov 2005, 02:43

Re: deprecate .tif support?

Post by Forboding Angel » 25 Oct 2019, 08:44

It's almost as if someone made a giant feature archive in the realization that things like this happen so that it could be fixed in a single place instead of hundreds of places, yet very few were farsighted enough to see the potential problems that this method fixed. :roll:
0 x

User avatar
PicassoCT
Journeywar Developer & Mapper
Posts: 10238
Joined: 24 Jan 2006, 21:12

Re: deprecate .tif support?

Post by PicassoCT » 25 Oct 2019, 11:30

Fortolding you soo angle
1 x

User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14605
Joined: 17 Nov 2005, 02:43

Re: deprecate .tif support?

Post by Forboding Angel » 25 Oct 2019, 23:56

:mrgreen:
0 x

raaar
Metal Factions Developer
Posts: 817
Joined: 20 Feb 2010, 12:17

Re: deprecate .tif support?

Post by raaar » 26 Oct 2019, 00:44

having a single feature archive would have made fixing this easier, but lobbies had trouble handling dependencies (they wouldn't sort them automatically) and a safe way to tune the features to each map is include them in and tweak them instead of using the package.

Imo we should avoid breaking backwards compatibility. Don't deprecate .tif support.
0 x

User avatar
Silentwings
Moderator
Posts: 3593
Joined: 25 Oct 2008, 00:23

Re: deprecate .tif support?

Post by Silentwings » 26 Oct 2019, 07:33

Seems to me that there was only some minor confusion here & no actual problem needs solving.
0 x

User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14605
Joined: 17 Nov 2005, 02:43

Re: deprecate .tif support?

Post by Forboding Angel » 27 Oct 2019, 11:04

raaar wrote:
26 Oct 2019, 00:44
having a single feature archive would have made fixing this easier, but lobbies had trouble handling dependencies (they wouldn't sort them automatically) and a safe way to tune the features to each map is include them in and tweak them instead of using the package.

Imo we should avoid breaking backwards compatibility. Don't deprecate .tif support.
The lobbies handle them just fine if the game calls it as a dependency. And all you have to do to "Tune" the features is to include the featuredef in your map. It then overrides the package. Then on a per map basis you can have whatever settings you like for that feature.
0 x

User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14605
Joined: 17 Nov 2005, 02:43

Re: deprecate .tif support?

Post by Forboding Angel » 27 Oct 2019, 11:04

raaar wrote:
26 Oct 2019, 00:44
having a single feature archive would have made fixing this easier, but lobbies had trouble handling dependencies (they wouldn't sort them automatically) and a safe way to tune the features to each map is include them in and tweak them instead of using the package.

Imo we should avoid breaking backwards compatibility. Don't deprecate .tif support.
The lobbies handle them just fine if the game calls it as a dependency. And all you have to do to "Tune" the features is to include the featuredef in your map. It then overrides the package. Then on a per map basis you can have whatever settings you like for that feature.

And no, please don't deprecate tif support. That would have a lot more irritating consequences than just maps being broken.
0 x

Post Reply

Return to “Engine”