Changes to forum layout / startpage

Changes to forum layout / startpage

Various things about Spring that do not fit in any of the other forums listed below, including forum rules.

Moderator: Moderators

abma
Spring Developer
Posts: 3555
Joined: 01 Jun 2009, 00:08

Changes to forum layout / startpage

Post by abma » 09 May 2015, 02:36

Forb slightly adjusted the forum layout so it works better on mobiles.
http://test.springrts.com/phpbb/posting ... e=post&f=1

most visible change are the buttons, see thepull request

also i've merged community news and engine news:

http://test.springrts.com/

https://github.com/spring/spring-websit ... 8c7e119b7f

Thoughts about this?
0 x

gajop
Moderator
Posts: 3023
Joined: 05 Aug 2009, 20:42

Re: Changes to forum layout / startpage

Post by gajop » 09 May 2015, 07:37

abma wrote:also i've merged community news and engine news:
http://test.springrts.com/
This is a good change. Later on you may consider modifying the way it displays "game:", "engine:", and general news (maybe some color information, icons or similar), but this is already a step in the right direction.
Hm, is there no way to view older news?
0 x

abma
Spring Developer
Posts: 3555
Joined: 01 Jun 2009, 00:08

Re: Changes to forum layout / startpage

Post by abma » 10 May 2015, 01:26

ok, applied / updated to phpbb 3.1.4
0 x

abma
Spring Developer
Posts: 3555
Joined: 01 Jun 2009, 00:08

Re: Changes to forum layout / startpage

Post by abma » 10 May 2015, 01:29

Later on you may consider modifying the way it displays "game:", "engine:", and general news (maybe some color information, icons or similar), but this is already a step in the right direction.
Hm, is there no way to view older news?
replacing categories with icons is on the todo. atm you can only view older news by visiting the forum...
0 x

User avatar
Anarchid
Posts: 1380
Joined: 30 Nov 2008, 04:31

Re: Changes to forum layout / startpage

Post by Anarchid » 11 May 2015, 15:55

The new buttons and links styles are abhorrent on aesthetical, practical, and technological grounds.

They make text harder to read, irritate 99% of respondents, and overrides.txt opened in an IDE is now as red as communism, as red as blood, as red as mars - due to nearly EVERY SINGLE LINEbeing !important.

This is the type of style that fits with epilepsy-inducer flashing gifs, cornify.js, and <MARQUEE> and <BLINK>

I kindly suggest that these changes be reverted by their authors, seeing as cleanly reverting them is no longer possible. Please, just no.
0 x

gajop
Moderator
Posts: 3023
Joined: 05 Aug 2009, 20:42

Re: Changes to forum layout / startpage

Post by gajop » 11 May 2015, 16:51

Also this when searching:
You must specify at least one word to search for. Each word must consist of at least 4 characters and must not contain more than 84 characters excluding wildcards.
I thought we allowed 3 char words (and even 2 char words would make sense to search for)
0 x

User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14601
Joined: 17 Nov 2005, 02:43

Re: Changes to forum layout / startpage

Post by Forboding Angel » 11 May 2015, 20:39

Anarchid wrote:The new buttons and links styles are abhorrent on aesthetical, practical, and technological grounds.

They make text harder to read, irritate 99% of respondents, and overrides.txt opened in an IDE is now as red as communism, as red as blood, as red as mars - due to nearly EVERY SINGLE LINEbeing !important.

This is the type of style that fits with epilepsy-inducer flashing gifs, cornify.js, and <MARQUEE> and <BLINK>

I kindly suggest that these changes be reverted by their authors, seeing as cleanly reverting them is no longer possible. Please, just no.
Editing css in an ide? <confused black girl>
overrides.css wrote:/* 1.0 - Responsive fixes */

/* Important is bad mmmk? Unfortunately a lot of these require it and in this particular case it's not so terrible of a sin, but try not to use important unless you really really have to (says the guy who uses important like it's going out of style below */
It's called "Overrides" for a reason. !important isn't necessary for a chunk of it, but it's 1 part laziness and 1 part dealing with the interesting things that phpbb does with dynamic style generation on certain things. But mainly born out of the desire for it not to be overridden by the parent theme every time they change something.

That said, I will clean it up a bit. It hurts my ocd as well, but phpbb is a very complex (and crappily put together) beast.

https://github.com/spring/spring-website/pull/40

In fact, the links standing out more makes things a lot more readable. I was aware that it might cause some controversy, and the merge stayed on the test server for somewhere around 3 weeks before being made live.

I'm not sure what your deal with the buttons is, as they are far nicer than the default buttons. Additionally they are color matched with the main navigation links. That said, I have to go around and find all the ones not done yet. I have already taken care of pagination on topic lists.
0 x

User avatar
Anarchid
Posts: 1380
Joined: 30 Nov 2008, 04:31

Re: Changes to forum layout / startpage

Post by Anarchid » 11 May 2015, 20:47

It's called "Overrides" for a reason. !important isn't necessary for a chunk of it, but it's 1 part laziness and 1 part dealing with the interesting things that phpbb does with dynamic style generation on certain things. But mainly born out of the desire for it not to be overridden by the parent theme every time they change something.
Grudgingly conceded.
In fact, the links standing out more makes things a lot more readable.
Disagree. They feel like they break out into a whole new dimension, not being part of the text at all. It sure makes spotting links on the page visible, but reading the text which contains links is like blue on red.
0 x

User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14601
Joined: 17 Nov 2005, 02:43

Re: Changes to forum layout / startpage

Post by Forboding Angel » 11 May 2015, 21:04

Anarchid wrote:Disagree. They feel like they break out into a whole new dimension, not being part of the text at all. It sure makes spotting links on the page visible, but reading the text which contains links is like blue on red.
https://github.com/spring/spring-website/pull/40

^^ This pretty much illustrates my point and makes the argument in the best way possible.
0 x

abma
Spring Developer
Posts: 3555
Joined: 01 Jun 2009, 00:08

Re: Changes to forum layout / startpage

Post by abma » 11 May 2015, 21:10

its not possible any more to put some link into readable text. the highlightning is imo totally overkill, a different color for a link is imo enough.
0 x

User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14601
Joined: 17 Nov 2005, 02:43

Re: Changes to forum layout / startpage

Post by Forboding Angel » 11 May 2015, 21:39

Perhaps?

Image
Image
0 x

abma
Spring Developer
Posts: 3555
Joined: 01 Jun 2009, 00:08

Re: Changes to forum layout / startpage

Post by abma » 12 May 2015, 00:40

applied the changes, links shouldn't look this different any more.
0 x

gajop
Moderator
Posts: 3023
Joined: 05 Aug 2009, 20:42

Re: Changes to forum layout / startpage

Post by gajop » 12 May 2015, 01:01

It's indeed a lot less shit now.
Thread numbers are still bad. It's really unclear what's your current page.
0 x

User avatar
AF
AI Developer
Posts: 20669
Joined: 14 Sep 2004, 11:32

Re: Changes to forum layout / startpage

Post by AF » 12 May 2015, 01:56

The dark buttons with the background drop shadow would look better if they used the same background colour ( background-color: rgb(236, 241, 243); ) as the forum itself and had just an outline, and half the border radius/margin

Code: Select all

  color: #000;
  background-color: rgb(236, 241, 243);
  border: 1px solid #aaaaaa !important;
  margin-right: 5px !important;
  border-radius: 5px !important;
The current style is too complex and has such a high contrast with the rest of the theme, I think the buttons and links look a lot nicer with a much simpler style:

Image

Image
Attachments
Screen Shot 2015-05-12 at 00.49.07.png
(59.38 KiB) Not downloaded yet
Screen Shot 2015-05-12 at 00.48.59.png
(26.79 KiB) Not downloaded yet
0 x

User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14601
Joined: 17 Nov 2005, 02:43

Re: Changes to forum layout / startpage

Post by Forboding Angel » 12 May 2015, 04:19

AF wrote:-screenshots-
Ew. Very 1980's mac gui (Awww shizzle simcity ya'll!).

Well phpbb uses 2 classnames for buttons on the forum, and they are interchanged randomly (I'm not kidding), so as a result, both have to match (either that or I do a lot more work than I care for).

Ideally it would be a very google-esque material design call to action. That being that you highlight the buttons that are most important on a page (Like "submit", with save draft and preview being lesser).

But for whatever reason, the bold italics, etc buttons use the exact same class as save draft and preview and submit use a different class.

So yes, I would like to do very neat things with this, but without gutting the phpbb theme (which ain't nobody got time fo dat atm), I am stuck with mostly macro changes. In this case, I decided to make the buttons stand out and obviously responsive to hover.

In a perfect world, I would give the forum a complete makeover using material design guidelines because it makes things very attractive and extremely readable, but this isn't a perfect work and phpbb themes are awful (dude... there is a reason why I am using a file called overrides instead of multiple files like colors, gradients, icons, etc etc).

Look, I am working towards an end goal. It is getting done in stages. At the end of this I will have it in a format that will make the forum super easy to change around to whatever anyone likes. In the meantime, have a little faith, and understand that I already dump a lot of time into this, and that time isn't unlimited, so sometimes an end goal takes a little while to reach.
0 x

User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14601
Joined: 17 Nov 2005, 02:43

Re: Changes to forum layout / startpage

Post by Forboding Angel » 12 May 2015, 04:20

gajop wrote:It's indeed a lot less shit now.
Thread numbers are still bad. It's really unclear what's your current page.
Awww shit, I didn't realize that was live. Yeah it was on my todo... Lemmie go ahead and fix that now.

Edit: https://github.com/spring/spring-website/pull/45

Edit2: Fixed some other crap too cause I happened to notice some stuff.
0 x

User avatar
Anarchid
Posts: 1380
Joined: 30 Nov 2008, 04:31

Re: Changes to forum layout / startpage

Post by Anarchid » 12 May 2015, 14:00

Pagination buttons still seem to stand out ~5mm over the page. It's ok for actual major buttons (submit etc) but not there.
0 x

User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14601
Joined: 17 Nov 2005, 02:43

Re: Changes to forum layout / startpage

Post by Forboding Angel » 12 May 2015, 20:03

Just because it's merged, doesn't mean it's live. The recent merge they are more or less the same size they were before (comparable at least), they are spaced about 2 pixels farther apart though, because it looks better and is easier to read.

Oh NM he hasn't merged it yet. Patience grasshoppa. Something with my fork and a submodule is for some reason messed up. I have no idea wtf, but imma run the commands recommended by abma as soon as I get home and see if that sorts it out.
0 x

User avatar
smoth
Posts: 22298
Joined: 13 Jan 2005, 00:46

Re: Changes to forum layout / startpage

Post by smoth » 12 May 2015, 22:36

I don't know what changed, but I am happy quotes lost that ugly scrollbar.
0 x

abma
Spring Developer
Posts: 3555
Joined: 01 Jun 2009, 00:08

Re: Changes to forum layout / startpage

Post by abma » 13 May 2015, 23:40

merged + applied: needs force-refresh to see the changes, else browser chached files are used.
smoth wrote:I don't know what changed, but I am happy quotes lost that ugly scrollbar.
what scrollbar? there is none on this page...
0 x

Post Reply

Return to “General Discussion”