CRNfix Engine Version: better replay performance

CRNfix Engine Version: better replay performance

Various things about Spring that do not fit in any of the other forums listed below, including forum rules.

Moderator: Moderators

User avatar
Beherith
Moderator
Posts: 4932
Joined: 26 Oct 2007, 16:21

CRNfix Engine Version: better replay performance

Post by Beherith » 24 Jan 2014, 18:25

The bug that has been causing a lot of late game stuttering issues, especially with many players and high CPU loads has been fixed.

The engine build 96.0.1-g382e626 CRNfix is just Spring 96.0 with this patch applied.

There are no other changes to the engine from 96.0, only 3 lines of code got changed.

All [ACE] autohosts already have this engine version as default, and I highly recommend playing large team games on servers which host this engine version.

Thanks to everyone!
Last edited by abma on 04 May 2014, 20:05, edited 1 time in total.
Reason: fix topic
0 x

User avatar
FLOZi
MC: Legacy & Spring 1944 Developer
Posts: 6082
Joined: 29 Apr 2005, 01:14

Re: CNRfix Engine Version: better late game performance

Post by FLOZi » 24 Jan 2014, 18:59

Much wubb to teh Beherith!

Image
0 x

gajop
Moderator
Posts: 3015
Joined: 05 Aug 2009, 20:42

Re: CNRfix Engine Version: better late game performance

Post by gajop » 24 Jan 2014, 21:12

Caldari Navy Raven?
What was actually fixed?
0 x

User avatar
FLOZi
MC: Legacy & Spring 1944 Developer
Posts: 6082
Joined: 29 Apr 2005, 01:14

Re: CNRfix Engine Version: better late game performance

Post by FLOZi » 24 Jan 2014, 21:22

gajop wrote:Caldari Navy Raven?
What was actually fixed?
ClientReadNet

http://springrts.com/mantis/view.php?id=4290

https://github.com/spring/spring/commit ... 898d839a0c
0 x

User avatar
Anarchid
Posts: 1377
Joined: 30 Nov 2008, 04:31

Re: CNRfix Engine Version: better late game performance

Post by Anarchid » 24 Jan 2014, 21:28

Going to test in about an hour.
0 x

gajop
Moderator
Posts: 3015
Joined: 05 Aug 2009, 20:42

Re: CNRfix Engine Version: better late game performance

Post by gajop » 24 Jan 2014, 21:45

Nice behe! Simple fix, however it's impressive how you managed to investigate the cause.
0 x

User avatar
The Yak
Posts: 343
Joined: 20 May 2012, 05:36

Re: CRNfix Engine Version: better late game performance

Post by The Yak » 25 Jan 2014, 15:28

Haven't tested yet but good stuff, thanks behe. Anyone done any benchmarking yet?
0 x

User avatar
smoth
Posts: 22295
Joined: 13 Jan 2005, 00:46

Re: CRNfix Engine Version: better late game performance

Post by smoth » 25 Jan 2014, 16:00

woot, will this make it into 97?
0 x

User avatar
Beherith
Moderator
Posts: 4932
Joined: 26 Oct 2007, 16:21

Re: CRNfix Engine Version: better late game performance

Post by Beherith » 27 Jan 2014, 11:46

My apologies to everyone involved, but it turns out I made a mistake while debugging, and this fix only affects stutter issues while watching replays :(
0 x

User avatar
Silentwings
Moderator
Posts: 3565
Joined: 25 Oct 2008, 00:23

Re: CRNfix Engine Version: better late game performance

Post by Silentwings » 27 Jan 2014, 14:46

Meh, it happens ;) Still a good catch.
0 x

User avatar
smoth
Posts: 22295
Joined: 13 Jan 2005, 00:46

Re: CRNfix Engine Version: better late game performance

Post by smoth » 27 Jan 2014, 14:51

IIRC aren't replays used in the comparisons of the violation and the spring engine? So it is possible this could rectify much of the bullshit frequently bantered around here.

Either way, it is a fix, I will happily take it behe! Does this effect the resume of a match when you have a crash/got booted or no idea if it would effect resuming a match?
Last edited by smoth on 27 Jan 2014, 23:49, edited 1 time in total.
0 x

User avatar
scifi
Posts: 848
Joined: 10 May 2009, 12:27

Re: CRNfix Engine Version: better late game performance

Post by scifi » 27 Jan 2014, 15:29

IIRC aren't replays used in the comparisons of the violation and the spring engine? So it is possible this could rectify much of the ignorant stuff frequently bantered around here.
I would guess.

However this just proves that replays shouldnt be used to test engine performance.

Behe its a fix and we will take it, no worries :wink:
0 x

User avatar
smoth
Posts: 22295
Joined: 13 Jan 2005, 00:46

Re: CRNfix Engine Version: better late game performance

Post by smoth » 27 Jan 2014, 15:38

I 100% agree scifi. That is NOT a good test but people were using it all the same.
0 x

User avatar
FabriceFABS
Posts: 342
Joined: 28 Jul 2010, 16:20

Re: CRNfix Engine Version: better late game performance

Post by FabriceFABS » 27 Jan 2014, 19:33

OK np, really ! 8)
0 x

klapmongool
Posts: 843
Joined: 13 Aug 2007, 13:19

Re: CRNfix Engine Version: better late game performance

Post by klapmongool » 27 Jan 2014, 20:32

Thx for trying behe!
0 x

zer_ver
Posts: 19
Joined: 14 Nov 2013, 17:34

Re: CRNfix Engine Version: better late game performance

Post by zer_ver » 27 Jan 2014, 23:45

Replays are useful for benchmarking if and only if they are correctly designed for the task and the engines being compared are similar enough.

Smoth: This CRNfix is nice but does not affect any benchmarking results. Stutter and simulation speed are not even related. I'd recommend you to be more careful in using the word ignorance around here.
0 x

User avatar
smoth
Posts: 22295
Joined: 13 Jan 2005, 00:46

Re: CRNfix Engine Version: better late game performance

Post by smoth » 27 Jan 2014, 23:48

ok. hang on while I edit my post.
0 x

User avatar
Beherith
Moderator
Posts: 4932
Joined: 26 Oct 2007, 16:21

Re: CRNfix Engine Version: better late game performance

Post by Beherith » 28 Jan 2014, 17:35

zer_ver wrote:Replays are useful for benchmarking if and only if they are correctly designed for the task and the engines being compared are similar enough.

Smoth: This CRNfix is nice but does not affect any benchmarking results. Stutter and simulation speed are not even related. I'd recommend you to be more careful in using the word ignorance around here.
Except that in this case it was relevant. Because each netmsg_synccheck forced an extra draw frame, thereby taking away time from doing sim frames.
0 x

zer_ver
Posts: 19
Joined: 14 Nov 2013, 17:34

Re: CRNfix Engine Version: better late game performance

Post by zer_ver » 28 Jan 2014, 18:40

Yeah, less than 2 fps per second, but it does not count as Sim time so none of my benchmarks would be affected. Also, MT engine would not gain anything from this fix.
0 x

User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14550
Joined: 17 Nov 2005, 02:43

Re: CRNfix Engine Version: better late game performance

Post by Forboding Angel » 29 Jan 2014, 01:02

Why don't you just release your source and stop this silly shit?
0 x

Post Reply

Return to “General Discussion”