View topic - Spring site testing


All times are UTC + 1 hour


Post new topic Reply to topic  [ 60 posts ]  Go to page 1, 2, 3  Next
Author Message
 Post subject: Spring site testing
PostPosted: 04 Jan 2012, 09:16 
AI Coder
User avatar

Joined: 14 Sep 2004, 10:32
Location: Cookieland
Can we have better testing by those making commits?

Over christmas we had a rather glaring bug resulting from improper inclusion of the red background on the wrong div, leading to giant blue stripes across the bottom of the page when the forum wasnt tall enough to fill the window.

Right now someone has added a css3 drop shadow, which fails spectacularly in the main menu ( the drop shadow starts far too low leaving a double rounded corner, and when you resize the window below the maximum width, the drop shadow persists despite media queries putting the bar full width ).
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 08 Jan 2012, 13:05 
Spring Developer

Joined: 31 May 2009, 23:08
AF wrote:
Can we have better testing by those making commits?


uhm... how to test more?

if you interested in changes, follow the changes on the git-repo: https://github.com/spring/spring-website (there is a rss feed)

current "tests" are: it works / it works not.
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 08 Jan 2012, 15:06 
Tournaments Moderator
User avatar

Joined: 08 Dec 2007, 17:39
Location: UK - England
AF wrote:
Over christmas we had a rather glaring bug resulting from improper inclusion of the red background on the wrong div, leading to giant blue stripes across the bottom of the page when the forum wasnt tall enough to fill the window.

Right now someone has added a css3 drop shadow, which fails spectacularly in the main menu ( the drop shadow starts far too low leaving a double rounded corner, and when you resize the window below the maximum width, the drop shadow persists despite media queries putting the bar full width ).


Was gonna mention these things but figured somebody else would eventually :P
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 08 Jan 2012, 22:34 
AI Coder
User avatar

Joined: 14 Sep 2004, 10:32
Location: Cookieland
abma wrote:
AF wrote:
Can we have better testing by those making commits?


uhm... how to test more?

if you interested in changes, follow the changes on the git-repo: https://github.com/spring/spring-website (there is a rss feed)

current "tests" are: it works / it works not.


Clearly it didn't, and in some cases the issues are obvious. What's likely happened is that changes were made to the markup and committed without them being applied to a local test environment to make sure they added/fixed the issue without introducing other issues.

Image

There are similar issues on the footer.

The community news RSS feed addition on the frontpage also has issues, it's pulling in RSS1 not RSS2, and it's only caching for 5 minutes, which is pointless, caching for say 6 or more hours would be better


Attachments:
brokenspring.JPG [17.37 KiB]
Downloaded 2 times
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 10 Jan 2012, 13:10 
Spring Developer
User avatar

Joined: 28 Jun 2007, 06:30
AF wrote:
Over christmas we had a rather glaring bug resulting from improper inclusion of the red background on the wrong div, leading to giant blue stripes across the bottom of the page when the forum wasnt tall enough to fill the window.
You should be happy that someone spends time to make a gift for everyone and created a christmas theme for the website ...

Also you have a wrong idea of the workflow. In contrast to wiki formatting (thx to css extension) only a few ppl have access to update the website (and it's good like this). So you make changes in the css, see that the html itself needs updated - the website code isn't 100% clean, so the sizes of many objects aren't really static or defined with evil hacks instead of simple css-height/width, esp. the header is full of such stuff - and so you make changes to them and commit and wait 3h upto 2days until the website gets updated.
Fact is I don't want ssh access neither do I want to disturb others the whole time to update the website's repo.


Last edited by jK on 10 Jan 2012, 13:35, edited 1 time in total.
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 10 Jan 2012, 13:31 
AI Coder
User avatar

Joined: 14 Sep 2004, 10:32
Location: Cookieland
I managed to update the site, and I don't have access.

If anything it's a good thing that most people don't have access, because working on the live copy is a terrible way of doing things, especially when we have versioned source code.

What I do, and how it should be tested:

  • Fork the github repo
  • Set up a local install using X/W/L/AMP
  • Install the site using the instructions
  • Make your changes
  • Test them in your browsers locally
  • Commit, push
  • Issue a pull request

Nobody, not a single person, should be making any changes to the live site other than git commands. To do otherwise is dangerous and negligent. What's worse is to continually request changes be put live because you didn't test things and had to go back and make yet more changes.
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 11 Jan 2012, 20:00 

Joined: 29 May 2005, 10:18
Location: Eindhoven, Netherlands
You can use http://test.springrts.com/ to test code before it's put live.
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 11 Jan 2012, 20:20 
Spring Developer

Joined: 31 May 2009, 23:08
yeah, thats what i already used for the "works/works not" test... sorry i thought this was clear.
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 08 Feb 2012, 14:36 
Content Developer
User avatar

Joined: 13 Jan 2005, 00:46
glitchy divs on browser resize.
Image


Attachments:
2-8-2012 11-37-09 AM.gif [56.9 KiB]
Downloaded 2 times
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 08 Feb 2012, 15:52 
AI Coder
User avatar

Joined: 14 Sep 2004, 10:32
Location: Cookieland
It is to be noted that in firefox box shadows don't behave quite the same in as in chrome. In chrome they are purely visual, in some versions of firefox it has layout implications.
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 08 Feb 2012, 16:12 
Content Developer
User avatar

Joined: 13 Jan 2005, 00:46
f*ck chrome.
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 08 Feb 2012, 20:06 
AI Coder
User avatar

Joined: 14 Sep 2004, 10:32
Location: Cookieland
It's firefox that got it wrong there, Chrome did it right.

Rather somebody didn't bother to do cross browser testing...
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 08 Feb 2012, 20:27 
Content Developer
User avatar

Joined: 13 Jan 2005, 00:46
pretty much yeah but I wanted to say f*ck chrome all the same.
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 09 Feb 2012, 11:48 
Spring Developer

Joined: 31 May 2009, 23:08
smoth wrote:
glitchy divs on browser resize.


is it better with the latest commit?

see http://test.springrts.com/

(not applied on the main/current site)
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 09 Feb 2012, 12:42 
Spring Developer
User avatar

Joined: 28 Jun 2007, 06:30
abma wrote:
smoth wrote:
glitchy divs on browser resize.


is it better with the latest commit?

see http://test.springrts.com/

(not applied on the main/current site)

Opera: background gradient is broken on start page other pages are fine
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 09 Feb 2012, 13:33 
AI Coder
User avatar

Joined: 14 Sep 2004, 10:32
Location: Cookieland
abma wrote:
smoth wrote:
glitchy divs on browser resize.


is it better with the latest commit?

see http://test.springrts.com/

(not applied on the main/current site)


This fixes the issue of no gap between the main content and the menu in chrome
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 09 Feb 2012, 16:30 
Content Developer
User avatar

Joined: 13 Jan 2005, 00:46
seems fixed to me
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 13 Feb 2012, 18:23 
Content Developer
User avatar

Joined: 13 Jan 2005, 00:46
reporting page dun goofed.
Image


Attachments:
2-13-2012 11-22-47 AM.gif [50.89 KiB]
Downloaded 2 times
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 13 Feb 2012, 18:47 
AI Coder
User avatar

Joined: 14 Sep 2004, 10:32
Location: Cookieland
Code:
select { max-width:500px; }
Top
 Offline Profile  
 
 Post subject: Re: Spring site testing
PostPosted: 13 Feb 2012, 18:48 
Content Developer
User avatar

Joined: 13 Jan 2005, 00:46
- I don't know how to acess spring site to fix.
- I am at work.
Top
 Offline Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 60 posts ]  Go to page 1, 2, 3  Next

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group
Site layout created by Roflcopter et al.