The engine change is not backward compatible.abma wrote:@Forb:
its minor because the change is backwards-compatible. if you fix the "n"'s, it will work in the old engine, too.
However, games can be made forward compatible.
Moderator: Moderators
The engine change is not backward compatible.abma wrote:@Forb:
its minor because the change is backwards-compatible. if you fix the "n"'s, it will work in the old engine, too.
Code: Select all
LuaRules\draw.lua 6 if (not arg) then arg = {...}; arg.n = #arg end
LuaRules\Gadgets\LuaCOB.lua 46 for i = 1, c.n do
LuaRules\Gadgets\lups_flame_jitter.lua 193 particleList.n = particleCnt
LuaRules\Gadgets\unit_morph.lua 486 for i = 2, cmds.n do -- skip the first command (CMD_MORPH)
LuaRules\Gadgets\customunitshaders\unitmaterials\0_angleshark.lua 18 if (info.n ~= curFrame) then
LuaRules\Gadgets\customunitshaders\unitmaterials\0_angleshark.lua 19 info.n = curFrame;
LuaRules\utilities\json.lua 342 -- We consider any table an array if it has indexes 1..n for its n items, and no
LuaUI\Widgets\gui_chiliselections.lua 896 selectedUnitsByDef.n = nil
LuaUI\Widgets\gui_chili_integral_menu.lua 749 widgetHandler.commands.n = cmdCount
LuaUI\Widgets\unit_group_move.lua 29 if selUnits.n > 1 then
LuaUI\Widgets\unit_healthbars.lua 202 for i=1,ud.weapons.n do
LuaUI\Widgets\unit_rangerings.lua 67 selUnits.n = nil -- So our loop works
Notepad++. Search in files. .n Whole word.Forboding Angel wrote:that was an export of results from baregrep.
thing is, nobody said the new spring version would be backwards compatible. in fact, the opposite is implied by the fact that this (and more importantly the other) thread was created.zwzsg wrote:When they said Windows was backward compatible, then didn't mean every single DOS games had to be remade to work under Windows.
Bad idea, just keep as is.zwzsg wrote:LuraRules\draw.lua 6 if (not arg) then arg = {...}; arg.n = #arg end
WTF is this if select == nil ?? Doesn't make any sense! I'd say delete it, and see if anything breaks.
Again no change required.zwzsg wrote:LuaUI\Widgets\gui_chiliselections.lua 896 selectedUnitsByDef.n = nil
Remove that line, and below, change:
or i,v in pairs(selectedUnitsByDef)
into:
or i,v in ipairs(selectedUnitsByDef)
Totally unrelated.Forboding Angel wrote:On the subject of being a broken record...
I read somewhere in this thread to look for [n] as well. What about these?