FORCE messages

[cleanrock]

From #sy:
11:38 cleanrock: i think we should go with gajops idea of using FORCE* lobby messages only between privileged hosts and server and use non-FORCE (regular) messages to players
11:39 cleanrock: gajop, correct me if i got that wrong
11:41 gajop: that seems right; bots send FORCE* commands, users receive normal commands, so it's transparent to the user

ZK forum thread related:
http://zero-k.info/Forum/Thread/6692?page=1

Good idea?
Can we make this a painless change?

[gajop]

Also related: https://github.com/spring/uberserver/issues/121

[abma]

Good idea?
Can we make this a painless change?

FORCE* commands protocol specs were written by several people, this is why implementation is inconsistent. good idea... hmm, making it consistent yes, making it server only without sending info to the client who issued the command... imo no.


imo the argueable points is:
how should lobby clients detect when FORCE* was used? they should show some info that this happened to the user.

refering to uberservers issue #121:

i have no clue what was discussed about FORCEJOINBATTLE before it was defined and implemented, protocol spec basicly was written by licho and aegis implemented it on uberserver (thats how i understood the lobby dev meeting minutes). i guess client support is needed to show the user that he is moved to a different battle.


quote from bugreport:

Please revert to original implementation which faked LEAVEBATTLE and battlejoined .. that worked everywhere without issues..

there is nothing to revert, FORCEJOINBATTLE is as the original implementation. idk why wrong info is spread arround in forums. i guess licho meant to revert this commit: https://github.com/spring/uberserver/co ... 8ecb93d22b which removed an undocumented, insecure & very hacky command from the lobby server. i hope everyone agrees that such an command shouldn't exist on the lobby server.


protocol spec is pretty clear:

http://springrts.com/dl/LobbyProtocol/P ... TLE:client

[abma]

my conclusion: some server message FORCED ... server command should be added to indicate issued FORCE commands to the client when it has to be "transparent". without such a message it will be very difficult to find bugs and/or show informations to users, but i don't have the time to do so atm.

[Licho]

At one point i implemented forcejoin which simply sent the correct sucession of commands to clients. I admit it was done by directly modifying protocol.py on server because i treated it as a test. Maybe it got overwritten/never commited.

Anyway its trivial to do it so .. its trivial to make a specialized command that sends left/joined commands and nothing more..

[abma]

Anyway its trivial to do it so

if its trivial, feel free to create a pull request with the changes. but please make it so clients get an info that the FORCE/JOIN command was issued by a foreign client.