Shader writers: Please don't use frac() in shader code

[imbaczek]

Use fract() instead. frac() doesn't exist on ATIs.

[Argh]

I will check the LUPS module.

<checks>

It's clean.

[Caydr]

Searched the entire contents of CA, no references to frac. I guess the problem's not too widespread.

Code: Select all

Find 'fract(' in 'CA\lups\ParticleClasses\SimpleParticles.lua':
CA\lups\ParticleClasses\SimpleParticles.lua(234):
           gl_FrontColor = mix(colormap[ipos1],colormap[ipos2],fract(cpos));
Found 'fract(' 1 time(s).
----------------------------------------
Find 'fract(' in 'CA\lups\ParticleClasses\SimpleParticles2.lua':
CA\lups\ParticleClasses\SimpleParticles2.lua(238):
            gl_FrontColor = mix(colormap[ipos1], colormap[ipos2], fract(cpos));
Found 'fract(' 1 time(s).
----------------------------------------
Find 'fract(' in CA\lups\ParticleClasses\StaticParticles.lua':
CA\lups\ParticleClasses\StaticParticles.lua(178):
            gl_FrontColor = mix(colormap[ipos1],colormap[ipos2],fract(cpos));
Found 'fract(' 1 time(s).
Search complete, found 'fract(' 3 time(s). (3 file(s)).

BA does use it once though:

Code: Select all

Find 'frac(' in 'BA\lups\ParticleClasses\ThundAirJet.lua':
BA\lups\ParticleClasses\ThundAirJet.lua(149):
           gl_FragColor.rgb += pow(opac,frac(timer*70.0)+6.0);           //white flame
Found 'frac(' 1 time(s).
Search complete, found 'frac(' 1 time(s). (1 file(s)).