alba git OpenAL/Sound.cpp missing includes

alba git OpenAL/Sound.cpp missing includes

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

Post Reply
pheldens
Posts: 191
Joined: 12 Aug 2006, 21:35

alba git OpenAL/Sound.cpp missing includes

Post by pheldens »

needs extra includes

spring/rts/System/Sound/OpenAL/Sound.cpp
# include <al.h>
# include <alc.h>
# include <alext.h>


else

[ 51%] Building CXX object rts/System/Sound/CMakeFiles/sound.dir/OpenAL/Sound.cpp.o
/usr/src/spring/rts/System/Sound/OpenAL/Sound.cpp: In member function ‘void CSound::StartThread(int)’:
/usr/src/spring/rts/System/Sound/OpenAL/Sound.cpp:337:53: error: ‘ALC_ALL_DEVICES_SPECIFIER’ was not declared in this scope
const char* deviceSpecifier = alcGetString(NULL, ALC_ALL_DEVICES_SPECIFIER);
abma
Spring Developer
Posts: 3798
Joined: 01 Jun 2009, 00:08

Re: alba git OpenAL/Sound.cpp missing includes

Post by abma »

these headers are already included:

https://github.com/spring/spring/blob/d ... und.cpp#L7 which includes EFX.h:
https://github.com/spring/spring/blob/d ... L/EFX.h#L8

edit:

alext.h seems missing. does it work when you include this file only in Sound.cpp?
pheldens
Posts: 191
Joined: 12 Aug 2006, 21:35

Re: alba git OpenAL/Sound.cpp missing includes

Post by pheldens »

abma wrote:these headers are already included:

https://github.com/spring/spring/blob/d ... und.cpp#L7 which includes EFX.h:
https://github.com/spring/spring/blob/d ... L/EFX.h#L8

edit:

alext.h seems missing. does it work when you include this file only in Sound.cpp?
it did yes
abma
Spring Developer
Posts: 3798
Joined: 01 Jun 2009, 00:08

Re: alba git OpenAL/Sound.cpp missing includes

Post by abma »

applied, thanks: https://github.com/spring/spring/commit ... fbed0ef391

for the curious: which os do you have?
Post Reply

Return to “Engine”