Page 1 of 1
Correc the setSFXoccupy function name,
Posted: 02 May 2014, 02:38
by smoth
in "rts\Sim\Units\Scripts\LuaScriptNames.cpp"
scriptNames[LUAFN_SetSFXOccupy] = "setSFXoccupy";
needs to be:
scriptNames[LUAFN_SetSFXOccupy] = "SetSFXOccupy";
Needs correction for consistency.
Re: Correc the setSFXoccupy function name,
Posted: 02 May 2014, 02:43
by Floris
I want to order 3 kitchens?
can I has delivery soon?
Re: Correc the setSFXoccupy function name,
Posted: 02 May 2014, 03:26
by knorke
Was noticed before:
http://springrts.com/phpbb/viewtopic.ph ... py#p417643
when discussed in chat iirc the result was "oh no all the scripts needs updating!" and that the real problem is the silly name and behaviour of that function.
If the name gets changed and script need to be adjusted anyway, then please not just for making small s into big S. Instead sensible name like TerrainTypeChange() or something.
Re: Correc the setSFXoccupy function name,
Posted: 02 May 2014, 03:39
by smoth
Well not just the S needs correction.
Still whatever, make it a new name, just make it a better, consistent name. COB/BOS needn't change but IMO internally and Lua needs change.
Re: Correc the setSFXoccupy function name,
Posted: 03 May 2014, 01:58
by Jools
Don't rename functiuons just for the sake if renaming, it breaks backward and forward compatibility and besides, the function works just as well even if it has a silly name or not. It's like wondering how that hamburger looks like when you have eaten it. It's better not to.
Re: Correc the setSFXoccupy function name,
Posted: 03 May 2014, 04:40
by smoth
how many lua unit scripts would this break?
Maybe a few.
I was very clear that they should update the Lua only.
Re: Correc the setSFXoccupy function name,
Posted: 03 May 2014, 14:53
by Jools
I stand corrected
Re: Correc the setSFXoccupy function name,
Posted: 11 Sep 2014, 05:42
by smoth
So the engine developers never responded to this.
Re: Correc the setSFXoccupy function name,
Posted: 11 Sep 2014, 07:12
by jK